[Libreoffice-commits] core.git: bin/find-unneeded-includes

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Mon Oct 8 10:15:45 UTC 2018


 bin/find-unneeded-includes |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 9b686537f59a63bad05a0cfe7fc5f1096bb7a7c1
Author:     Gabor Kelemen <kelemeng at ubuntu.com>
AuthorDate: Sat Oct 6 23:25:46 2018 +0200
Commit:     Miklos Vajna <vmiklos at collabora.co.uk>
CommitDate: Mon Oct 8 12:15:23 2018 +0200

    find-unneeded-includes: warn about fw decls in namespaces too
    
    This regex parsed unneeded fw declarations reported by IWYU in the form of:
    class foo;
    But not ones inside namespaces, e.g.:
    namespace foo { class bar; }
    namespace com { namespace sun { namespace star { namespace foo { class bar; } } } }
    
    Change-Id: Ie2962b9fb1cf9382e8da45903f3716d0311dd58e
    Reviewed-on: https://gerrit.libreoffice.org/61485
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.co.uk>

diff --git a/bin/find-unneeded-includes b/bin/find-unneeded-includes
index 4196640e5d2b..7f221e646e14 100755
--- a/bin/find-unneeded-includes
+++ b/bin/find-unneeded-includes
@@ -155,7 +155,7 @@ def processIWYUOutput(iwyuOutput, moduleRules):
                     toRemove.append("%s:%s: %s" % (currentFileName, lineno, include))
                 continue
 
-            match = re.match("- (.*);  // lines (.*)-.*", line)
+            match = re.match("- (.*;(?: })*)*  // lines (.*)-.*", line)
             if match:
                 fwdDecl = match.group(1)
                 lineno = match.group(2)


More information about the Libreoffice-commits mailing list