[Libreoffice-commits] core.git: basctl/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Mon Oct 8 12:41:46 UTC 2018


 basctl/source/basicide/baside2.cxx |    7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

New commits:
commit d75a96d50bb62e40d69d7ab432ca94f23d36e82f
Author:     Jochen Nitschke <j.nitschke+logerrit at ok.de>
AuthorDate: Mon Oct 8 13:08:06 2018 +0200
Commit:     Jochen Nitschke <j.nitschke+logerrit at ok.de>
CommitDate: Mon Oct 8 14:41:24 2018 +0200

    cppcheck: knownConditionTrueFalse
    
    Change-Id: I245a353b69af7dcedf4c0f3f1271f1fdf86fd09c
    Reviewed-on: https://gerrit.libreoffice.org/61523
    Tested-by: Jenkins
    Reviewed-by: Jochen Nitschke <j.nitschke+logerrit at ok.de>

diff --git a/basctl/source/basicide/baside2.cxx b/basctl/source/basicide/baside2.cxx
index a10f1b9ba34b..15d2715a6973 100644
--- a/basctl/source/basicide/baside2.cxx
+++ b/basctl/source/basicide/baside2.cxx
@@ -269,11 +269,8 @@ void ModulWindow::CheckCompileBasic()
 
             GetShell()->GetViewFrame()->GetWindow().EnterWait();
 
-            if( bModified )
-            {
-                AssertValidEditEngine();
-                GetEditorWindow().SetSourceInBasic();
-            }
+            AssertValidEditEngine();
+            GetEditorWindow().SetSourceInBasic();
 
             bool bWasModified = GetBasic()->IsModified();
 


More information about the Libreoffice-commits mailing list