[Libreoffice-commits] core.git: sd/qa

[Libreoffice Gerrit user]

 sd/qa/unit/dialogs-test.cxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 754cff7a3f5e6c7a8ff0aa39cc94c3246d7125ee
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Wed Oct 10 23:56:54 2018 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu Oct 11 08:13:33 2018 +0200

    Avoid error with old Clang
    
    <https://ci.libreoffice.org/job/lo_ubsan/1065/console>:
    
    > [build CXX] chart2/source/controller/dialogs/tp_Wizard_TitlesAndObjects.cxx
    > /home/tdf/lode/jenkins/workspace/lo_ubsan/sd/qa/unit/dialogs-test.cxx:430:41: error: default initialization of an object of const type 'const std::vector<OUString>' without a user-provided default constructor
    >             const std::vector<OUString> aPageNames;
    >                                         ^
    >                                                   {}
    > 1 error generated.
    
    Change-Id: I543ba3420e1997f21bc2c83c632fbd93ef016459
    Reviewed-on: https://gerrit.libreoffice.org/61638
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/sd/qa/unit/dialogs-test.cxx b/sd/qa/unit/dialogs-test.cxx
index 96c4d6807424..71f4c742537b 100644
--- a/sd/qa/unit/dialogs-test.cxx
+++ b/sd/qa/unit/dialogs-test.cxx
@@ -427,7 +427,6 @@ VclPtr<VclAbstractDialog> SdDialogsTest::createDialogByID(sal_uInt32 nID)
         case 13:
         {
             // CreateSdStartPresentationDlg(weld::Window* pWindow, const SfxItemSet& rInAttrs, const std::vector<OUString> &rPageNames, SdCustomShowList* pCSList) override;
-            const std::vector<OUString> aPageNames;
             SdDrawDocument* pDrawDoc = getSdXImpressDocument()->GetDoc();
             CPPUNIT_ASSERT(pDrawDoc);
             SfxItemSet aDlgSet(pDrawDoc->GetItemPool(), svl::Items<ATTR_PRESENT_START, ATTR_PRESENT_END>{});
@@ -451,7 +450,7 @@ VclPtr<VclAbstractDialog> SdDialogsTest::createDialogByID(sal_uInt32 nID)
             pRetval = getSdAbstractDialogFactory()->CreateSdStartPresentationDlg(
                 pWin ? pWin->GetFrameWeld() : nullptr,
                 aDlgSet,
-                aPageNames,
+                std::vector<OUString>(),
                 nullptr);
             break;
         }