[Libreoffice-commits] core.git: cui/inc cui/source
Libreoffice Gerrit user
logerrit at kemper.freedesktop.org
Sun Oct 14 23:47:21 UTC 2018
cui/inc/strings.hrc | 2 +-
cui/source/dialogs/cuicharmap.cxx | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
New commits:
commit cf2825d9f8af86a73aae5ac4216966504b320184
Author: Adolfo Jayme Barrientos <fitojb at ubuntu.com>
AuthorDate: Wed Sep 12 16:14:28 2018 -0500
Commit: Adolfo Jayme Barrientos <fitojb at ubuntu.com>
CommitDate: Mon Oct 15 01:46:59 2018 +0200
The code doesn’t check for glyphs, but for code points (i.e., characters)
This string was a little misleading. A typical pair of OS-provided fonts
can encode glyphs at different code points (e.g., the f+i ligature is
encoded at U+F001 (legacy position) in Arial Black but at U+FB01 in
Comic Sans MS.
Change-Id: I6ca93e9ad247f62e1674a03d6ab1bc0800df3612
Reviewed-on: https://gerrit.libreoffice.org/60419
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb at ubuntu.com>
diff --git a/cui/inc/strings.hrc b/cui/inc/strings.hrc
index 71ff45488568..f8cc42be3fcb 100644
--- a/cui/inc/strings.hrc
+++ b/cui/inc/strings.hrc
@@ -100,7 +100,7 @@
#define RID_SVXSTR_INSERTROW_BEFORE NC_("RID_SVXSTR_INSERTROW_BEFORE", "Above selection")
#define RID_SVXSTR_INSERTROW_AFTER NC_("RID_SVXSTR_INSERTROW_AFTER", "Below selection")
#define RID_SVXSTR_REMOVE_FAVORITES NC_("RID_SVXSTR_REMOVE_FAVORITES", "Remove from Favorites")
-#define RID_SVXSTR_MISSING_GLYPH NC_("RID_SVXSTR_MISSING_GLYPH", "Missing Glyph")
+#define RID_SVXSTR_MISSING_CHAR NC_("RID_SVXSTR_MISSING_CHAR", "Missing character")
#define RID_SVXSTR_ADD_FAVORITES NC_("RID_SVXSTR_ADD_FAVORITES", "Add to Favorites")
// PPI is pixel per inch, %1 is a number
#define RID_SVXSTR_PPI NC_("RID_SVXSTR_PPI", "(%1 PPI)")
diff --git a/cui/source/dialogs/cuicharmap.cxx b/cui/source/dialogs/cuicharmap.cxx
index 4ffc213003ca..64581f5f5165 100644
--- a/cui/source/dialogs/cuicharmap.cxx
+++ b/cui/source/dialogs/cuicharmap.cxx
@@ -1049,7 +1049,7 @@ void SvxCharacterMap::selectCharByCode(Radix radix)
// Select the corresponding character
SetChar(cChar);
else {
- m_xCharName->set_label(CuiResId(RID_SVXSTR_MISSING_GLYPH));
+ m_xCharName->set_label(CuiResId(RID_SVXSTR_MISSING_CHAR));
m_aShowChar.SetText(" ");
switch(radix)
{
More information about the Libreoffice-commits
mailing list