[Libreoffice-commits] core.git: 2 commits - chart2/source compilerplugins/clang editeng/source include/svx sc/inc sc/source sd/source svx/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Mon Oct 15 10:53:39 UTC 2018


 chart2/source/controller/dialogs/res_LegendPosition.cxx             |   26 --
 chart2/source/controller/inc/res_LegendPosition.hxx                 |    5 
 compilerplugins/clang/unusedfields.only-used-in-constructor.results |   56 ++--
 compilerplugins/clang/unusedfields.readonly.results                 |   28 +-
 compilerplugins/clang/unusedfields.untouched.results                |   66 +++--
 compilerplugins/clang/unusedfields.writeonly.results                |    6 
 compilerplugins/clang/unusedmethods.results                         |  126 ++++------
 compilerplugins/clang/unusedmethods.unused-returns.results          |   10 
 editeng/source/editeng/editstt2.hxx                                 |    3 
 include/svx/langbox.hxx                                             |    1 
 include/svx/svdundo.hxx                                             |    1 
 sc/inc/columnspanset.hxx                                            |    2 
 sc/source/core/data/columnspanset.cxx                               |   62 ----
 sd/source/ui/animations/CustomAnimationDialog.hxx                   |    2 
 svx/source/svdraw/svdundo.cxx                                       |    5 
 15 files changed, 148 insertions(+), 251 deletions(-)

New commits:
commit afed3d177b8bfbc98d631867f200486bc2963e03
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Sun Oct 14 08:41:12 2018 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Oct 15 12:53:27 2018 +0200

    loplugin:unusedfields
    
    Change-Id: I4ebd1e89daf7ba5e6ab709f56c0fec5b49f50dd0
    Reviewed-on: https://gerrit.libreoffice.org/61774
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/chart2/source/controller/dialogs/res_LegendPosition.cxx b/chart2/source/controller/dialogs/res_LegendPosition.cxx
index 0d6963266ec9..8eab04a77e0f 100644
--- a/chart2/source/controller/dialogs/res_LegendPosition.cxx
+++ b/chart2/source/controller/dialogs/res_LegendPosition.cxx
@@ -248,7 +248,6 @@ SchLegendPositionResources::SchLegendPositionResources(weld::Builder& rBuilder)
     , m_xRbtTop(rBuilder.weld_radio_button("top"))
     , m_xRbtBottom(rBuilder.weld_radio_button("bottom"))
 {
-    impl_setRadioButtonToggleHdl();
 }
 
 SchLegendPositionResources::SchLegendPositionResources(weld::Builder& rBuilder,
@@ -261,15 +260,6 @@ SchLegendPositionResources::SchLegendPositionResources(weld::Builder& rBuilder,
     , m_xRbtBottom(rBuilder.weld_radio_button("bottom"))
 {
     m_xCbxShow->connect_toggled(LINK(this, SchLegendPositionResources, PositionEnableHdl));
-    impl_setRadioButtonToggleHdl();
-}
-
-void SchLegendPositionResources::impl_setRadioButtonToggleHdl()
-{
-    m_xRbtLeft->connect_toggled(LINK(this, SchLegendPositionResources, PositionChangeHdl));
-    m_xRbtTop->connect_toggled(LINK(this, SchLegendPositionResources, PositionChangeHdl));
-    m_xRbtRight->connect_toggled(LINK(this, SchLegendPositionResources, PositionChangeHdl));
-    m_xRbtBottom->connect_toggled(LINK(this, SchLegendPositionResources, PositionChangeHdl));
 }
 
 SchLegendPositionResources::~SchLegendPositionResources()
@@ -374,8 +364,6 @@ IMPL_LINK_NOARG(SchLegendPositionResources, PositionEnableHdl, weld::ToggleButto
     m_xRbtTop->set_sensitive( bEnable );
     m_xRbtRight->set_sensitive( bEnable );
     m_xRbtBottom->set_sensitive( bEnable );
-
-    m_aChangeLink.Call(nullptr);
 }
 
 void SchLegendPositionResources::initFromItemSet( const SfxItemSet& rInAttrs )
@@ -426,20 +414,6 @@ void SchLegendPositionResources::writeToItemSet( SfxItemSet& rOutAttrs ) const
     rOutAttrs.Put( SfxBoolItem(SCHATTR_LEGEND_SHOW, !m_xCbxShow || m_xCbxShow->get_active()) );
 }
 
-IMPL_LINK(SchLegendPositionResources, PositionChangeHdl, weld::ToggleButton&, rRadio, void )
-{
-    //for each radio click there are coming two change events
-    //first uncheck of previous button -> ignore that call
-    //the second call gives the check of the new button
-    if (rRadio.get_active())
-        m_aChangeLink.Call(nullptr);
-}
-
-void SchLegendPositionResources::SetChangeHdl( const Link<LinkParamNone*,void>& rLink )
-{
-    m_aChangeLink = rLink;
-}
-
 } //namespace chart
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/chart2/source/controller/inc/res_LegendPosition.hxx b/chart2/source/controller/inc/res_LegendPosition.hxx
index 1568781e4818..149fbc5336a4 100644
--- a/chart2/source/controller/inc/res_LegendPosition.hxx
+++ b/chart2/source/controller/inc/res_LegendPosition.hxx
@@ -90,14 +90,9 @@ public:
     void SetChangeHdl( const Link<LinkParamNone*,void>& rLink );
 
     DECL_LINK(PositionEnableHdl, weld::ToggleButton&, void);
-    DECL_LINK(PositionChangeHdl, weld::ToggleButton&, void);
-
-private:
-    void impl_setRadioButtonToggleHdl();
 
 private:
     css::uno::Reference< css::uno::XComponentContext>    m_xCC;
-    Link<LinkParamNone*,void> m_aChangeLink;
 
     std::unique_ptr<weld::CheckButton> m_xCbxShow;
     std::unique_ptr<weld::RadioButton> m_xRbtLeft;
diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
index a805f4071a20..cb5ff6936455 100644
--- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results
+++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
@@ -9,9 +9,9 @@ avmedia/source/vlc/wrapper/Types.hxx:44
 avmedia/source/vlc/wrapper/Types.hxx:45
     libvlc_event_t::(anonymous union)::(anonymous) dummy2 const char *
 avmedia/source/vlc/wrapper/Types.hxx:46
-    libvlc_event_t::(anonymous) padding struct (anonymous struct at /media/noel/disk2/libo5/avmedia/source/vlc/wrapper/Types.hxx:43:7)
+    libvlc_event_t::(anonymous) padding struct (anonymous struct at /media/noel/disk2/libo6/avmedia/source/vlc/wrapper/Types.hxx:43:7)
 avmedia/source/vlc/wrapper/Types.hxx:47
-    libvlc_event_t u union (anonymous union at /media/noel/disk2/libo5/avmedia/source/vlc/wrapper/Types.hxx:41:5)
+    libvlc_event_t u union (anonymous union at /media/noel/disk2/libo6/avmedia/source/vlc/wrapper/Types.hxx:41:5)
 avmedia/source/vlc/wrapper/Types.hxx:53
     libvlc_track_description_t psz_name char *
 basegfx/source/polygon/b2dtrapezoid.cxx:201
@@ -120,7 +120,7 @@ cppu/source/uno/check.cxx:138
     (anonymous namespace)::Char4 chars struct (anonymous namespace)::Char3
 cui/source/dialogs/colorpicker.cxx:712
     cui::ColorPickerDialog m_aColorPrevious class cui::ColorPreviewControl
-cui/source/factory/dlgfact.cxx:1418
+cui/source/factory/dlgfact.cxx:1421
     SvxMacroAssignDialog m_aItems class SfxItemSet
 cui/source/inc/cfgutil.hxx:190
     SvxScriptSelectorDialog m_aStylesInfo struct SfxStylesInfo_Impl
@@ -136,8 +136,6 @@ cui/source/inc/tabstpge.hxx:95
     SvxTabulatorTabPage m_aCenterWin class TabWin_Impl
 cui/source/inc/tabstpge.hxx:96
     SvxTabulatorTabPage m_aDezWin class TabWin_Impl
-cui/source/tabpages/backgrnd.cxx:73
-    SvxBackgroundPage_Impl bIsImportDlgInExecute _Bool
 dbaccess/source/core/api/RowSet.hxx:111
     dbaccess::ORowSet m_aURL class rtl::OUString
 dbaccess/source/core/api/RowSet.hxx:125
@@ -203,9 +201,9 @@ include/registry/registry.hxx:35
 include/sfx2/classificationhelper.hxx:127
     sfx::ClassificationKeyCreator m_ePolicyType const enum SfxClassificationPolicyType
 include/sfx2/msg.hxx:117
-    SfxType0 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
+    SfxType0 createSfxPoolItemFunc const std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:119
-    SfxType0 nAttribs sal_uInt16
+    SfxType0 nAttribs const sal_uInt16
 include/svl/ondemand.hxx:58
     OnDemandLocaleDataWrapper aSysLocale class SvtSysLocale
 include/svx/ClassificationDialog.hxx:59
@@ -289,17 +287,17 @@ pyuno/source/module/pyuno_impl.hxx:324
 reportdesign/source/core/api/ReportDefinition.cxx:241
     reportdesign::OStyle m_aSize awt::Size
 sal/osl/unx/thread.cxx:90
-    osl_thread_priority_st m_Highest int
+    osl_thread_priority_st m_Highest const int
 sal/osl/unx/thread.cxx:91
-    osl_thread_priority_st m_Above_Normal int
+    osl_thread_priority_st m_Above_Normal const int
 sal/osl/unx/thread.cxx:92
-    osl_thread_priority_st m_Normal int
+    osl_thread_priority_st m_Normal const int
 sal/osl/unx/thread.cxx:93
-    osl_thread_priority_st m_Below_Normal int
+    osl_thread_priority_st m_Below_Normal const int
 sal/osl/unx/thread.cxx:94
-    osl_thread_priority_st m_Lowest int
+    osl_thread_priority_st m_Lowest const int
 sal/osl/unx/thread.cxx:112
-    osl_thread_global_st m_priority struct osl_thread_priority_st
+    osl_thread_global_st m_priority const struct osl_thread_priority_st
 sal/qa/osl/process/osl_process.cxx:157
     Test_osl_executeProcess env_param_ const class rtl::OUString
 sal/textenc/textenc.cxx:406
@@ -314,7 +312,7 @@ sc/inc/compiler.hxx:259
     ScCompiler::AddInMap pUpper const char *
 sc/inc/formulalogger.hxx:42
     sc::FormulaLogger maMessages std::vector<OUString>
-sc/inc/interpretercontext.hxx:31
+sc/inc/interpretercontext.hxx:32
     ScInterpreterContext mrDoc const class ScDocument &
 sc/inc/token.hxx:406
     SingleDoubleRefModifier aDub struct ScComplexRefData
@@ -385,11 +383,11 @@ sccomp/source/solver/DifferentialEvolution.hxx:35
 sccomp/source/solver/ParticelSwarmOptimization.hxx:56
     ParticleSwarmOptimizationAlgorithm maRandomDevice std::random_device
 scripting/source/stringresource/stringresource.cxx:1310
-    stringresource::BinaryInput m_aData Sequence<sal_Int8>
+    stringresource::BinaryInput m_aData const Sequence<sal_Int8>
 sd/inc/anminfo.hxx:52
-    SdAnimationInfo maSecondSoundFile class rtl::OUString
+    SdAnimationInfo maSecondSoundFile const class rtl::OUString
 sd/source/filter/eppt/epptbase.hxx:347
-    PPTWriterBase maFraction class Fraction
+    PPTWriterBase maFraction const class Fraction
 sd/source/filter/ppt/pptin.hxx:82
     SdPPTImport maParam struct PowerPointImportParam
 sd/source/ui/inc/AccessibleDocumentViewBase.hxx:262
@@ -397,23 +395,23 @@ sd/source/ui/inc/AccessibleDocumentViewBase.hxx:262
 sd/source/ui/remotecontrol/Receiver.hxx:36
     sd::Receiver pTransmitter class sd::Transmitter *
 sd/source/ui/remotecontrol/ZeroconfService.hxx:36
-    sd::ZeroconfService port uint
+    sd::ZeroconfService port const uint
 sd/source/ui/table/TableDesignPane.hxx:104
-    sd::TableDesignPane aImpl class sd::TableDesignWidget
+    sd::TableDesignPane aImpl const class sd::TableDesignWidget
 sd/source/ui/view/DocumentRenderer.cxx:1319
-    sd::DocumentRenderer::Implementation mxObjectShell SfxObjectShellRef
+    sd::DocumentRenderer::Implementation mxObjectShell const SfxObjectShellRef
 sd/source/ui/view/viewshel.cxx:1211
-    sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock sd::slidesorter::view::class SlideSorterView::DrawLock
+    sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock const sd::slidesorter::view::class SlideSorterView::DrawLock
 sd/source/ui/view/viewshel.cxx:1212
-    sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock sd::slidesorter::controller::class SlideSorterController::ModelChangeLock
+    sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock const sd::slidesorter::controller::class SlideSorterController::ModelChangeLock
 sd/source/ui/view/viewshel.cxx:1213
-    sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock
+    sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock const sd::slidesorter::controller::class PageSelector::UpdateLock
 sd/source/ui/view/viewshel.cxx:1214
-    sd::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::class SelectionObserver::Context
+    sd::KeepSlideSorterInSyncWithPageChanges m_aContext const sd::slidesorter::controller::class SelectionObserver::Context
 sfx2/source/doc/doctempl.cxx:116
-    DocTempl::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock
+    DocTempl::DocTempl_EntryData_Impl mxObjShell const class SfxObjectShellLock
 slideshow/source/engine/animationnodes/animationbasenode.hxx:89
-    slideshow::internal::AnimationBaseNode mpSubsetManager slideshow::internal::SubsettableShapeManagerSharedPtr
+    slideshow::internal::AnimationBaseNode mpSubsetManager const slideshow::internal::SubsettableShapeManagerSharedPtr
 slideshow/source/engine/opengl/TransitionImpl.hxx:296
     Vertex normal glm::vec3
 slideshow/source/engine/opengl/TransitionImpl.hxx:297
@@ -449,7 +447,7 @@ svl/source/crypto/cryptosign.cxx:282
 svtools/source/inc/svimpbox.hxx:125
     SvImpLBox aFctSet class ImpLBSelEng
 svtools/source/svhtml/htmlkywd.cxx:558
-    HTML_OptionEntry  union HTML_OptionEntry::(anonymous at /media/noel/disk2/libo5/svtools/source/svhtml/htmlkywd.cxx:558:5)
+    HTML_OptionEntry  union HTML_OptionEntry::(anonymous at /media/noel/disk2/libo6/svtools/source/svhtml/htmlkywd.cxx:558:5)
 svtools/source/svhtml/htmlkywd.cxx:560
     HTML_OptionEntry::(anonymous) sToken const sal_Char *
 svtools/source/svhtml/htmlkywd.cxx:561
@@ -584,13 +582,13 @@ vcl/inc/unx/i18n_ic.hxx:46
     SalI18N_InputContext maSwitchIMCallback XIMCallback
 vcl/inc/unx/i18n_ic.hxx:47
     SalI18N_InputContext maDestroyCallback XIMCallback
-vcl/source/app/salvtables.cxx:1525
+vcl/source/app/salvtables.cxx:1542
     SalInstanceEntry m_aTextFilter class SalInstanceEntry::WeldTextFilter
 vcl/source/gdi/jobset.cxx:35
     ImplOldJobSetupData cDeviceName char [32]
 vcl/source/gdi/jobset.cxx:36
     ImplOldJobSetupData cPortName char [32]
-vcl/unx/gtk3/gtk3gtkinst.cxx:2346
+vcl/unx/gtk3/gtk3gtkinst.cxx:2398
     CrippledViewport viewport GtkViewport
 vcl/unx/gtk/a11y/atkhypertext.cxx:29
     (anonymous) atk_hyper_link const AtkHyperlink
diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results
index 604979b329fd..06283c5ca7e5 100644
--- a/compilerplugins/clang/unusedfields.readonly.results
+++ b/compilerplugins/clang/unusedfields.readonly.results
@@ -52,6 +52,8 @@ bridges/source/jni_uno/jni_java2uno.cxx:151
     jni_uno::largest p void *
 bridges/source/jni_uno/jni_java2uno.cxx:152
     jni_uno::largest a uno_Any
+chart2/source/controller/inc/res_LegendPosition.hxx:93
+    chart::SchLegendPositionResources m_aChangeLink Link<class LinkParamNone *, void>
 chart2/source/model/main/DataPoint.hxx:108
     chart::DataPoint m_bNoParentPropAllowed _Bool
 connectivity/source/drivers/evoab2/EApi.h:125
@@ -158,11 +160,11 @@ cui/source/options/optcolor.cxx:255
     ColorConfigWindow_Impl aModuleOptions class SvtModuleOptions
 cui/source/options/optpath.cxx:79
     OptPath_Impl m_aDefOpt class SvtDefaultOptions
-cui/source/options/personalization.hxx:39
+cui/source/options/personalization.hxx:45
     SvxPersonalizationTabPage m_vDefaultPersonaImages VclPtr<class PushButton> [3]
-cui/source/options/personalization.hxx:103
+cui/source/options/personalization.hxx:109
     SelectPersonaDialog m_vResultList VclPtr<class PushButton> [9]
-cui/source/options/personalization.hxx:104
+cui/source/options/personalization.hxx:110
     SelectPersonaDialog m_vSearchSuggestions VclPtr<class PushButton> [6]
 cui/source/options/treeopt.cxx:469
     OptionsGroupInfo m_bLoadError _Bool
@@ -303,17 +305,17 @@ include/sfx2/msg.hxx:95
 include/sfx2/msg.hxx:96
     SfxTypeAttrib pName const char *
 include/sfx2/msg.hxx:105
-    SfxType createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
+    SfxType createSfxPoolItemFunc const std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:106
     SfxType pType const std::type_info *
 include/sfx2/msg.hxx:107
-    SfxType nAttribs sal_uInt16
+    SfxType nAttribs const sal_uInt16
 include/sfx2/msg.hxx:108
     SfxType aAttrib struct SfxTypeAttrib [1]
 include/sfx2/msg.hxx:118
     SfxType0 pType const std::type_info *
 include/sfx2/sidebar/ResourceManager.hxx:108
-    sfx2::sidebar::ResourceManager maMiscOptions class SvtMiscOptions
+    sfx2::sidebar::ResourceManager maMiscOptions const class SvtMiscOptions
 include/svl/adrparse.hxx:52
     SvAddressParser m_bHasFirst _Bool
 include/svl/ondemand.hxx:58
@@ -353,7 +355,7 @@ include/test/sheet/xnamedranges.hxx:38
 include/test/sheet/xspreadsheets2.hxx:46
     apitest::XSpreadsheets2 xDocument css::uno::Reference<css::sheet::XSpreadsheetDocument>
 include/unoidl/unoidl.hxx:444
-    unoidl::ConstantValue  union unoidl::ConstantValue::(anonymous at /media/noel/disk2/libo5/include/unoidl/unoidl.hxx:444:5)
+    unoidl::ConstantValue  union unoidl::ConstantValue::(anonymous at /media/noel/disk2/libo6/include/unoidl/unoidl.hxx:444:5)
 include/unoidl/unoidl.hxx:445
     unoidl::ConstantValue::(anonymous) booleanValue _Bool
 include/unoidl/unoidl.hxx:446
@@ -415,7 +417,7 @@ registry/source/reflwrit.cxx:142
 registry/source/reflwrit.cxx:182
     CPInfo::(anonymous) aUik struct RTUik *
 reportdesign/source/ui/inc/ColorListener.hxx:35
-    rptui::OColorListener m_aColorConfig svtools::ColorConfig
+    rptui::OColorListener m_aColorConfig const svtools::ColorConfig
 sal/osl/unx/process.cxx:825
     osl_procStat signal char [24]
 sal/osl/unx/process.cxx:826
@@ -437,7 +439,7 @@ sal/rtl/uuid.cxx:65
 sc/inc/compiler.hxx:127
     ScRawToken::(anonymous union)::(anonymous) eItem class ScTableRefToken::Item
 sc/inc/compiler.hxx:128
-    ScRawToken::(anonymous) table struct (anonymous struct at /media/noel/disk2/libo5/sc/inc/compiler.hxx:125:9)
+    ScRawToken::(anonymous) table struct (anonymous struct at /media/noel/disk2/libo6/sc/inc/compiler.hxx:125:9)
 sc/inc/compiler.hxx:133
     ScRawToken::(anonymous) pMat class ScMatrix *
 sc/inc/formulagroup.hxx:39
@@ -519,19 +521,19 @@ sd/source/ui/slideshow/showwindow.hxx:103
 sd/source/ui/slidesorter/cache/SlsPageCacheManager.cxx:143
     sd::slidesorter::cache::PageCacheManager::RecentlyUsedPageCaches maMap std::map<key_type, mapped_type>
 sd/source/ui/slidesorter/inc/controller/SlsAnimator.hxx:97
-    sd::slidesorter::controller::Animator maElapsedTime ::canvas::tools::ElapsedTime
+    sd::slidesorter::controller::Animator maElapsedTime const ::canvas::tools::ElapsedTime
 sd/source/ui/table/TableDesignPane.hxx:94
     sd::TableDesignWidget m_aCheckBoxes VclPtr<class CheckBox> [6]
 sdext/source/pdfimport/inc/pdfihelper.hxx:101
     pdfi::GraphicsContext BlendMode sal_Int8
 sdext/source/pdfimport/tree/style.hxx:42
-    pdfi::StyleContainer::Style Contents class rtl::OUString
+    pdfi::StyleContainer::Style Contents const class rtl::OUString
 sfx2/source/appl/lnkbase2.cxx:95
     sfx2::ImplDdeItem pLink class sfx2::SvBaseLink *
 slideshow/source/engine/slideshowimpl.cxx:153
-    (anonymous namespace)::FrameSynchronization maTimer canvas::tools::ElapsedTime
+    (anonymous namespace)::FrameSynchronization maTimer const canvas::tools::ElapsedTime
 sot/source/sdstor/ucbstorage.cxx:408
-    UCBStorageStream_Impl m_aKey class rtl::OString
+    UCBStorageStream_Impl m_aKey const class rtl::OString
 starmath/source/view.cxx:856
     SmViewShell_Impl aOpts const class SvtMiscOptions
 store/source/storbios.cxx:59
diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results
index 0d04a5e775df..73fd588bd617 100644
--- a/compilerplugins/clang/unusedfields.untouched.results
+++ b/compilerplugins/clang/unusedfields.untouched.results
@@ -5,9 +5,9 @@ avmedia/source/vlc/wrapper/Types.hxx:44
 avmedia/source/vlc/wrapper/Types.hxx:45
     libvlc_event_t::(anonymous union)::(anonymous) dummy2 const char *
 avmedia/source/vlc/wrapper/Types.hxx:46
-    libvlc_event_t::(anonymous) padding struct (anonymous struct at /media/noel/disk2/libo5/avmedia/source/vlc/wrapper/Types.hxx:43:7)
+    libvlc_event_t::(anonymous) padding struct (anonymous struct at /media/noel/disk2/libo6/avmedia/source/vlc/wrapper/Types.hxx:43:7)
 avmedia/source/vlc/wrapper/Types.hxx:47
-    libvlc_event_t u union (anonymous union at /media/noel/disk2/libo5/avmedia/source/vlc/wrapper/Types.hxx:41:5)
+    libvlc_event_t u union (anonymous union at /media/noel/disk2/libo6/avmedia/source/vlc/wrapper/Types.hxx:41:5)
 avmedia/source/vlc/wrapper/Types.hxx:53
     libvlc_track_description_t psz_name char *
 basctl/source/inc/dlged.hxx:122
@@ -86,10 +86,6 @@ cui/source/inc/transfrm.hxx:190
     SvxAngleTabPage m_xCtlRect std::unique_ptr<weld::CustomWeld>
 cui/source/inc/transfrm.hxx:193
     SvxAngleTabPage m_xCtlAngle std::unique_ptr<weld::CustomWeld>
-cui/source/tabpages/backgrnd.cxx:72
-    SvxBackgroundPage_Impl pLoadIdle std::unique_ptr<Idle>
-cui/source/tabpages/backgrnd.cxx:73
-    SvxBackgroundPage_Impl bIsImportDlgInExecute _Bool
 dbaccess/source/sdbtools/inc/connectiondependent.hxx:116
     sdbtools::ConnectionDependentComponent::EntryGuard m_aMutexGuard ::osl::MutexGuard
 emfio/source/emfuno/xemfparser.cxx:60
@@ -117,9 +113,9 @@ include/registry/registry.hxx:35
 include/sfx2/mgetempl.hxx:63
     SfxManageStyleSheetPage m_xNameFt std::unique_ptr<weld::Label>
 include/sfx2/msg.hxx:117
-    SfxType0 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
+    SfxType0 createSfxPoolItemFunc const std::function<SfxPoolItem *(void)>
 include/sfx2/msg.hxx:119
-    SfxType0 nAttribs sal_uInt16
+    SfxType0 nAttribs const sal_uInt16
 include/svtools/ctrlbox.hxx:353
     SvtLineListBox m_xLineSetWin std::unique_ptr<weld::CustomWeld>
 include/svtools/genericunodialog.hxx:218
@@ -185,20 +181,20 @@ reportdesign/source/ui/inc/PageNumber.hxx:41
 reportdesign/source/ui/inc/ReportWindow.hxx:54
     rptui::OReportWindow m_pObjFac std::unique_ptr<DlgEdFactory, o3tl::default_delete<DlgEdFactory> >
 sal/osl/unx/thread.cxx:90
-    osl_thread_priority_st m_Highest int
+    osl_thread_priority_st m_Highest const int
 sal/osl/unx/thread.cxx:91
-    osl_thread_priority_st m_Above_Normal int
+    osl_thread_priority_st m_Above_Normal const int
 sal/osl/unx/thread.cxx:92
-    osl_thread_priority_st m_Normal int
+    osl_thread_priority_st m_Normal const int
 sal/osl/unx/thread.cxx:93
-    osl_thread_priority_st m_Below_Normal int
+    osl_thread_priority_st m_Below_Normal const int
 sal/osl/unx/thread.cxx:94
-    osl_thread_priority_st m_Lowest int
+    osl_thread_priority_st m_Lowest const int
 sal/osl/unx/thread.cxx:112
-    osl_thread_global_st m_priority struct osl_thread_priority_st
+    osl_thread_global_st m_priority const struct osl_thread_priority_st
 sc/inc/formulalogger.hxx:42
     sc::FormulaLogger maMessages std::vector<OUString>
-sc/inc/interpretercontext.hxx:31
+sc/inc/interpretercontext.hxx:32
     ScInterpreterContext mrDoc const class ScDocument &
 sc/qa/unit/ucalc_column.cxx:104
     aInputs aName const char *
@@ -220,6 +216,24 @@ sc/source/ui/inc/docsh.hxx:462
     ScDocShellModificator mpProtector std::unique_ptr<ScRefreshTimerProtector>
 sc/source/ui/inc/instbdlg.hxx:66
     ScInsertTableDlg m_xBtnBehind std::unique_ptr<weld::RadioButton>
+sd/source/ui/animations/CustomAnimationDialog.cxx:1743
+    sd::CustomAnimationEffectTabPage mxContainer std::unique_ptr<weld::Container>
+sd/source/ui/animations/CustomAnimationDialog.cxx:1749
+    sd::CustomAnimationEffectTabPage mxFTSound std::unique_ptr<weld::Label>
+sd/source/ui/animations/CustomAnimationDialog.cxx:1752
+    sd::CustomAnimationEffectTabPage mxFTAfterEffect std::unique_ptr<weld::Label>
+sd/source/ui/animations/CustomAnimationDialog.cxx:2273
+    sd::CustomAnimationDurationTabPage mxContainer std::unique_ptr<weld::Container>
+sd/source/ui/animations/CustomAnimationDialog.cxx:2274
+    sd::CustomAnimationDurationTabPage mxFTStart std::unique_ptr<weld::Label>
+sd/source/ui/animations/CustomAnimationDialog.cxx:2276
+    sd::CustomAnimationDurationTabPage mxFTStartDelay std::unique_ptr<weld::Label>
+sd/source/ui/animations/CustomAnimationDialog.cxx:2639
+    sd::CustomAnimationTextAnimTabPage mxContainer std::unique_ptr<weld::Container>
+sd/source/ui/animations/CustomAnimationDialog.cxx:2640
+    sd::CustomAnimationTextAnimTabPage mxFTGroupText std::unique_ptr<weld::Label>
+sd/source/ui/animations/CustomAnimationDialog.hxx:150
+    sd::SdPropertySubControl mxContainer std::unique_ptr<weld::Container>
 sd/source/ui/dlg/PhotoAlbumDialog.hxx:60
     sd::SdPhotoAlbumDialog m_xImg std::unique_ptr<weld::CustomWeld>
 sd/source/ui/inc/custsdlg.hxx:43
@@ -231,25 +245,25 @@ sd/source/ui/inc/custsdlg.hxx:75
 sd/source/ui/inc/custsdlg.hxx:76
     SdDefineCustomShowDlg m_xBtnHelp std::unique_ptr<weld::Button>
 sd/source/ui/remotecontrol/ZeroconfService.hxx:36
-    sd::ZeroconfService port uint
+    sd::ZeroconfService port const uint
 sd/source/ui/slidesorter/view/SlsLayouter.cxx:61
     sd::slidesorter::view::Layouter::Implementation mpTheme std::shared_ptr<view::Theme>
 sd/source/ui/table/TableDesignPane.hxx:104
-    sd::TableDesignPane aImpl class sd::TableDesignWidget
+    sd::TableDesignPane aImpl const class sd::TableDesignWidget
 sd/source/ui/view/DocumentRenderer.cxx:1319
-    sd::DocumentRenderer::Implementation mxObjectShell SfxObjectShellRef
+    sd::DocumentRenderer::Implementation mxObjectShell const SfxObjectShellRef
 sd/source/ui/view/viewshel.cxx:1211
-    sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock sd::slidesorter::view::class SlideSorterView::DrawLock
+    sd::KeepSlideSorterInSyncWithPageChanges m_aDrawLock const sd::slidesorter::view::class SlideSorterView::DrawLock
 sd/source/ui/view/viewshel.cxx:1212
-    sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock sd::slidesorter::controller::class SlideSorterController::ModelChangeLock
+    sd::KeepSlideSorterInSyncWithPageChanges m_aModelLock const sd::slidesorter::controller::class SlideSorterController::ModelChangeLock
 sd/source/ui/view/viewshel.cxx:1213
-    sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock
+    sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock const sd::slidesorter::controller::class PageSelector::UpdateLock
 sd/source/ui/view/viewshel.cxx:1214
-    sd::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::class SelectionObserver::Context
+    sd::KeepSlideSorterInSyncWithPageChanges m_aContext const sd::slidesorter::controller::class SelectionObserver::Context
 sd/source/ui/view/ViewShellBase.cxx:193
     sd::ViewShellBase::Implementation mpPageCacheManager std::shared_ptr<slidesorter::cache::PageCacheManager>
 sfx2/source/doc/doctempl.cxx:116
-    DocTempl::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock
+    DocTempl::DocTempl_EntryData_Impl mxObjShell const class SfxObjectShellLock
 sfx2/source/inc/sfxpicklist.hxx:33
     SfxPickList mxImpl std::unique_ptr<SfxPickListImpl>
 sfx2/source/view/viewfrm.cxx:163
@@ -287,7 +301,7 @@ svl/source/crypto/cryptosign.cxx:282
 svtools/source/filter/exportdialog.hxx:124
     ExportDialog mxEncoding std::unique_ptr<weld::Widget>
 svtools/source/svhtml/htmlkywd.cxx:558
-    HTML_OptionEntry  union HTML_OptionEntry::(anonymous at /media/noel/disk2/libo5/svtools/source/svhtml/htmlkywd.cxx:558:5)
+    HTML_OptionEntry  union HTML_OptionEntry::(anonymous at /media/noel/disk2/libo6/svtools/source/svhtml/htmlkywd.cxx:558:5)
 svtools/source/svhtml/htmlkywd.cxx:560
     HTML_OptionEntry::(anonymous) sToken const sal_Char *
 svtools/source/svhtml/htmlkywd.cxx:561
@@ -346,7 +360,7 @@ vcl/inc/opengl/zone.hxx:46
     OpenGLVCLContextZone aZone const class OpenGLZone
 vcl/inc/salprn.hxx:44
     SalPrinterQueueInfo mpPortName std::unique_ptr<OUString>
-vcl/source/app/salvtables.cxx:606
+vcl/source/app/salvtables.cxx:617
     SalInstanceContainer m_xContainer VclPtr<vcl::Window>
 vcl/source/gdi/jobset.cxx:35
     ImplOldJobSetupData cDeviceName char [32]
@@ -358,7 +372,7 @@ vcl/unx/generic/print/prtsetup.hxx:73
     RTSPaperPage m_xContainer std::unique_ptr<weld::Widget>
 vcl/unx/generic/print/prtsetup.hxx:108
     RTSDevicePage m_xContainer std::unique_ptr<weld::Widget>
-vcl/unx/gtk3/gtk3gtkinst.cxx:2346
+vcl/unx/gtk3/gtk3gtkinst.cxx:2398
     CrippledViewport viewport GtkViewport
 vcl/unx/gtk/a11y/atkhypertext.cxx:29
     (anonymous) atk_hyper_link const AtkHyperlink
diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results
index e682582ab27d..1b988be5ec71 100644
--- a/compilerplugins/clang/unusedfields.writeonly.results
+++ b/compilerplugins/clang/unusedfields.writeonly.results
@@ -300,7 +300,7 @@ sc/inc/compiler.hxx:257
     ScCompiler::AddInMap pEnglish const char *
 sc/inc/compiler.hxx:259
     ScCompiler::AddInMap pUpper const char *
-sc/inc/document.hxx:2523
+sc/inc/document.hxx:2528
     ScMutationDisable mpDocument class ScDocument *
 sc/inc/pivot.hxx:75
     ScDPLabelData mnFlags sal_Int32
@@ -379,7 +379,7 @@ sd/source/filter/ppt/ppt97animations.hxx:51
 sd/source/ui/remotecontrol/Receiver.hxx:36
     sd::Receiver pTransmitter class sd::Transmitter *
 sd/source/ui/sidebar/MasterPageContainerProviders.hxx:136
-    sd::sidebar::TemplatePreviewProvider msURL class rtl::OUString
+    sd::sidebar::TemplatePreviewProvider msURL const class rtl::OUString
 sd/source/ui/sidebar/SlideBackground.hxx:100
     sd::sidebar::SlideBackground m_pContainer VclPtr<class VclVBox>
 sfx2/source/view/classificationcontroller.cxx:59
@@ -465,7 +465,7 @@ sw/source/filter/inc/rtf.hxx:29
 sw/source/filter/inc/rtf.hxx:30
     RTFSurround::(anonymous union)::(anonymous) nJunk sal_uInt8
 sw/source/filter/inc/rtf.hxx:31
-    RTFSurround::(anonymous) Flags struct (anonymous struct at /media/noel/disk2/libo5/sw/source/filter/inc/rtf.hxx:27:9)
+    RTFSurround::(anonymous) Flags struct (anonymous struct at /media/noel/disk2/libo6/sw/source/filter/inc/rtf.hxx:27:9)
 ucb/source/ucp/gio/gio_mount.hxx:46
     OOoMountOperationClass parent_class GMountOperationClass
 ucb/source/ucp/gio/gio_mount.hxx:49
commit bb234655bfdd60c64a0511918f835c3cfbde789a
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Sun Oct 14 12:26:08 2018 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Mon Oct 15 12:53:17 2018 +0200

    loplugin:unusedmethods
    
    Change-Id: I0226d33cbe224519cf2ed9ea5143ffe68fdbc884
    Reviewed-on: https://gerrit.libreoffice.org/61775
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results
index ffd44427b781..1c04ba086b90 100644
--- a/compilerplugins/clang/unusedmethods.results
+++ b/compilerplugins/clang/unusedmethods.results
@@ -8,18 +8,6 @@ basic/source/inc/buffer.hxx:46
     void SbiBuffer::operator+=(int)
 canvas/source/vcl/impltools.hxx:105
      vclcanvas::tools::LocalGuard::LocalGuard()
-chart2/source/controller/inc/res_LegendPosition.hxx:78
-     chart::SchLegendPositionResources::SchLegendPositionResources(class weld::Builder &)
-chart2/source/controller/inc/res_LegendPosition.hxx:87
-    void chart::SchLegendPositionResources::initFromItemSet(const class SfxItemSet &)
-chart2/source/controller/inc/res_LegendPosition.hxx:88
-    void chart::SchLegendPositionResources::writeToItemSet(class SfxItemSet &) const
-chart2/source/controller/inc/res_LegendPosition.hxx:90
-    void chart::SchLegendPositionResources::SetChangeHdl(const class Link<class LinkParamNone *, void> &)
-chart2/source/controller/inc/res_Titles.hxx:73
-    _Bool chart::SchTitleResources::IsModified()
-chart2/source/controller/inc/res_Titles.hxx:74
-    void chart::SchTitleResources::ClearModifyFlag()
 connectivity/source/drivers/evoab2/NResultSetMetaData.hxx:51
     class com::sun::star::uno::Reference<class com::sun::star::sdbc::XResultSetMetaData> connectivity::evoab::OEvoabResultSetMetaData::operator Reference()
 connectivity/source/drivers/firebird/Driver.hxx:65
@@ -58,12 +46,6 @@ connectivity/source/inc/OTypeInfo.hxx:46
     _Bool connectivity::OTypeInfo::operator==(const struct connectivity::OTypeInfo &) const
 connectivity/source/inc/OTypeInfo.hxx:47
     _Bool connectivity::OTypeInfo::operator!=(const struct connectivity::OTypeInfo &) const
-cui/source/options/personasdochandler.hxx:24
-     PersonasDocHandler::PersonasDocHandler()
-cui/source/options/personasdochandler.hxx:25
-    const class std::__debug::vector<class rtl::OUString, class std::allocator<class rtl::OUString> > & PersonasDocHandler::getLearnmoreURLs()
-cui/source/options/personasdochandler.hxx:26
-    _Bool PersonasDocHandler::hasResults()
 dbaccess/source/filter/hsqldb/fbalterparser.hxx:20
     void dbahsql::FbAlterStmtParser::ensureProperTableLengths() const
 dbaccess/source/filter/hsqldb/parseschema.hxx:82
@@ -118,6 +100,8 @@ editeng/inc/edtspell.hxx:112
     class __gnu_debug::_Safe_iterator<class __gnu_cxx::__normal_iterator<const struct editeng::MisspellRange *, class std::__cxx1998::vector<struct editeng::MisspellRange, class std::allocator<struct editeng::MisspellRange> > >, class std::__debug::vector<struct editeng::MisspellRange, class std::allocator<struct editeng::MisspellRange> > > WrongList::begin() const
 editeng/inc/edtspell.hxx:113
     class __gnu_debug::_Safe_iterator<class __gnu_cxx::__normal_iterator<const struct editeng::MisspellRange *, class std::__cxx1998::vector<struct editeng::MisspellRange, class std::allocator<struct editeng::MisspellRange> > >, class std::__debug::vector<struct editeng::MisspellRange, class std::allocator<struct editeng::MisspellRange> > > WrongList::end() const
+editeng/source/editeng/editstt2.hxx:62
+    _Bool InternalEditStatus::IsAnyOutliner() const
 extensions/source/scanner/scanner.hxx:81
     void ScannerManager::SetData(void *)
 framework/source/uiconfiguration/ImageList.hxx:51
@@ -442,7 +426,7 @@ include/formula/opcode.hxx:518
     class std::__cxx11::basic_string<char, struct std::char_traits<char>, class std::allocator<char> > OpCodeEnumToString(enum OpCode)
 include/formula/tokenarray.hxx:180
     class formula::FormulaTokenArrayReferencesIterator formula::FormulaTokenArrayReferencesIterator::operator++(int)
-include/formula/tokenarray.hxx:566
+include/formula/tokenarray.hxx:571
     basic_ostream<type-parameter-?-?, type-parameter-?-?> & formula::operator<<(basic_ostream<type-parameter-?-?, type-parameter-?-?> &,const class formula::FormulaTokenArray &)
 include/i18nlangtag/languagetag.hxx:261
     enum LanguageTag::ScriptType LanguageTag::getScriptType() const
@@ -565,8 +549,6 @@ include/opencl/openclconfig.hxx:55
 include/opencl/OpenCLZone.hxx:42
     _Bool OpenCLZone::isInInitialTest()
 include/sfx2/basedlgs.hxx:218
-    class SfxTabPage * SfxSingleTabDialogController::GetTabPage() const
-include/sfx2/basedlgs.hxx:219
     class weld::Button & SfxSingleTabDialogController::GetOKButton() const
 include/sfx2/charwin.hxx:63
     void SvxCharView::connect_focus_in(const class Link<class weld::Widget &, void> &)
@@ -580,10 +562,6 @@ include/sfx2/msg.hxx:120
     const class std::type_info * SfxType0::Type() const
 include/sfx2/sidebar/Context.hxx:55
     _Bool sfx2::sidebar::Context::operator==(const class sfx2::sidebar::Context &) const
-include/sfx2/tabdlg.hxx:211
-    const class PushButton * SfxTabDialog::GetUserButton() const
-include/sfx2/tabdlg.hxx:212
-    class PushButton * SfxTabDialog::GetUserButton()
 include/svl/itempool.hxx:167
     const type-parameter-?-? * SfxItemPool::GetItem2Default(TypedWhichId<type-parameter-?-?>) const
 include/svl/itempool.hxx:196
@@ -612,12 +590,14 @@ include/svx/framelink.hxx:201
     _Bool svx::frame::operator>(const class svx::frame::Style &,const class svx::frame::Style &)
 include/svx/framelink.hxx:238
     _Bool svx::frame::StyleVectorCombination::operator<(const class svx::frame::StyleVectorCombination &) const
-include/svx/numfmtsh.hxx:169
-    short SvxNumberFormatShell::GetListPos4Entry(const class rtl::OUString &)
+include/svx/langbox.hxx:165
+    void LanguageBox::AddLanguages(const class std::__debug::vector<struct o3tl::strong_int<unsigned short, struct LanguageTypeTag>, class std::allocator<struct o3tl::strong_int<unsigned short, struct LanguageTypeTag> > > &,enum SvxLanguageListFlags)
 include/svx/svdlayer.hxx:76
     _Bool SdrLayer::operator==(const class SdrLayer &) const
 include/svx/svdpntv.hxx:462
     _Bool SdrPaintView::IsSwapAsynchron() const
+include/svx/svdundo.hxx:100
+    void SdrUndoGroup::Clear()
 include/svx/xpoly.hxx:82
     _Bool XPolygon::operator==(const class XPolygon &) const
 include/tools/bigint.hxx:86
@@ -776,67 +756,75 @@ include/vcl/weld.hxx:72
     class rtl::OString weld::Widget::get_buildable_name() const
 include/vcl/weld.hxx:77
     int weld::Widget::get_grid_left_attach() const
-include/vcl/weld.hxx:82
-    _Bool weld::Widget::get_hexpand() const
 include/vcl/weld.hxx:83
-    void weld::Widget::set_vexpand(_Bool)
+    _Bool weld::Widget::get_hexpand() const
 include/vcl/weld.hxx:84
+    void weld::Widget::set_vexpand(_Bool)
+include/vcl/weld.hxx:85
     _Bool weld::Widget::get_vexpand() const
-include/vcl/weld.hxx:94
+include/vcl/weld.hxx:95
     void weld::Widget::set_tooltip_text(const class rtl::OUString &)
-include/vcl/weld.hxx:146
-    void weld::ScrolledWindow::vadjustment_set_upper(int)
 include/vcl/weld.hxx:147
-    void weld::ScrolledWindow::set_hpolicy(enum VclPolicyType)
+    void weld::ScrolledWindow::vadjustment_set_upper(int)
 include/vcl/weld.hxx:148
+    void weld::ScrolledWindow::set_hpolicy(enum VclPolicyType)
+include/vcl/weld.hxx:149
     enum VclPolicyType weld::ScrolledWindow::get_hpolicy() const
-include/vcl/weld.hxx:177
+include/vcl/weld.hxx:178
     class rtl::OUString weld::Notebook::get_tab_label_text(const class rtl::OString &) const
-include/vcl/weld.hxx:203
+include/vcl/weld.hxx:204
     struct SystemEnvData weld::Window::get_system_data() const
-include/vcl/weld.hxx:349
+include/vcl/weld.hxx:380
     void weld::TreeView::append(const class rtl::OUString &,const class rtl::OUString &,class VirtualDevice &)
-include/vcl/weld.hxx:362
-    void weld::TreeView::set_top_entry(int)
 include/vcl/weld.hxx:393
+    void weld::TreeView::set_top_entry(int)
+include/vcl/weld.hxx:424
     void weld::TreeView::select_all()
-include/vcl/weld.hxx:529
+include/vcl/weld.hxx:515
+    void weld::MenuButton::append_item(const class rtl::OUString &,const class rtl::OUString &)
+include/vcl/weld.hxx:523
+    void weld::MenuButton::append_item(const class rtl::OUString &,const class rtl::OUString &,const class rtl::OUString &)
+include/vcl/weld.hxx:527
+    void weld::MenuButton::append_item(const class rtl::OUString &,const class rtl::OUString &,class VirtualDevice &)
+include/vcl/weld.hxx:580
     void weld::Entry::signal_insert_text(class rtl::OUString &)
-include/vcl/weld.hxx:541
+include/vcl/weld.hxx:592
     int weld::Entry::get_position() const
-include/vcl/weld.hxx:601
+include/vcl/weld.hxx:652
     int weld::SpinButton::get_min() const
-include/vcl/weld.hxx:866
+include/vcl/weld.hxx:927
     class Size weld::MetricSpinButton::get_size_request() const
-include/vcl/weld.hxx:877
+include/vcl/weld.hxx:938
     void weld::MetricSpinButton::set_position(int)
-include/vcl/weld.hxx:924
+include/vcl/weld.hxx:985
     _Bool weld::TimeSpinButton::get_sensitive() const
-include/vcl/weld.hxx:925
+include/vcl/weld.hxx:986
     _Bool weld::TimeSpinButton::get_visible() const
-include/vcl/weld.hxx:926
+include/vcl/weld.hxx:987
     void weld::TimeSpinButton::grab_focus()
-include/vcl/weld.hxx:927
+include/vcl/weld.hxx:988
     _Bool weld::TimeSpinButton::has_focus() const
-include/vcl/weld.hxx:928
+include/vcl/weld.hxx:989
     void weld::TimeSpinButton::show(_Bool)
-include/vcl/weld.hxx:929
+include/vcl/weld.hxx:990
     void weld::TimeSpinButton::hide()
-include/vcl/weld.hxx:930
+include/vcl/weld.hxx:991
     void weld::TimeSpinButton::save_value()
-include/vcl/weld.hxx:931
+include/vcl/weld.hxx:992
     _Bool weld::TimeSpinButton::get_value_changed_from_saved() const
-include/vcl/weld.hxx:1022
+include/vcl/weld.hxx:1083
     void weld::DrawingArea::connect_key_release(const class Link<const class KeyEvent &, _Bool> &)
-include/vcl/weld.hxx:1049
+include/vcl/weld.hxx:1110
     void weld::Menu::set_active(const class rtl::OString &,_Bool)
-include/vcl/weld.hxx:1059
+include/vcl/weld.hxx:1120
+    void weld::Menu::append_check(const class rtl::OUString &,const class rtl::OUString &)
+include/vcl/weld.hxx:1124
     void weld::Menu::append(const class rtl::OUString &,const class rtl::OUString &,const class rtl::OUString &)
-include/vcl/weld.hxx:1075
+include/vcl/weld.hxx:1140
     void weld::SizeGroup::set_mode(enum VclSizeGroupMode)
-include/vcl/weld.hxx:1097
+include/vcl/weld.hxx:1162
     class std::unique_ptr<class weld::Window, struct std::default_delete<class weld::Window> > weld::Builder::weld_window(const class rtl::OString &,_Bool)
-include/vcl/weld.hxx:1208
+include/vcl/weld.hxx:1273
     class rtl::OUString weld::MessageDialogController::get_primary_text() const
 include/vcl/window.hxx:430
     const char * ImplDbgCheckWindow(const void *)
@@ -862,6 +850,10 @@ sc/inc/bigrange.hxx:73
     _Bool ScBigAddress::operator!=(const class ScBigAddress &) const
 sc/inc/columniterator.hxx:82
     int sc::ColumnIterator::getType() const
+sc/inc/columnspanset.hxx:106
+    void sc::ColumnSpanSet::executeColumnAction(class ScDocument &,class sc::ColumnSpanSet::ColumnAction &,double &) const
+sc/inc/columnspanset.hxx:165
+    void sc::RangeColumnSpanSet::executeAction(class ScDocument &,class sc::ColumnSpanSet::Action &) const
 sc/inc/datamapper.hxx:82
     void sc::ExternalDataSource::setUpdateFrequency(double)
 sc/inc/datamapper.hxx:85
@@ -878,13 +870,11 @@ sc/inc/formulagroup.hxx:142
     void sc::FormulaGroupInterpreter::disableOpenCL_UnitTestsOnly()
 sc/inc/scdll.hxx:36
      ScDLL::ScDLL()
-sc/inc/scmatrix.hxx:415
-    class ScMatrix & ScMatrix::operator+=(const class ScMatrix &)
 sc/inc/stlalgorithm.hxx:61
     _Bool sc::AlignedAllocator::operator==(const AlignedAllocator<T, Alignment> &) const
 sc/inc/stlalgorithm.hxx:62
     _Bool sc::AlignedAllocator::operator!=(const AlignedAllocator<T, Alignment> &) const
-sc/inc/table.hxx:321
+sc/inc/table.hxx:323
     _Bool ScTable::IsColRowTabValid(const short,const int,const short) const
 sc/inc/userlist.hxx:86
     class __gnu_debug::_Safe_iterator<class __gnu_cxx::__normal_iterator<const class std::unique_ptr<class ScUserListData, struct std::default_delete<class ScUserListData> > *, class std::__cxx1998::vector<class std::unique_ptr<class ScUserListData, struct std::default_delete<class ScUserListData> >, class std::allocator<class std::unique_ptr<class ScUserListData, struct std::default_delete<class ScUserListData> > > > >, class std::__debug::vector<class std::unique_ptr<class ScUserListData, struct std::default_delete<class ScUserListData> >, class std::allocator<class std::unique_ptr<class ScUserListData, struct std::default_delete<class ScUserListData> > > > > ScUserList::begin() const
@@ -924,15 +914,15 @@ sc/source/core/opencl/formulagroupcl.cxx:1260
     _Bool sc::opencl::ParallelReductionVectorRef::GetEndFixed() const
 sc/source/core/opencl/op_statistical.hxx:204
      sc::opencl::OpGeoMean::OpGeoMean()
-sc/source/core/tool/scmatrix.cxx:2354
+sc/source/core/tool/scmatrix.cxx:2298
     type-parameter-?-? * wrapped_iterator::operator->() const
-sc/source/core/tool/scmatrix.cxx:3364
+sc/source/core/tool/scmatrix.cxx:3308
     const class svl::SharedString & matop::COp::operator()(char,type-parameter-?-?,double,double,const class svl::SharedString &) const
 sc/source/filter/inc/htmlpars.hxx:60
     void ScHTMLStyles::add(const char *,unsigned long,const char *,unsigned long,const class rtl::OUString &,const class rtl::OUString &)
 sc/source/filter/inc/orcusinterface.hxx:77
      ScOrcusRefResolver::ScOrcusRefResolver(const class ScOrcusGlobalSettings &)
-sc/source/filter/inc/tokstack.hxx:214
+sc/source/filter/inc/tokstack.hxx:213
     _Bool TokenPool::GrowTripel(unsigned short)
 sc/source/filter/inc/xestream.hxx:103
     class XclExpStream & XclExpStream::operator<<(float)
@@ -958,8 +948,6 @@ sc/source/ui/inc/RandomNumberGeneratorDialog.hxx:69
     void ScRandomNumberGeneratorDialog::GenerateNumbers(type-parameter-?-? &,const char *,const class boost::optional<signed char>)
 sc/source/ui/inc/TableFillingAndNavigationTools.hxx:125
     unsigned long DataRangeIterator::size()
-sc/source/ui/inc/validate.hxx:268
-    void ScTPValidationHelp::Init()
 sc/source/ui/inc/viewdata.hxx:406
     long ScViewData::GetLOKDocWidthPixel() const
 sc/source/ui/inc/viewdata.hxx:407
@@ -976,6 +964,8 @@ sd/inc/sddll.hxx:48
      SdDLL::SdDLL()
 sd/source/filter/ppt/pptinanimations.hxx:105
     void ppt::AnimationImporter::dump(const char *,long)
+sd/source/ui/animations/CustomAnimationDialog.hxx:146
+    int sd::SdPropertySubControl::getControlType() const
 sd/source/ui/inc/filedlg.hxx:54
     _Bool SdOpenSoundFileDialog::IsInsertAsLinkSelected()
 sd/source/ui/inc/optsitem.hxx:178
@@ -1304,10 +1294,10 @@ vcl/source/fontsubset/xlat.hxx:34
     unsigned short vcl::TranslateChar15(unsigned short)
 vcl/source/fontsubset/xlat.hxx:35
     unsigned short vcl::TranslateChar16(unsigned short)
-workdir/LexTarget/l10ntools/source/cfglex.cxx:3721
-    void YYWarning(const char *)
 workdir/LexTarget/l10ntools/source/xrmlex.cxx:715
     void YYWarning()
+workdir/LexTarget/l10ntools/source/xrmlex.cxx:2211
+    void YYWarning(const char *)
 writerfilter/source/ooxml/OOXMLPropertySet.hxx:176
     class __gnu_debug::_Safe_iterator<class __gnu_cxx::__normal_iterator<const class tools::SvRef<class writerfilter::ooxml::OOXMLProperty> *, class std::__cxx1998::vector<class tools::SvRef<class writerfilter::ooxml::OOXMLProperty>, class std::allocator<class tools::SvRef<class writerfilter::ooxml::OOXMLProperty> > > >, class std::__debug::vector<class tools::SvRef<class writerfilter::ooxml::OOXMLProperty>, class std::allocator<class tools::SvRef<class writerfilter::ooxml::OOXMLProperty> > > > writerfilter::ooxml::OOXMLPropertySet::begin() const
 writerfilter/source/ooxml/OOXMLPropertySet.hxx:177
diff --git a/compilerplugins/clang/unusedmethods.unused-returns.results b/compilerplugins/clang/unusedmethods.unused-returns.results
index 48b8e80c3ba0..5064b4b70174 100644
--- a/compilerplugins/clang/unusedmethods.unused-returns.results
+++ b/compilerplugins/clang/unusedmethods.unused-returns.results
@@ -56,11 +56,11 @@ include/LibreOfficeKit/LibreOfficeKit.hxx:484
     unsigned char * lok::Document::renderFont(const char *,const char *,int *,int *)
 include/LibreOfficeKit/LibreOfficeKit.hxx:523
     _Bool lok::Document::getViewIds(int *,unsigned long)
-include/LibreOfficeKit/LibreOfficeKit.hxx:643
+include/LibreOfficeKit/LibreOfficeKit.hxx:671
     char * lok::Office::getFilterTypes()
-include/LibreOfficeKit/LibreOfficeKit.hxx:697
+include/LibreOfficeKit/LibreOfficeKit.hxx:725
     char * lok::Office::getVersionInfo()
-include/LibreOfficeKit/LibreOfficeKit.hxx:711
+include/LibreOfficeKit/LibreOfficeKit.hxx:739
     _Bool lok::Office::runMacro(const char *)
 include/oox/crypto/AgileEngine.hxx:121
     _Bool oox::core::AgileEngine::decryptHmacKey()
@@ -196,9 +196,9 @@ include/vcl/texteng.hxx:279
     _Bool TextEngine::Read(class SvStream &,const class TextSelection *)
 include/vcl/toolbox.hxx:514
     _Bool ToolBox::ChangeHighlightUpDn(_Bool)
-include/vcl/weld.hxx:316
+include/vcl/weld.hxx:344
     _Bool weld::ComboBox::get_entry_selection_bounds(int &,int &)
-include/vcl/weld.hxx:956
+include/vcl/weld.hxx:1017
     _Bool weld::TextView::get_selection_bounds(int &,int &)
 lotuswordpro/inc/lwpsvstream.hxx:76
     class LwpSvStream & LwpSvStream::ReadUInt8(unsigned char &)
diff --git a/editeng/source/editeng/editstt2.hxx b/editeng/source/editeng/editstt2.hxx
index fe51f3b6168d..14efc6cf8be6 100644
--- a/editeng/source/editeng/editstt2.hxx
+++ b/editeng/source/editeng/editstt2.hxx
@@ -59,9 +59,6 @@ public:
     bool    IsOutliner2() const
                 { return bool( nControlBits & EEControlBits::OUTLINER2 ); }
 
-    bool    IsAnyOutliner() const
-                { return IsOutliner() || IsOutliner2(); }
-
     bool    DoNotUseColors() const
                 { return bool( nControlBits & EEControlBits::NOCOLORS ); }
 
diff --git a/include/svx/langbox.hxx b/include/svx/langbox.hxx
index 74ecd76673d9..23893feaaeab 100644
--- a/include/svx/langbox.hxx
+++ b/include/svx/langbox.hxx
@@ -162,7 +162,6 @@ public:
     void            SetLanguageList( SvxLanguageListFlags nLangList,
                             bool bHasLangNone, bool bLangNoneIsLangAll = false,
                             bool bCheckSpellAvail = false );
-    void            AddLanguages( const std::vector< LanguageType >& rLanguageTypes, SvxLanguageListFlags nLangList );
     void            InsertLanguage(const LanguageType nLangType);
 
     EditedAndValid      GetEditedAndValid() const { return m_eEditedAndValid;}
diff --git a/include/svx/svdundo.hxx b/include/svx/svdundo.hxx
index 3efb4e75ab90..0b1d6ffee904 100644
--- a/include/svx/svdundo.hxx
+++ b/include/svx/svdundo.hxx
@@ -97,7 +97,6 @@ public:
     SdrUndoGroup(SdrModel& rNewMod);
     virtual ~SdrUndoGroup() override;
 
-    void Clear();
     sal_Int32 GetActionCount() const { return maActions.size(); }
     SdrUndoAction* GetAction(sal_Int32 nNum) const { return maActions[nNum].get(); }
     void AddAction(std::unique_ptr<SdrUndoAction> pAct);
diff --git a/sc/inc/columnspanset.hxx b/sc/inc/columnspanset.hxx
index a62bf6aec9f9..c75502f8bde8 100644
--- a/sc/inc/columnspanset.hxx
+++ b/sc/inc/columnspanset.hxx
@@ -103,7 +103,6 @@ public:
 
     void executeAction(Action& ac) const;
     void executeColumnAction(ScDocument& rDoc, ColumnAction& ac) const;
-    void executeColumnAction(ScDocument& rDoc, ColumnAction& ac, double& fMem) const;
 };
 
 /**
@@ -162,7 +161,6 @@ class RangeColumnSpanSet
 public:
     RangeColumnSpanSet( const ScRange& spanRange )
          : range( spanRange ) {}
-    void executeAction(ScDocument& rDoc, sc::ColumnSpanSet::Action& ac) const;
     void executeColumnAction(ScDocument& rDoc, sc::ColumnSpanSet::ColumnAction& ac) const;
     void executeColumnAction(ScDocument& rDoc, sc::ColumnSpanSet::ColumnAction& ac, double& fMem) const;
 private:
diff --git a/sc/source/core/data/columnspanset.cxx b/sc/source/core/data/columnspanset.cxx
index c784fce1eecc..55b0f3e2ad01 100644
--- a/sc/source/core/data/columnspanset.cxx
+++ b/sc/source/core/data/columnspanset.cxx
@@ -217,49 +217,6 @@ void ColumnSpanSet::executeColumnAction(ScDocument& rDoc, ColumnAction& ac) cons
     }
 }
 
-void ColumnSpanSet::executeColumnAction(ScDocument& rDoc, ColumnAction& ac, double& fMem) const
-{
-    for (size_t nTab = 0; nTab < maTables.size(); ++nTab)
-    {
-        if (!maTables[nTab])
-            continue;
-
-        const TableType& rTab = *maTables[nTab];
-        for (size_t nCol = 0; nCol < rTab.size(); ++nCol)
-        {
-            if (!rTab[nCol])
-                continue;
-
-            ScTable* pTab = rDoc.FetchTable(nTab);
-            if (!pTab)
-                continue;
-
-            if (!ValidCol(nCol))
-            {
-                // End the loop.
-                nCol = rTab.size();
-                continue;
-            }
-
-            ScColumn& rColumn = pTab->aCol[nCol];
-            ac.startColumn(&rColumn);
-            ColumnType& rCol = *rTab[nCol];
-            ColumnSpansType::const_iterator it = rCol.maSpans.begin(), itEnd = rCol.maSpans.end();
-            SCROW nRow1, nRow2;
-            nRow1 = it->first;
-            bool bVal = it->second;
-            for (++it; it != itEnd; ++it)
-            {
-                nRow2 = it->first-1;
-                ac.executeSum( nRow1, nRow2, bVal, fMem );
-
-                nRow1 = nRow2+1; // for the next iteration.
-                bVal = it->second;
-            }
-        }
-    }
-}
-
 namespace {
 
 class Scanner
@@ -379,25 +336,6 @@ bool SingleColumnSpanSet::empty() const
 }
 
 
-void RangeColumnSpanSet::executeAction(ScDocument& rDoc, sc::ColumnSpanSet::Action& ac) const
-{
-    for (SCTAB nTab = range.aStart.Tab(); nTab <= range.aEnd.Tab(); ++nTab)
-    {
-        for (SCCOL nCol = range.aStart.Col(); nCol <= range.aEnd.Col(); ++nCol)
-        {
-            ScTable* pTab = rDoc.FetchTable(nTab);
-            if (!pTab)
-                continue;
-
-            if (!ValidCol(nCol))
-                break;
-
-            ac.startColumn(nTab, nCol);
-            ac.execute(ScAddress(nCol, range.aStart.Row(), nTab), range.aEnd.Row() - range.aStart.Row() + 1, true);
-        }
-    }
-}
-
 void RangeColumnSpanSet::executeColumnAction(ScDocument& rDoc, sc::ColumnSpanSet::ColumnAction& ac) const
 {
     for (SCTAB nTab = range.aStart.Tab(); nTab <= range.aEnd.Tab(); ++nTab)
diff --git a/sd/source/ui/animations/CustomAnimationDialog.hxx b/sd/source/ui/animations/CustomAnimationDialog.hxx
index 47474b28255f..5e7ca996e08c 100644
--- a/sd/source/ui/animations/CustomAnimationDialog.hxx
+++ b/sd/source/ui/animations/CustomAnimationDialog.hxx
@@ -143,8 +143,6 @@ public:
                                 const OUString& rPresetId,
                                 const Link<LinkParamNone*,void>& rModifyHdl );
 
-    sal_Int32 getControlType() const { return mnType; }
-
 protected:
     std::unique_ptr<weld::Builder> mxBuilder;
     std::unique_ptr<weld::Container> mxContainer;
diff --git a/svx/source/svdraw/svdundo.cxx b/svx/source/svdraw/svdundo.cxx
index 3f92e07baa7d..107bd1a0ad05 100644
--- a/svx/source/svdraw/svdundo.cxx
+++ b/svx/source/svdraw/svdundo.cxx
@@ -117,11 +117,6 @@ SdrUndoGroup::~SdrUndoGroup()
 {
 }
 
-void SdrUndoGroup::Clear()
-{
-    maActions.clear();
-}
-
 void SdrUndoGroup::AddAction(std::unique_ptr<SdrUndoAction> pAct)
 {
     maActions.push_back(std::move(pAct));


More information about the Libreoffice-commits mailing list