[Libreoffice-commits] core.git: sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Oct 16 15:14:53 UTC 2018


 sc/source/core/data/column3.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 469902211317ca7d94c500a761f3f7d53a43a35a
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Tue Oct 16 14:53:14 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Tue Oct 16 17:14:11 2018 +0200

    coverity#1440303 use emplace_back instead of push_back
    
    Change-Id: I51457423fdd8d39b5c11d02b450d31fa59127952
    Reviewed-on: https://gerrit.libreoffice.org/61840
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/core/data/column3.cxx b/sc/source/core/data/column3.cxx
index 5cc446357e69..29ee998ebc35 100644
--- a/sc/source/core/data/column3.cxx
+++ b/sc/source/core/data/column3.cxx
@@ -2409,9 +2409,9 @@ public:
     {
         ScFormulaCell* p2 = const_cast<ScFormulaCell*>(p);
         if (p2->IsValue())
-            maEntries.push_back(Entry(nRow, p2->GetValue()));
+            maEntries.emplace_back(nRow, p2->GetValue());
         else
-            maEntries.push_back(Entry(nRow, p2->GetString()));
+            maEntries.emplace_back(nRow, p2->GetString());
     }
 
     void commitCells(ScColumn& rColumn)


More information about the Libreoffice-commits mailing list