[Libreoffice-commits] core.git: sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Oct 19 11:54:10 UTC 2018


 sc/source/ui/cctrl/checklistmenu.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit c324644aa098939d651fb0cf7e8e1a0975350ad0
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Oct 19 10:08:56 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Oct 19 13:52:45 2018 +0200

    index validity check looks dubious
    
    Change-Id: Ib57a26e51a69cc48f82b3474d11fe4f8c8398e07
    Reviewed-on: https://gerrit.libreoffice.org/61977
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/ui/cctrl/checklistmenu.cxx b/sc/source/ui/cctrl/checklistmenu.cxx
index bcccb1af82bb..0b84b18679ef 100644
--- a/sc/source/ui/cctrl/checklistmenu.cxx
+++ b/sc/source/ui/cctrl/checklistmenu.cxx
@@ -822,7 +822,7 @@ void ScMenuFloatingWindow::ensureSubMenuVisible(ScMenuFloatingWindow* pSubMenu)
 
 void ScMenuFloatingWindow::ensureSubMenuNotVisible()
 {
-    if (mnSelectedMenu <= maMenuItems.size() &&
+    if (mnSelectedMenu < maMenuItems.size() &&
         maMenuItems[mnSelectedMenu].mpSubMenuWin &&
         maMenuItems[mnSelectedMenu].mpSubMenuWin->IsVisible())
     {


More information about the Libreoffice-commits mailing list