[Libreoffice-commits] core.git: ios/LibreOfficeLight
Libreoffice Gerrit user
logerrit at kemper.freedesktop.org
Fri Oct 19 12:40:05 UTC 2018
ios/LibreOfficeLight/LibreOfficeLight/LOKit/Document.swift | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
New commits:
commit 9a373521d7a328197a4bf9abeb0a981b7acba896
Author: Tor Lillqvist <tml at collabora.com>
AuthorDate: Fri Oct 19 15:13:19 2018 +0300
Commit: Tor Lillqvist <tml at collabora.com>
CommitDate: Fri Oct 19 15:36:49 2018 +0300
It seems to work even without calling temporaryHackToInvokeCallbackHandlers()?
But I tested just a few times. If somebody re-starts work on
LibreOfficeLight, and encounter hangs, hopefully they notice this
commit and try to un-comment-out the line in question.
I hadn't noticed that temporaryHackToInvokeCallbackHandlers() thing
before, maybe calling it in the iOS app being developed (in the
"online" repo) is necessary, and would help avoiding the hangs I
occasionally see in it?
Change-Id: I0f4d8c800024c43acb512d40efdfad71c229bec2
diff --git a/ios/LibreOfficeLight/LibreOfficeLight/LOKit/Document.swift b/ios/LibreOfficeLight/LibreOfficeLight/LOKit/Document.swift
index 218d203f61be..2a1ad97b3005 100644
--- a/ios/LibreOfficeLight/LibreOfficeLight/LOKit/Document.swift
+++ b/ios/LibreOfficeLight/LibreOfficeLight/LOKit/Document.swift
@@ -539,7 +539,9 @@ open class Document
public func invokeHandlers()
{
- temporaryHackToInvokeCallbackHandlers(pDoc)
+ // The app seems to work even without this? Or maybe I
+ // just didn't test hard enough?
+ // temporaryHackToInvokeCallbackHandlers(pDoc)
}
More information about the Libreoffice-commits
mailing list