[Libreoffice-commits] core.git: xmloff/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Sun Oct 21 13:22:52 UTC 2018


 xmloff/source/text/txtvfldi.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 96762d29bc796bebdd513352aabcad3b216f847d
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Oct 19 16:33:48 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Oct 21 15:22:29 2018 +0200

    pvs-studio: A part of conditional expression is always true: bDisplayOK
    
    Change-Id: If01f2d3b02219194cbeaeffbb0fd8242320432a8
    Reviewed-on: https://gerrit.libreoffice.org/62056
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/xmloff/source/text/txtvfldi.cxx b/xmloff/source/text/txtvfldi.cxx
index 52d61d70276d..9d8b45632c6e 100644
--- a/xmloff/source/text/txtvfldi.cxx
+++ b/xmloff/source/text/txtvfldi.cxx
@@ -205,7 +205,7 @@ void XMLVarFieldImportContext::PrepareField(
 
     if (bSetVisible && bDisplayOK)
     {
-        bool bTmp = ! (bDisplayNone && bDisplayOK);
+        bool bTmp = !bDisplayNone;
         xPropertySet->setPropertyValue(sAPI_is_visible, Any(bTmp));
     }
 


More information about the Libreoffice-commits mailing list