[Libreoffice-commits] core.git: codemaker/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Sun Oct 21 15:09:11 UTC 2018


 codemaker/source/codemaker/global.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 8dc236124ab6f441853d4b23dd0154da9ca0da74
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sat Oct 20 19:24:45 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Oct 21 17:08:48 2018 +0200

    pvs-studio: The condition 'nIndex != - 1' of loop is always true
    
    Change-Id: I5b74d8ac2701adbd63816360812687201f645c39
    Reviewed-on: https://gerrit.libreoffice.org/62097
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/codemaker/source/codemaker/global.cxx b/codemaker/source/codemaker/global.cxx
index e9a9b8f415c1..5b95332c1007 100644
--- a/codemaker/source/codemaker/global.cxx
+++ b/codemaker/source/codemaker/global.cxx
@@ -135,7 +135,7 @@ OString createFileNameFromType( const OString& destination,
         }
 
         buffer.append(token);
-    } while( nIndex != -1 );
+    } while(true);
 
     OUString uSysFileName;
     OSL_VERIFY( FileBase::getSystemPathFromFileURL(


More information about the Libreoffice-commits mailing list