[Libreoffice-commits] core.git: dbaccess/source

[Libreoffice Gerrit user]

 dbaccess/source/filter/hsqldb/hsqlimport.cxx |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit acd9e3f5dac9804286eb498cb9665ba333fc6583
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sat Oct 20 19:55:47 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Oct 21 20:15:17 2018 +0200

    pvs-studio: Expression 'pException' is always false.
    
    Change-Id: Id81e01bd8a082e6bb4eda2f9e8bae1818389941f
    Reviewed-on: https://gerrit.libreoffice.org/62102
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/dbaccess/source/filter/hsqldb/hsqlimport.cxx b/dbaccess/source/filter/hsqldb/hsqlimport.cxx
index 2a098476b62e..7a01045bfb37 100644
--- a/dbaccess/source/filter/hsqldb/hsqlimport.cxx
+++ b/dbaccess/source/filter/hsqldb/hsqlimport.cxx
@@ -305,9 +305,6 @@ void HsqlImporter::importHsqlDatabase()
     }
     catch (SQLException& ex)
     {
-        // chain errors and keep going
-        if (pException)
-            ex.NextException <<= *pException;
         pException.reset(new SQLException{ std::move(ex) });
     }
 
@@ -329,6 +326,7 @@ void HsqlImporter::importHsqlDatabase()
         }
         catch (SQLException& ex)
         {
+            // chain errors and keep going
             if (pException)
                 ex.NextException <<= *pException;
             pException.reset(new SQLException{ std::move(ex) });
@@ -345,6 +343,7 @@ void HsqlImporter::importHsqlDatabase()
         }
         catch (SQLException& ex)
         {
+            // chain errors and keep going
             if (pException)
                 ex.NextException <<= *pException;
             pException.reset(new SQLException{ std::move(ex) });
@@ -361,6 +360,7 @@ void HsqlImporter::importHsqlDatabase()
         }
         catch (SQLException& ex)
         {
+            // chain errors and keep going
             if (pException)
                 ex.NextException <<= *pException;
             pException.reset(new SQLException{ std::move(ex) });