[Libreoffice-commits] core.git: sd/source

[Libreoffice Gerrit user]

 sd/source/filter/ppt/ppt97animations.cxx |    5 -----
 1 file changed, 5 deletions(-)

New commits:
commit e4b165d729926692ae19c85b1596dfdaa74a15b9
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Sun Oct 21 17:27:44 2018 +0200
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sun Oct 21 20:17:14 2018 +0200

    tdf#120703 (PVS): redundant nullptr check
    
    V668 There is no sense in testing the 'pEffect' pointer against null, as
         the memory was allocated using the 'new' operator. The exception will
         be generated in the case of memory allocation error.
    
    Change-Id: I979915efb406d3173e03b4f47883e01fe0ca5d2d
    Reviewed-on: https://gerrit.libreoffice.org/62140
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sd/source/filter/ppt/ppt97animations.cxx b/sd/source/filter/ppt/ppt97animations.cxx
index f5729fcf1269..fe2f9010846e 100644
--- a/sd/source/filter/ppt/ppt97animations.cxx
+++ b/sd/source/filter/ppt/ppt97animations.cxx
@@ -581,11 +581,6 @@ void Ppt97Animation::createAndSetCustomAnimationEffect( SdrObject* pObj )
 
     //1. ------ create an effect from the presets ------
     ::sd::CustomAnimationEffectPtr pEffect( new ::sd::CustomAnimationEffect( pPreset->create( GetPresetSubType() ) ) );
-    if( !pEffect.get() )
-    {
-        DBG_ASSERT(pEffect.get(),"no suitable effect found");
-        return;
-    }
 
     //2. ------ adapt the created effect ------