[Libreoffice-commits] core.git: desktop/source

[Libreoffice Gerrit user]

 desktop/source/app/check_ext_deps.cxx |    9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

New commits:
commit 8959bb300b05be9fafbf30e553b35fb517bdf786
Author:     Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>
AuthorDate: Thu Oct 18 16:44:57 2018 +0200
Commit:     Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>
CommitDate: Mon Oct 22 09:20:59 2018 +0200

    Sync extension registration on startup
    
    There are cases where the extension registration becomes invalid
    (empty rdb files) which leads to extensions not starting up,
    although installed and active.
    Syncing extension repos on startup fixes that.
    
    The performance impact is negligible (1ms in my measurements).
    
    Change-Id: I10475ce6a054b43c4591b17a8486648ca6a30068
    Reviewed-on: https://gerrit.libreoffice.org/61943
    Tested-by: Jenkins
    Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt at cib.de>

diff --git a/desktop/source/app/check_ext_deps.cxx b/desktop/source/app/check_ext_deps.cxx
index 3a59f5cfd854..d241db250a00 100644
--- a/desktop/source/app/check_ext_deps.cxx
+++ b/desktop/source/app/check_ext_deps.cxx
@@ -426,9 +426,12 @@ void Desktop::SynchronizeExtensionRepositories(bool bCleanedExtensionCache, Desk
                 silent->getInteractionHandler());
 #endif
     } else {
-        // reinstallDeployedExtensions above already calls syncRepositories
-        // internally:
-        dp_misc::syncRepositories(false, silent);
+        // reinstallDeployedExtensions above already calls syncRepositories internally
+
+        // Force syncing repositories on startup. There are cases where the extension
+        // registration becomes invalid which leads to extensions not starting up, although
+        // installed and active. Syncing extension repos on startup fixes that.
+        dp_misc::syncRepositories(/*force=*/true, silent);
     }
 }