[Libreoffice-commits] core.git: sd/source

[Libreoffice Gerrit user]

 sd/source/ui/view/sdwindow.cxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 7cd65a3141c09111962dfd52a91d738c3f560f04
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Sun Oct 21 22:40:07 2018 +0200
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Mon Oct 22 09:59:12 2018 +0200

    tdf#120703 (PVS): Recurring check.
    
    V571 The 'mpViewShell' condition was already verified in line 887.
    
    Change-Id: I90e8beee2f66936122824e403ae82aebceb3adc4
    Reviewed-on: https://gerrit.libreoffice.org/62155
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sd/source/ui/view/sdwindow.cxx b/sd/source/ui/view/sdwindow.cxx
index 74fa4fbc2ef0..9519cc7f334a 100644
--- a/sd/source/ui/view/sdwindow.cxx
+++ b/sd/source/ui/view/sdwindow.cxx
@@ -886,8 +886,7 @@ sal_Int8 Window::AcceptDrop( const AcceptDropEvent& rEvt )
 
     if( mpViewShell && !mpViewShell->GetDocSh()->IsReadOnly() )
     {
-        if( mpViewShell )
-            nRet = mpViewShell->AcceptDrop( rEvt, *this, this, SDRPAGE_NOTFOUND, SDRLAYER_NOTFOUND );
+        nRet = mpViewShell->AcceptDrop( rEvt, *this, this, SDRPAGE_NOTFOUND, SDRLAYER_NOTFOUND );
 
         if (mbUseDropScroll && dynamic_cast< OutlineViewShell *>( mpViewShell ) ==  nullptr)
             DropScroll( rEvt.maPosPixel );