[Libreoffice-commits] core.git: compilerplugins/clang

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Mon Oct 22 13:19:52 UTC 2018


 compilerplugins/clang/staticvar.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 3929eab0c0b329d6631cf7fdba7204c3690e9b8a
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Mon Oct 22 15:16:38 2018 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Mon Oct 22 15:16:38 2018 +0200

    Disable loplugin:staticvar for now
    
    produces false positive
    
    > [CXX] svtools/source/svrtf/rtfkeywd.cxx
    > /home/sbergman/lo/core/svtools/source/svrtf/rtfkeywd.cxx:38:23: error: var should be const, or whitelisted [loplugin:staticvar]
    > static RTF_TokenEntry aRTFTokenTab[] = {
    > ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~
    
    Change-Id: I7cd96988218d1192ced2fadff911c7ec89088012

diff --git a/compilerplugins/clang/staticvar.cxx b/compilerplugins/clang/staticvar.cxx
index b9069b5de61f..2383f61bbfd6 100644
--- a/compilerplugins/clang/staticvar.cxx
+++ b/compilerplugins/clang/staticvar.cxx
@@ -204,7 +204,7 @@ bool StaticVar::VisitVarDecl(VarDecl const* varDecl)
     return true;
 }
 
-loplugin::Plugin::Registration<StaticVar> X("staticvar", true);
+loplugin::Plugin::Registration<StaticVar> X("staticvar", false);
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */


More information about the Libreoffice-commits mailing list