[Libreoffice-commits] core.git: compilerplugins/clang

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Oct 23 11:18:50 UTC 2018


 compilerplugins/clang/useuniqueptr.cxx |    7 +++++++
 1 file changed, 7 insertions(+)

New commits:
commit 87e7b4bf4b81b82f43abb7dcafcc733ebca5fb42
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Tue Oct 23 09:28:05 2018 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Tue Oct 23 13:18:28 2018 +0200

    loplugin:useuniqueptr more exclusions
    
    Change-Id: I70c6d4af999965497e23ec8180eb08aa6dc648c5
    Reviewed-on: https://gerrit.libreoffice.org/62221
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/useuniqueptr.cxx b/compilerplugins/clang/useuniqueptr.cxx
index ac55e2878c9b..fb8363974612 100644
--- a/compilerplugins/clang/useuniqueptr.cxx
+++ b/compilerplugins/clang/useuniqueptr.cxx
@@ -119,6 +119,13 @@ public:
         // ZipOutputStream, ownership of ZipEntry is horribly complicated here
         if (fn == SRCDIR "/package/source/zipapi/ZipOutputStream.cxx")
             return;
+        // custom deleter
+        if (fn == SRCDIR "/sal/rtl/locale.cxx")
+            return;
+        // std::vector<ScLookupCacheMap*> is tricky, changing it would require moving lots of class definitions around
+        if (fn == SRCDIR "/sc/source/core/data/documen2.cxx"
+            || fn == SRCDIR "/sc/source/core/tool/interpretercontext.cxx")
+            return;
 
         TraverseDecl(compiler.getASTContext().getTranslationUnitDecl());
     }


More information about the Libreoffice-commits mailing list