[Libreoffice-commits] core.git: sc/source

[Libreoffice Gerrit user]

 sc/source/filter/excel/xeformula.cxx |    6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

New commits:
commit 4df55ffee791b9fcb4b2f5e6c64ad15b34316faf
Author:     Eike Rathke <erack at redhat.com>
AuthorDate: Mon Oct 22 22:07:54 2018 +0200
Commit:     Eike Rathke <erack at redhat.com>
CommitDate: Tue Oct 23 15:04:15 2018 +0200

    Resolves: tdf#120689 omit <definedName> for ocMacro in OOXML
    
    Change-Id: I7578d568d2afe5d3a45b31a8a349cd370b03fc67
    Reviewed-on: https://gerrit.libreoffice.org/62204
    Reviewed-by: Eike Rathke <erack at redhat.com>
    Tested-by: Jenkins

diff --git a/sc/source/filter/excel/xeformula.cxx b/sc/source/filter/excel/xeformula.cxx
index 8a7f69f3dc1b..3d196c8ad535 100644
--- a/sc/source/filter/excel/xeformula.cxx
+++ b/sc/source/filter/excel/xeformula.cxx
@@ -1636,7 +1636,11 @@ void XclExpFmlaCompImpl::AppendDefaultParam( XclExpFuncData& rFuncData )
             AppendEuroToolCallToken( rFuncData.GetExtFuncData() );
         break;
         case ocMacro:
-            AppendMacroCallToken( rFuncData.GetExtFuncData() );
+            // Do not write the OOXML <definedName> element.
+            if (GetOutput() == EXC_OUTPUT_XML_2007)
+                AppendNameToken( 0 );     // dummy to keep parameter count valid
+            else
+                AppendMacroCallToken( rFuncData.GetExtFuncData() );
         break;
         default:
         {