[Libreoffice-commits] core.git: hwpfilter/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Wed Oct 24 20:11:33 UTC 2018


 hwpfilter/source/drawing.h |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

New commits:
commit 9cb5deaaa4eb98da06d9ab46c6bee9f0a479499a
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Wed Oct 24 14:58:29 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Wed Oct 24 22:11:09 2018 +0200

    ofz#11119 Direct-leak
    
    since...
    
    commit 55f0b65b0568b8a8b1d823578eea1cbf633f4134
    Date:   Tue Oct 23 09:27:51 2018 +0200
    
        loplugin:useuniqueptr in LoadDrawingObject
    
    Change-Id: Id5c7929482a1dc00584c4c1a228d993525fc8ed6
    Reviewed-on: https://gerrit.libreoffice.org/62307
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/hwpfilter/source/drawing.h b/hwpfilter/source/drawing.h
index 78c1240cdca1..4a03ce47e18e 100644
--- a/hwpfilter/source/drawing.h
+++ b/hwpfilter/source/drawing.h
@@ -363,13 +363,13 @@ static std::unique_ptr<HWPDrawingObject> LoadDrawingObject(void)
         }
         if (prev == nullptr)
         {
-            prev = hdo.get();
             head = std::move(hdo);
+            prev = head.get();
         }
         else
         {
-            prev = hdo.get();
-            prev->next = std::move( hdo );
+            prev->next = std::move(hdo);
+            prev = prev->next.get();
         }
     }
     while (link_info & HDOFILE_HAS_NEXT);


More information about the Libreoffice-commits mailing list