[Libreoffice-commits] core.git: connectivity/source include/sfx2 include/svtools sfx2/source svtools/source vcl/inc

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu Oct 25 07:20:25 UTC 2018


 connectivity/source/drivers/mork/MQueryHelper.cxx |    7 -------
 connectivity/source/drivers/mork/MQueryHelper.hxx |    1 -
 include/sfx2/sidebar/FocusManager.hxx             |    1 -
 include/sfx2/tabdlg.hxx                           |    3 ---
 include/svtools/dialogcontrolling.hxx             |   11 -----------
 sfx2/source/dialog/tabdlg.cxx                     |    5 -----
 sfx2/source/sidebar/FocusManager.cxx              |   10 ----------
 svtools/source/misc/dialogcontrolling.cxx         |   19 -------------------
 vcl/inc/fontinstance.hxx                          |    1 -
 9 files changed, 58 deletions(-)

New commits:
commit a8520074425cd0b05ea54af4e189caafca634655
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Wed Oct 24 15:51:26 2018 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Thu Oct 25 09:19:59 2018 +0200

    loplugin:unusedmethods
    
    Change-Id: I1f9ac5f8a090f365d9a21486029e1c13d721a4a4
    Reviewed-on: https://gerrit.libreoffice.org/62338
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/connectivity/source/drivers/mork/MQueryHelper.cxx b/connectivity/source/drivers/mork/MQueryHelper.cxx
index 7f0d4ae08d52..6998df5e98fa 100644
--- a/connectivity/source/drivers/mork/MQueryHelper.cxx
+++ b/connectivity/source/drivers/mork/MQueryHelper.cxx
@@ -124,13 +124,6 @@ sal_Int32 MQueryHelper::getResultCount() const
     return result;
 }
 
-
-bool MQueryHelper::checkRowAvailable( sal_Int32 nDBRow )
-{
-    return getResultCount() > nDBRow;
-}
-
-
 bool MQueryHelper::getRowValue( ORowSetValue& rValue, sal_Int32 nDBRow,const OUString& aDBColumnName, sal_Int32 nType )
 {
     MQueryHelperResultEntry* pResEntry = getByIndex( nDBRow );
diff --git a/connectivity/source/drivers/mork/MQueryHelper.hxx b/connectivity/source/drivers/mork/MQueryHelper.hxx
index 0aabc5aed26f..92c27f2135cb 100644
--- a/connectivity/source/drivers/mork/MQueryHelper.hxx
+++ b/connectivity/source/drivers/mork/MQueryHelper.hxx
@@ -168,7 +168,6 @@ namespace connectivity
             void                       reset();
             MQueryHelperResultEntry*   getByIndex( sal_uInt32 nRow );
             sal_Int32                  getResultCount() const;
-            bool                       checkRowAvailable( sal_Int32 nDBRow );
             bool                       getRowValue( ORowSetValue& rValue, sal_Int32 nDBRow,const OUString& aDBColumnName, sal_Int32 nType );
             sal_Int32                  executeQuery(OConnection* xConnection, MQueryExpression & expr);
             const OColumnAlias&        getColumnAlias() const { return m_rColumnAlias; }
diff --git a/include/sfx2/sidebar/FocusManager.hxx b/include/sfx2/sidebar/FocusManager.hxx
index c089419f05c8..a8f66b259788 100644
--- a/include/sfx2/sidebar/FocusManager.hxx
+++ b/include/sfx2/sidebar/FocusManager.hxx
@@ -64,7 +64,6 @@ public:
     */
     void GrabFocus();
     void GrabFocusPanel();
-    void GrabFocusButton(const sal_Int32 nIndex);
 
     void SetDeckTitle(DeckTitleBar* pDeckTitleBar);
     void SetPanels(const SharedPanelContainer& rPanels);
diff --git a/include/sfx2/tabdlg.hxx b/include/sfx2/tabdlg.hxx
index 13d469ff88fc..6a47844dd461 100644
--- a/include/sfx2/tabdlg.hxx
+++ b/include/sfx2/tabdlg.hxx
@@ -140,9 +140,6 @@ public:
                                     CreateTabPage pCreateFunc,      // != 0
                                     sal_uInt16 nPos = TAB_APPEND);
 
-    void                AddTabPage( sal_uInt16 nId,
-                                    const OUString &rRiderText);
-
     void                RemoveTabPage( const OString& rName ); // Name of the label for the page in the notebook .ui
     void                RemoveTabPage( sal_uInt16 nId );
 
diff --git a/include/svtools/dialogcontrolling.hxx b/include/svtools/dialogcontrolling.hxx
index 447ab1349edc..35b7a11171c5 100644
--- a/include/svtools/dialogcontrolling.hxx
+++ b/include/svtools/dialogcontrolling.hxx
@@ -138,10 +138,6 @@ namespace svt
         ControlDependencyManager();
         ~ControlDependencyManager();
 
-        /** clears all dialog controllers previously added to the manager
-        */
-        void    clear();
-
         /** ensures that a given window is enabled or disabled, according to the check state
             of a given radio button
             @param _rRadio
@@ -258,13 +254,6 @@ namespace svt
                 PWindowOperator( new EnableOnCheck< RadioButton >( _rButton ) ) )
         {
         }
-
-        RadioDependentEnabler( CheckBox& _rBox )
-            :DialogController( _rBox,
-                PWindowEventFilter( new FilterForRadioOrCheckToggle( _rBox ) ),
-                PWindowOperator( new EnableOnCheck< CheckBox >( _rBox ) ) )
-        {
-        }
     };
 
 
diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index ae9a9cbfd0da..72fd6089f4d2 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -643,11 +643,6 @@ void SfxTabDialog::Start_Impl()
     ActivatePageHdl( m_pTabCtrl );
 }
 
-void SfxTabDialog::AddTabPage( sal_uInt16 nId, const OUString &rRiderText )
-{
-    AddTabPage( nId, rRiderText, nullptr );
-}
-
 /*
     Adds a page to the dialog. The Name must correspond to a entry in the
     TabControl in the dialog .ui
diff --git a/sfx2/source/sidebar/FocusManager.cxx b/sfx2/source/sidebar/FocusManager.cxx
index 85a9a7741630..a95b4405ffd0 100644
--- a/sfx2/source/sidebar/FocusManager.cxx
+++ b/sfx2/source/sidebar/FocusManager.cxx
@@ -63,16 +63,6 @@ void FocusManager::GrabFocusPanel()
     FocusPanel(0, false);
 }
 
-void FocusManager::GrabFocusButton(const sal_Int32 nIndex)
-{
-    if (static_cast<size_t>(nIndex) >= maButtons.size())
-    {
-        SAL_WARN("sfx.sidebar", "invalid focus index, probably during teardown");
-        return;
-    }
-    FocusButton(nIndex);
-}
-
 void FocusManager::Clear()
 {
     SetDeckTitle(nullptr);
diff --git a/svtools/source/misc/dialogcontrolling.cxx b/svtools/source/misc/dialogcontrolling.cxx
index d23ab9b398ac..fa2b66a19181 100644
--- a/svtools/source/misc/dialogcontrolling.cxx
+++ b/svtools/source/misc/dialogcontrolling.cxx
@@ -138,25 +138,6 @@ namespace svt
     }
 
 
-    namespace
-    {
-        struct ResetDialogController
-        {
-            void operator()( const std::shared_ptr<DialogController>& _pController )
-            {
-                _pController->reset();
-            }
-        };
-    }
-
-
-    void ControlDependencyManager::clear()
-    {
-        ::std::for_each( m_pImpl->aControllers.begin(), m_pImpl->aControllers.end(), ResetDialogController() );
-        m_pImpl->aControllers.clear();
-    }
-
-
     void ControlDependencyManager::addController( const std::shared_ptr<DialogController>& _pController )
     {
         OSL_ENSURE(_pController != nullptr, "ControlDependencyManager::addController: invalid "
diff --git a/vcl/inc/fontinstance.hxx b/vcl/inc/fontinstance.hxx
index b3b67c8a9079..5aacfca4c37a 100644
--- a/vcl/inc/fontinstance.hxx
+++ b/vcl/inc/fontinstance.hxx
@@ -63,7 +63,6 @@ public: // TODO: make data members private
 
     inline hb_font_t* GetHbFont();
     void SetAverageWidthFactor(double nFactor) { m_nAveWidthFactor = nFactor; }
-    void SetNonAntialiased(bool bNonAntialiased);
     double GetAverageWidthFactor() const { return m_nAveWidthFactor; }
     const FontSelectPattern& GetFontSelectPattern() const { return m_aFontSelData; }
 


More information about the Libreoffice-commits mailing list