[Libreoffice-commits] core.git: Branch 'libreoffice-6-1' - io/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Fri Oct 26 20:01:38 UTC 2018


 io/source/stm/odata.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit cae6fbaaea522fca72627bb1627b9b6c59b2e71a
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sat Oct 20 21:34:14 2018 +0100
Commit:     Michael Stahl <Michael.Stahl at cib.de>
CommitDate: Fri Oct 26 22:01:10 2018 +0200

    pvs-studio: V557 Array overrun is possible
    
    Change-Id: Ia4a7c857b3c94490364ed979ba2fcb9e192e3796
    Reviewed-on: https://gerrit.libreoffice.org/62145
    Tested-by: Jenkins
    Reviewed-by: Michael Stahl <Michael.Stahl at cib.de>

diff --git a/io/source/stm/odata.cxx b/io/source/stm/odata.cxx
index aaa4178d3b0f..78d4cde4f90f 100644
--- a/io/source/stm/odata.cxx
+++ b/io/source/stm/odata.cxx
@@ -1149,7 +1149,7 @@ Reference< XPersistObject >  OObjectInputStream::readObject()
             }
         }
         else {
-            if( m_aPersistVector.size() < nId )
+            if (nId >= m_aPersistVector.size())
             {
                 // id unknown, load failure !
                 bLoadSuccessful = false;


More information about the Libreoffice-commits mailing list