[Libreoffice-commits] core.git: ucb/source

[Libreoffice Gerrit user]

 ucb/source/cacher/cachedcontentresultset.cxx |    5 -----
 1 file changed, 5 deletions(-)

New commits:
commit 8d21f814dff7b56e03c5c2526ede53d18584bbaa
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Sat Oct 27 13:18:47 2018 +0200
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Sat Oct 27 15:48:07 2018 +0200

    tdf#120703 PVS: V519 variable is assigned values twice successively
    
    V519 The 'm_nFetchDirectionPropertyHandle' variable is assigned values twice
         successively. Perhaps this is a mistake. Check lines: 489, 493.
    
    It was this way since 2000 (commit d3329bacd8a925ec070ad06ea3d9a6a026a3696b)
    
    Change-Id: Ia6ade4355bbfac799f8b32069f27a0c439300030
    Reviewed-on: https://gerrit.libreoffice.org/62414
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/ucb/source/cacher/cachedcontentresultset.cxx b/ucb/source/cacher/cachedcontentresultset.cxx
index bcdc5a189b27..f719338dce63 100644
--- a/ucb/source/cacher/cachedcontentresultset.cxx
+++ b/ucb/source/cacher/cachedcontentresultset.cxx
@@ -485,11 +485,6 @@ CCRS_PropertySetInfo::CCRS_PropertySetInfo(
         rMyProp.Type = cppu::UnoType<sal_Bool>::get();
         rMyProp.Attributes = PropertyAttribute::BOUND | PropertyAttribute::MAYBEDEFAULT;
 
-        if( nFetchDirection != -1 )
-            m_nFetchDirectionPropertyHandle = (*pOrigProps)[nFetchDirection].Handle;
-        else
-            m_nFetchDirectionPropertyHandle = impl_getRemainedHandle();
-
         m_nFetchDirectionPropertyHandle = rMyProp.Handle;
     }
 }