[Libreoffice-commits] core.git: basic/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Sat Oct 27 16:39:33 UTC 2018


 basic/source/runtime/dllmgr-x86.cxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 51b6a52e1c8c3ef30842cf108d2a12fb222e7607
Author:     Mike Kaganski <mike.kaganski at collabora.com>
AuthorDate: Sat Oct 27 15:55:57 2018 +0200
Commit:     Mike Kaganski <mike.kaganski at collabora.com>
CommitDate: Sat Oct 27 18:39:13 2018 +0200

    tdf#120703 PVS: V724
    
    V724 Converting type 'int' to type 'sal_Bool' can lead to a loss of
         high-order bits. Non-zero value can become 'FALSE'.
    
    Change-Id: I26540aa9fa9390e1990e95d81665567cd0a248b5
    Reviewed-on: https://gerrit.libreoffice.org/62426
    Tested-by: Jenkins
    Reviewed-by: Mike Kaganski <mike.kaganski at collabora.com>

diff --git a/basic/source/runtime/dllmgr-x86.cxx b/basic/source/runtime/dllmgr-x86.cxx
index 7c4720fc246b..fc5b91e3300d 100644
--- a/basic/source/runtime/dllmgr-x86.cxx
+++ b/basic/source/runtime/dllmgr-x86.cxx
@@ -542,8 +542,7 @@ ErrCode call(
         break;
     case SbxBOOL:
         result.PutBool(
-            static_cast< sal_Bool >(
-                DllMgr_call32(proc.proc, address(stack), stack.size())));
+            bool(DllMgr_call32(proc.proc, address(stack), stack.size())));
         break;
     case SbxBYTE:
         result.PutByte(


More information about the Libreoffice-commits mailing list