[Libreoffice-commits] core.git: sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Wed Oct 31 01:18:07 UTC 2018


 sc/source/core/data/postit.cxx |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

New commits:
commit 5066325953943814fa66f6d6a835d848903b742d
Author:     Zdibák Zoltán <zdibakzoltan at gmail.com>
AuthorDate: Tue Oct 30 19:27:57 2018 +0100
Commit:     Markus Mohrhard <markus.mohrhard at googlemail.com>
CommitDate: Wed Oct 31 02:17:39 2018 +0100

    cppCheck RedundantAssignment variable bRecording
    
    Change-Id: I2fb7c2ce3581bf6347a5b6ee85d7e603e2b58800
    Reviewed-on: https://gerrit.libreoffice.org/62643
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>
    Tested-by: Markus Mohrhard <markus.mohrhard at googlemail.com>

diff --git a/sc/source/core/data/postit.cxx b/sc/source/core/data/postit.cxx
index 8e961ce28222..acc77eb882f6 100644
--- a/sc/source/core/data/postit.cxx
+++ b/sc/source/core/data/postit.cxx
@@ -466,11 +466,10 @@ void removeFromDrawPageAndFree( const std::shared_ptr< SdrCaptionObj >& pCaption
     if (pDrawPage)
     {
         pDrawPage->RecalcObjOrdNums();
-        bool bRecording = false;
         ScDrawLayer* pDrawLayer(dynamic_cast< ScDrawLayer* >(&pCaption->getSdrModelFromSdrObject()));
         SAL_WARN_IF( !pDrawLayer, "sc.core", "ScCaptionPtr::removeFromDrawPageAndFree - object without drawing layer");
         // create drawing undo action (before removing the object to have valid draw page in undo action)
-        bRecording = (pDrawLayer && pDrawLayer->IsRecording());
+        bool bRecording = (pDrawLayer && pDrawLayer->IsRecording());
         if (bRecording)
             pDrawLayer->AddCalcUndo( o3tl::make_unique<ScUndoDelSdrCaptionObj>( pCaption ));
         // remove the object from the drawing page, delete if undo is disabled


More information about the Libreoffice-commits mailing list