[Libreoffice-commits] core.git: sd/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Wed Oct 31 01:18:49 UTC 2018


 sd/source/ui/func/fucon3d.cxx |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

New commits:
commit 684dfd88716b65b354f0de2ff5661ca0736e4a29
Author:     Zdibák Zoltán <zdibakzoltan at gmail.com>
AuthorDate: Tue Oct 30 20:28:28 2018 +0100
Commit:     Markus Mohrhard <markus.mohrhard at googlemail.com>
CommitDate: Wed Oct 31 02:18:20 2018 +0100

    cppCheck RedundantAssignment variable p3DObj
    
    Change-Id: Ib423480bdb5d2cee183b5d1bda5b1a9ff05fdafc
    Reviewed-on: https://gerrit.libreoffice.org/62667
    Reviewed-by: Markus Mohrhard <markus.mohrhard at googlemail.com>
    Tested-by: Markus Mohrhard <markus.mohrhard at googlemail.com>

diff --git a/sd/source/ui/func/fucon3d.cxx b/sd/source/ui/func/fucon3d.cxx
index f4f45dc5ca88..eb9cb4f9df8d 100644
--- a/sd/source/ui/func/fucon3d.cxx
+++ b/sd/source/ui/func/fucon3d.cxx
@@ -328,11 +328,9 @@ bool FuConstruct3dObject::MouseButtonDown(const MouseEvent& rMEvt)
         mpWindow->CaptureMouse();
         sal_uInt16 nDrgLog = sal_uInt16 ( mpWindow->PixelToLogic(Size(DRGPIX,0)).Width() );
 
-        E3dCompoundObject* p3DObj = nullptr;
-
         WaitObject aWait( static_cast<vcl::Window*>(mpViewShell->GetActiveWindow()) );
 
-        p3DObj = ImpCreateBasic3DShape();
+        E3dCompoundObject* p3DObj = ImpCreateBasic3DShape();
         E3dScene* pScene = mpView->SetCurrent3DObj(p3DObj);
 
         ImpPrepareBasic3DShape(p3DObj, pScene);


More information about the Libreoffice-commits mailing list