[Libreoffice-commits] core.git: 3 commits - cui/uiconfig extensions/source sd/source

[Libreoffice Gerrit user]

 cui/uiconfig/ui/borderpage.ui                     |    2 ++
 cui/uiconfig/ui/colorpage.ui                      |    1 +
 extensions/source/propctrlr/submissionhandler.cxx |    2 +-
 sd/source/ui/unoidl/unoobj.cxx                    |    6 +++---
 4 files changed, 7 insertions(+), 4 deletions(-)

New commits:
commit 9db52c294f37c9404e846a1c0bd1741f142f5708
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Sat Sep 8 15:08:11 2018 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Sat Sep 8 17:50:41 2018 +0200

    clan-tidy bugprone-throw-keyword-missing in SubmissionPropertyHandler
    
    warning: suspicious exception object created but not thrown; did you
    mean 'throw IllegalArgumentException'?
    
    looks like a mistake in
        commit cd5b956817d0a6585d44f50857d690e9dc58145e
        Date:   Tue Mar 14 10:33:39 2006 +0000
        INTEGRATION: CWS pbrwuno (1.3.88); FILE MERGED
    
    Change-Id: I828501f32b3caff8c4ca05a8a8c4b063dccecd3b
    Reviewed-on: https://gerrit.libreoffice.org/60196
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/extensions/source/propctrlr/submissionhandler.cxx b/extensions/source/propctrlr/submissionhandler.cxx
index 664c9c9725b3..164815bbf554 100644
--- a/extensions/source/propctrlr/submissionhandler.cxx
+++ b/extensions/source/propctrlr/submissionhandler.cxx
@@ -280,7 +280,7 @@ namespace pcr
         if ( !_rxControlFactory.is() )
             throw NullPointerException();
         if ( !m_pHelper.get() )
-            RuntimeException();
+            throw RuntimeException();
 
         std::vector< OUString > aListEntries;
         PropertyId nPropId( impl_getPropertyId_throwUnknownProperty( _rPropertyName ) );
commit 2bbcdc574ee2ca5849d7ab52963e89d810633cac
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Sat Sep 8 15:05:10 2018 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Sat Sep 8 17:50:31 2018 +0200

    clan-tidy bugprone-throw-keyword-missing in SdXShape
    
    warning: suspicious exception object created but not thrown; did you
    mean 'throw IllegalArgumentException'?
    
    looks like a mistake in
        commit 1d8d532b369330a3ee1e1fb65a16c34787b19667
        Date:   Fri Mar 18 16:03:40 2005 +0000
        INTEGRATION: CWS impress36 (1.45.2); FILE MERGED
    
    Change-Id: I338686e59e4c9b7737f6b304249c1081e4e763aa
    Reviewed-on: https://gerrit.libreoffice.org/60195
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/sd/source/ui/unoidl/unoobj.cxx b/sd/source/ui/unoidl/unoobj.cxx
index 092a64862104..b24a6e5fd4df 100644
--- a/sd/source/ui/unoidl/unoobj.cxx
+++ b/sd/source/ui/unoidl/unoobj.cxx
@@ -571,7 +571,7 @@ void SAL_CALL SdXShape::setPropertyValue( const OUString& aPropertyName, const c
                 {
                     bool bDimHide = false;
                     if( !(aValue >>= bDimHide) )
-                        lang::IllegalArgumentException();
+                        throw lang::IllegalArgumentException();
 
                     EffectMigration::SetDimHide( mpShape, bDimHide );
                     break;
@@ -580,7 +580,7 @@ void SAL_CALL SdXShape::setPropertyValue( const OUString& aPropertyName, const c
                 {
                     bool bDimPrevious = false;
                     if( !(aValue >>= bDimPrevious) )
-                        lang::IllegalArgumentException();
+                        throw lang::IllegalArgumentException();
 
                     EffectMigration::SetDimPrevious( mpShape, bDimPrevious );
                     break;
@@ -589,7 +589,7 @@ void SAL_CALL SdXShape::setPropertyValue( const OUString& aPropertyName, const c
                 {
                     sal_Int32 nNewPos = 0;
                     if( !(aValue >>= nNewPos) )
-                        lang::IllegalArgumentException();
+                        throw lang::IllegalArgumentException();
 
                     EffectMigration::SetPresentationOrder( mpShape, nNewPos );
                     break;
commit fd9582a56cbee82c2a790a35c81795469fa9ab48
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Sat Sep 8 14:23:12 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Sat Sep 8 17:50:28 2018 +0200

    set default min point line width
    
    Change-Id: I4d75977b930b669c8845059f893d79fbeb2f1afc
    Reviewed-on: https://gerrit.libreoffice.org/60199
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/cui/uiconfig/ui/borderpage.ui b/cui/uiconfig/ui/borderpage.ui
index 912dbaa65f11..e7e05a5aa9fb 100644
--- a/cui/uiconfig/ui/borderpage.ui
+++ b/cui/uiconfig/ui/borderpage.ui
@@ -5,6 +5,7 @@
   <object class="GtkAdjustment" id="adjustment1">
     <property name="lower">0.050000000000000003</property>
     <property name="upper">9</property>
+    <property name="value">0.050000000000000003</property>
     <property name="step_increment">0.25</property>
     <property name="page_increment">1</property>
   </object>
@@ -278,6 +279,7 @@
                         <property name="activates_default">True</property>
                         <property name="adjustment">adjustment1</property>
                         <property name="digits">2</property>
+                        <property name="value">0.050000000000000003</property>
                       </object>
                       <packing>
                         <property name="left_attach">0</property>
diff --git a/cui/uiconfig/ui/colorpage.ui b/cui/uiconfig/ui/colorpage.ui
index d1941ef2dee3..b801bc787b66 100644
--- a/cui/uiconfig/ui/colorpage.ui
+++ b/cui/uiconfig/ui/colorpage.ui
@@ -926,6 +926,7 @@
                     <property name="valign">start</property>
                     <property name="image">image3</property>
                     <property name="image_position">right</property>
+                    <property name="always_show_image">True</property>
                   </object>
                   <packing>
                     <property name="expand">False</property>