[Libreoffice-commits] core.git: ucb/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Mon Sep 10 15:37:48 UTC 2018


 ucb/source/ucp/webdav-neon/DAVSessionFactory.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit 12637b0f83b3a3d9d740882e0e8e7cc0a442cde2
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Mon Sep 10 11:41:56 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Mon Sep 10 17:37:25 2018 +0200

    suspicious MutexGuard placement
    
    Change-Id: I3b5cf5984a1a852d2482b8a417fc46c836ea2dc2
    Reviewed-on: https://gerrit.libreoffice.org/60258
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/ucb/source/ucp/webdav-neon/DAVSessionFactory.cxx b/ucb/source/ucp/webdav-neon/DAVSessionFactory.cxx
index b49a2cad68f1..ba0df6f79bfe 100644
--- a/ucb/source/ucp/webdav-neon/DAVSessionFactory.cxx
+++ b/ucb/source/ucp/webdav-neon/DAVSessionFactory.cxx
@@ -45,10 +45,10 @@ rtl::Reference< DAVSession > DAVSessionFactory::createDAVSession(
                 const uno::Sequence< beans::NamedValue >& rFlags,
                 const uno::Reference< uno::XComponentContext > & rxContext )
 {
-    m_xContext = rxContext;
-
     osl::MutexGuard aGuard( m_aMutex );
 
+    m_xContext = rxContext;
+
     if ( !m_xProxyDecider.get() )
         m_xProxyDecider.reset( new ucbhelper::InternetProxyDecider( rxContext ) );
 


More information about the Libreoffice-commits mailing list