[Libreoffice-commits] core.git: compilerplugins/clang

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Tue Sep 11 06:18:40 UTC 2018


 compilerplugins/clang/unusedmethods.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit b40e57f403b3d4ccb90f3b76caf8d537b61826dc
Author:     Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Mon Sep 10 16:11:05 2018 +0200
Commit:     Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Tue Sep 11 08:18:16 2018 +0200

    fix loplugin:unusedmethods
    
    revert the part of
        commit 9f4d23c15115d64febd6bf01f870cc157badd350
        Date:   Mon Aug 13 17:24:26 2018 +0200
        filter out some of the AST in the plugins
    that applied to this plugin. Turns out it really needs to see __all__
    the code in order to produce good results.
    
    Change-Id: If580a701049d2570f2a833327b2189641090079b
    Reviewed-on: https://gerrit.libreoffice.org/60279
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    Tested-by: Noel Grandin <noel.grandin at collabora.co.uk>

diff --git a/compilerplugins/clang/unusedmethods.cxx b/compilerplugins/clang/unusedmethods.cxx
index 3837aa6d00ff..a84b7e8d237d 100644
--- a/compilerplugins/clang/unusedmethods.cxx
+++ b/compilerplugins/clang/unusedmethods.cxx
@@ -75,11 +75,11 @@ static std::set<MyFuncInfo> calledFromOutsideSet;
 
 
 class UnusedMethods:
-    public loplugin::FilteringPlugin<UnusedMethods>
+    public RecursiveASTVisitor<UnusedMethods>, public loplugin::Plugin
 {
 public:
     explicit UnusedMethods(loplugin::InstantiationData const & data):
-        FilteringPlugin(data) {}
+        Plugin(data) {}
 
     virtual void run() override
     {


More information about the Libreoffice-commits mailing list