[Libreoffice-commits] core.git: compilerplugins/clang include/svx sfx2/source svx/source
Libreoffice Gerrit user
logerrit at kemper.freedesktop.org
Tue Sep 11 16:18:37 UTC 2018
compilerplugins/clang/unusedfields.only-used-in-constructor.results | 14 ++++++--
compilerplugins/clang/unusedfields.readonly.results | 14 +++-----
compilerplugins/clang/unusedfields.untouched.results | 16 +++++++++-
compilerplugins/clang/unusedfields.writeonly.results | 8 +++++
include/svx/SvxPresetListBox.hxx | 2 -
sfx2/source/dialog/itemconnect.cxx | 10 ------
svx/source/tbxctrls/SvxPresetListBox.cxx | 5 ---
7 files changed, 40 insertions(+), 29 deletions(-)
New commits:
commit 40069adbc225a6dd5d3431a7cd9f17986f6385de
Author: Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Tue Sep 11 14:39:17 2018 +0200
Commit: Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Tue Sep 11 18:18:12 2018 +0200
loplugin:unusedfields
Change-Id: Ic7871f3a40668ba73aa0f0067a45455920d55890
Reviewed-on: https://gerrit.libreoffice.org/60313
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/compilerplugins/clang/unusedfields.only-used-in-constructor.results b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
index b802986376e4..d6fb9aef851a 100644
--- a/compilerplugins/clang/unusedfields.only-used-in-constructor.results
+++ b/compilerplugins/clang/unusedfields.only-used-in-constructor.results
@@ -120,7 +120,7 @@ cppu/source/uno/check.cxx:138
(anonymous namespace)::Char4 chars struct (anonymous namespace)::Char3
cui/source/dialogs/colorpicker.cxx:719
cui::ColorPickerDialog m_aColorPrevious class cui::ColorPreviewControl
-cui/source/factory/dlgfact.cxx:1387
+cui/source/factory/dlgfact.cxx:1396
SvxMacroAssignDialog m_aItems class SfxItemSet
cui/source/inc/cfgutil.hxx:190
SvxScriptSelectorDialog m_aStylesInfo struct SfxStylesInfo_Impl
@@ -366,8 +366,6 @@ sc/source/ui/inc/msgpool.hxx:46
ScMessagePool aCondFormatDlgItem class ScCondFormatDlgItem
sc/source/ui/inc/notemark.hxx:43
ScNoteMarker m_aTimer class Timer
-sc/source/ui/inc/scuiasciiopt.hxx:85
- ScImportAsciiDlg aColumnUser class rtl::OUString
sccomp/source/solver/DifferentialEvolution.hxx:35
DifferentialEvolutionAlgorithm maRandomDevice std::random_device
sccomp/source/solver/ParticelSwarmOptimization.hxx:56
@@ -398,6 +396,8 @@ sd/source/ui/view/viewshel.cxx:1218
sd::KeepSlideSorterInSyncWithPageChanges m_aUpdateLock sd::slidesorter::controller::class PageSelector::UpdateLock
sd/source/ui/view/viewshel.cxx:1219
sd::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::class SelectionObserver::Context
+sfx2/source/dialog/itemconnect.cxx:139
+ sfx::MultiControlWrapperHelper_Impl maVec sfx::ControlWrpVec
sfx2/source/doc/doctempl.cxx:115
DocTempl::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock
slideshow/source/engine/animationnodes/animationbasenode.hxx:89
@@ -556,6 +556,12 @@ vcl/inc/opengl/RenderList.hxx:30
Vertex lineData glm::vec4
vcl/inc/opengl/zone.hxx:46
OpenGLVCLContextZone aZone class OpenGLZone
+vcl/inc/qt5/Qt5Graphics.hxx:61
+ Qt5Graphics m_lastPopupRect class QRect
+vcl/inc/qt5/Qt5Object.hxx:34
+ Qt5Object m_aSystemData struct SystemEnvData
+vcl/inc/qt5/Qt5Object.hxx:36
+ Qt5Object m_pParent class Qt5Frame *
vcl/inc/salmenu.hxx:42
SalMenuButtonItem mnId sal_uInt16
vcl/inc/salmenu.hxx:43
@@ -594,6 +600,8 @@ vcl/unx/gtk/gloactiongroup.cxx:30
GLOAction parent_instance GObject
vcl/unx/gtk/glomenu.cxx:20
GLOMenu parent_instance GMenuModel
+vcl/unx/kde5/KDE5FilePicker.hxx:81
+ KDE5FilePicker allowRemoteUrls _Bool
writerfilter/source/dmapper/PropertyMap.hxx:197
writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32
xmloff/source/text/XMLTextListBlockContext.hxx:35
diff --git a/compilerplugins/clang/unusedfields.readonly.results b/compilerplugins/clang/unusedfields.readonly.results
index 63f634f60965..704f95cd3d96 100644
--- a/compilerplugins/clang/unusedfields.readonly.results
+++ b/compilerplugins/clang/unusedfields.readonly.results
@@ -172,8 +172,6 @@ dbaccess/source/core/api/RowSetBase.hxx:96
dbaccess::ORowSetBase m_aErrors ::connectivity::SQLError
dbaccess/source/core/dataaccess/documentcontainer.cxx:64
dbaccess::LocalNameApproval m_aErrors ::connectivity::SQLError
-dbaccess/source/core/dataaccess/intercept.hxx:107
- dbaccess::OInterceptor m_pDisposeEventListeners std::unique_ptr<comphelper::OInterfaceContainerHelper2>
dbaccess/source/core/inc/ContentHelper.hxx:108
dbaccess::OContentHelper m_aErrorHelper const ::connectivity::SQLError
dbaccess/source/filter/hsqldb/parseschema.hxx:36
@@ -334,6 +332,10 @@ include/svx/svdoedge.hxx:160
SdrEdgeObj mbBoundRectCalculationRunning _Bool
include/svx/svdpntv.hxx:170
SdrPaintView maDrawinglayerOpt class SvtOptionsDrawinglayer
+include/svx/SvxPresetListBox.hxx:35
+ SvxPresetListBox maRenameHdl Link<class SvxPresetListBox *, void>
+include/svx/SvxPresetListBox.hxx:36
+ SvxPresetListBox maDeleteHdl Link<class SvxPresetListBox *, void>
include/test/sheet/xdatapilottable.hxx:31
apitest::XDataPilotTable xCellForChange css::uno::Reference<css::table::XCell>
include/test/sheet/xdatapilottable.hxx:32
@@ -506,8 +508,6 @@ sdext/source/pdfimport/tree/style.hxx:42
pdfi::StyleContainer::Style Contents class rtl::OUString
sfx2/source/appl/lnkbase2.cxx:95
sfx2::ImplDdeItem pLink class sfx2::SvBaseLink *
-sfx2/source/doc/docfile.cxx:270
- SfxMedium_Impl pOrigFilter std::shared_ptr<const SfxFilter>
slideshow/source/engine/slideshowimpl.cxx:153
(anonymous namespace)::FrameSynchronization maTimer canvas::tools::ElapsedTime
sot/source/sdstor/ucbstorage.cxx:407
@@ -582,9 +582,9 @@ sw/inc/swevent.hxx:71
SwCallMouseEvent::(anonymous union)::(anonymous) pFormat const class SwFrameFormat *
sw/source/core/access/accfrmobjmap.hxx:100
SwAccessibleChildMap maMap std::map<key_type, mapped_type, key_compare>
-sw/source/core/doc/swstylemanager.cxx:59
+sw/source/core/doc/swstylemanager.cxx:58
SwStyleManager aAutoCharPool class StylePool
-sw/source/core/doc/swstylemanager.cxx:60
+sw/source/core/doc/swstylemanager.cxx:59
SwStyleManager aAutoParaPool class StylePool
sw/source/core/doc/tblrwcl.cxx:83
CpyTabFrame::(anonymous) nSize SwTwips
@@ -678,8 +678,6 @@ vcl/inc/svdata.hxx:284
ImplSVNWFData mbNoActiveTabTextRaise _Bool
vcl/inc/svdata.hxx:286
ImplSVNWFData mbProgressNeedsErase _Bool
-vcl/inc/svdata.hxx:295
- ImplSVNWFData mbRolloverMenubar _Bool
vcl/inc/unx/i18n_status.hxx:56
vcl::I18NStatus m_aCurrentIM class rtl::OUString
vcl/inc/unx/saldisp.hxx:288
diff --git a/compilerplugins/clang/unusedfields.untouched.results b/compilerplugins/clang/unusedfields.untouched.results
index ecb8e9c30536..1533679669d6 100644
--- a/compilerplugins/clang/unusedfields.untouched.results
+++ b/compilerplugins/clang/unusedfields.untouched.results
@@ -110,7 +110,7 @@ include/sfx2/msg.hxx:117
SfxType0 createSfxPoolItemFunc std::function<SfxPoolItem *(void)>
include/sfx2/msg.hxx:119
SfxType0 nAttribs sal_uInt16
-include/svtools/ctrlbox.hxx:364
+include/svtools/ctrlbox.hxx:355
SvtLineListBox m_xLineSetWin std::unique_ptr<weld::CustomWeld>
include/svtools/genericunodialog.hxx:218
svt::UnoDialogEntryGuard m_aGuard ::osl::MutexGuard
@@ -230,6 +230,8 @@ sd/source/ui/view/viewshel.cxx:1219
sd::KeepSlideSorterInSyncWithPageChanges m_aContext sd::slidesorter::controller::class SelectionObserver::Context
sd/source/ui/view/ViewShellBase.cxx:193
sd::ViewShellBase::Implementation mpPageCacheManager std::shared_ptr<slidesorter::cache::PageCacheManager>
+sfx2/source/dialog/itemconnect.cxx:139
+ sfx::MultiControlWrapperHelper_Impl maVec sfx::ControlWrpVec
sfx2/source/doc/doctempl.cxx:115
DocTempl::DocTempl_EntryData_Impl mxObjShell class SfxObjectShellLock
sfx2/source/inc/sfxpicklist.hxx:33
@@ -318,6 +320,16 @@ uui/source/unknownauthdlg.hxx:36
UnknownAuthDialog m_xOptionButtonDontAccept std::unique_ptr<weld::RadioButton>
vcl/inc/opengl/zone.hxx:46
OpenGLVCLContextZone aZone class OpenGLZone
+vcl/inc/qt5/Qt5Data.hxx:35
+ Qt5Data m_pGlyphCache std::unique_ptr<GlyphCache>
+vcl/inc/qt5/Qt5Graphics.hxx:59
+ Qt5Graphics m_focusedButton std::unique_ptr<QPushButton>
+vcl/inc/qt5/Qt5Graphics.hxx:60
+ Qt5Graphics m_image std::unique_ptr<QImage>
+vcl/inc/qt5/Qt5Graphics.hxx:61
+ Qt5Graphics m_lastPopupRect class QRect
+vcl/inc/qt5/Qt5Object.hxx:34
+ Qt5Object m_aSystemData struct SystemEnvData
vcl/inc/salprn.hxx:44
SalPrinterQueueInfo mpPortName std::unique_ptr<OUString>
vcl/source/app/salvtables.cxx:520
@@ -336,6 +348,8 @@ vcl/unx/gtk3/gtk3gtkinst.cxx:2248
CrippledViewport viewport GtkViewport
vcl/unx/gtk/a11y/atkhypertext.cxx:29
(anonymous) atk_hyper_link AtkHyperlink
+vcl/unx/kde5/KDE5FilePicker.hxx:81
+ KDE5FilePicker allowRemoteUrls _Bool
writerfilter/source/ooxml/OOXMLStreamImpl.hxx:43
writerfilter::ooxml::OOXMLStreamImpl mxFastParser css::uno::Reference<css::xml::sax::XFastParser>
writerperfect/inc/WPFTEncodingDialog.hxx:37
diff --git a/compilerplugins/clang/unusedfields.writeonly.results b/compilerplugins/clang/unusedfields.writeonly.results
index ea9276f77067..7cf1b46b8308 100644
--- a/compilerplugins/clang/unusedfields.writeonly.results
+++ b/compilerplugins/clang/unusedfields.writeonly.results
@@ -484,6 +484,10 @@ vcl/inc/opengl/RenderList.hxx:29
Vertex color glm::vec4
vcl/inc/opengl/RenderList.hxx:30
Vertex lineData glm::vec4
+vcl/inc/qt5/Qt5Frame.hxx:65
+ Qt5Frame m_pSalMenu class Qt5Menu *
+vcl/inc/qt5/Qt5Graphics.hxx:56
+ Qt5Graphics m_pFontCollection class PhysicalFontCollection *
vcl/inc/salmenu.hxx:34
SalItemParams nBits enum MenuItemBits
vcl/inc/salmenu.hxx:42
@@ -538,5 +542,9 @@ vcl/unx/gtk/hudawareness.cxx:20
(anonymous) connection GDBusConnection *
vcl/unx/gtk/hudawareness.cxx:23
(anonymous) notify GDestroyNotify
+vcl/unx/kde4/KDEXLib.hxx:49
+ KDEXLib::SocketData pending YieldFunc
+vcl/unx/kde4/KDEXLib.hxx:50
+ KDEXLib::SocketData queued YieldFunc
writerfilter/source/dmapper/PropertyMap.hxx:197
writerfilter::dmapper::SectionPropertyMap m_nDebugSectionNumber sal_Int32
diff --git a/include/svx/SvxPresetListBox.hxx b/include/svx/SvxPresetListBox.hxx
index 2256c8062578..599caf48d00c 100644
--- a/include/svx/SvxPresetListBox.hxx
+++ b/include/svx/SvxPresetListBox.hxx
@@ -32,8 +32,6 @@ class SVX_DLLPUBLIC SvxPresetListBox : public ValueSet
private:
sal_uInt32 nColCount;
Size aIconSize;
- Link<SvxPresetListBox*,void> maRenameHdl;
- Link<SvxPresetListBox*,void> maDeleteHdl;
DECL_LINK( OnMenuItemSelected, Menu*, bool );
diff --git a/sfx2/source/dialog/itemconnect.cxx b/sfx2/source/dialog/itemconnect.cxx
index d4686c709e2a..e814a70368c2 100644
--- a/sfx2/source/dialog/itemconnect.cxx
+++ b/sfx2/source/dialog/itemconnect.cxx
@@ -129,16 +129,6 @@ void CheckBoxWrapper::SetControlValue( bool bValue )
}
-// Multi control wrappers
-
-
-typedef std::vector< ControlWrapperBase* > ControlWrpVec;
-
-struct MultiControlWrapperHelper_Impl
-{
- ControlWrpVec maVec;
-};
-
// Base connection classes
diff --git a/svx/source/tbxctrls/SvxPresetListBox.cxx b/svx/source/tbxctrls/SvxPresetListBox.cxx
index 8de709df91e1..2dbac4a4d5bd 100644
--- a/svx/source/tbxctrls/SvxPresetListBox.cxx
+++ b/svx/source/tbxctrls/SvxPresetListBox.cxx
@@ -102,11 +102,6 @@ IMPL_LINK(SvxPresetListBox, OnMenuItemSelected, Menu*, pMenu, bool)
return false;
}
pMenu->Deactivate();
- OString sIdent = pMenu->GetCurItemIdent();
- if (sIdent == "rename")
- maRenameHdl.Call(this);
- else if (sIdent == "delete")
- maDeleteHdl.Call(this);
return false;
}
More information about the Libreoffice-commits
mailing list