[Libreoffice-commits] core.git: compilerplugins/clang cui/source include/svtools include/svx svtools/source svx/source
Libreoffice Gerrit user
logerrit at kemper.freedesktop.org
Wed Sep 12 11:23:49 UTC 2018
compilerplugins/clang/unusedmethods.results | 90 +------------
compilerplugins/clang/unusedmethods.unused-returns.results | 4
cui/source/inc/numpages.hxx | 2
include/svtools/ctrlbox.hxx | 2
include/svx/SvxPresetListBox.hxx | 3
svtools/source/control/ctrlbox.cxx | 17 --
svx/source/tbxctrls/SvxPresetListBox.cxx | 12 -
7 files changed, 12 insertions(+), 118 deletions(-)
New commits:
commit 569f7a4adefdfce9be82499d8449e808bfad06c6
Author: Noel Grandin <noel.grandin at collabora.co.uk>
AuthorDate: Tue Sep 11 14:45:46 2018 +0200
Commit: Noel Grandin <noel.grandin at collabora.co.uk>
CommitDate: Wed Sep 12 13:23:27 2018 +0200
loplugin:unusedmethods
Change-Id: I0f96c41ab61bd4bfaf6c36d78d0a2ca768da0032
Reviewed-on: https://gerrit.libreoffice.org/60314
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
diff --git a/compilerplugins/clang/unusedmethods.results b/compilerplugins/clang/unusedmethods.results
index 3b2c28c205ad..1eda237006bc 100644
--- a/compilerplugins/clang/unusedmethods.results
+++ b/compilerplugins/clang/unusedmethods.results
@@ -24,16 +24,6 @@ connectivity/source/drivers/firebird/Util.hxx:66
const class rtl::OUString & connectivity::firebird::ColumnTypeInfo::getCharacterSet() const
connectivity/source/drivers/mork/mork_helper.cxx:37
int main(int,char **)
-connectivity/source/drivers/mysqlc/mysqlc_driver.hxx:92
- void connectivity::mysqlc::MysqlCDriver::impl_initCppConn_lck_throw()
-connectivity/source/drivers/mysqlc/mysqlc_general.hxx:95
- class rtl::OString escapeSql(const class rtl::OString &)
-connectivity/source/drivers/mysqlc/mysqlc_general.hxx:97
- class rtl::OUString getStringFromAny(const class com::sun::star::uno::Any &)
-connectivity/source/drivers/mysqlc/mysqlc_general.hxx:120
- class std::__cxx11::basic_string<char, struct std::char_traits<char>, class std::allocator<char> > convert(const class rtl::OUString &,const unsigned short)
-connectivity/source/drivers/mysqlc/mysqlc_resultsetmetadata.hxx:62
- class rtl::OUString connectivity::mysqlc::OResultSetMetaData::convert(const class std::__cxx11::basic_string<char, struct std::char_traits<char>, class std::allocator<char> > &) const
connectivity/source/inc/dbase/dindexnode.hxx:70
_Bool connectivity::dbase::ONDXKey::operator<(const class connectivity::dbase::ONDXKey &) const
connectivity/source/inc/java/sql/Connection.hxx:63
@@ -56,6 +46,8 @@ connectivity/source/inc/OTypeInfo.hxx:46
_Bool connectivity::OTypeInfo::operator==(const struct connectivity::OTypeInfo &) const
connectivity/source/inc/OTypeInfo.hxx:47
_Bool connectivity::OTypeInfo::operator!=(const struct connectivity::OTypeInfo &) const
+cui/source/inc/numpages.hxx:62
+ void SvxNumberingPreview::SetPositionMode()
dbaccess/source/filter/hsqldb/fbalterparser.hxx:20
void dbahsql::FbAlterStmtParser::ensureProperTableLengths() const
dbaccess/source/filter/hsqldb/parseschema.hxx:82
@@ -554,28 +546,8 @@ include/sfx2/charwin.hxx:63
void SvxCharView::connect_focus_in(const class Link<class weld::Widget &, void> &)
include/sfx2/charwin.hxx:64
void SvxCharView::connect_focus_out(const class Link<class weld::Widget &, void> &)
-include/sfx2/controlwrapper.hxx:262
- _Bool sfx::MetricFieldWrapper::IsControlValueChanged() const
-include/sfx2/controlwrapper.hxx:351
- sfx::MultiControlWrapperHelper::MultiControlWrapperHelper()
-include/sfx2/controlwrapper.hxx:355
- void sfx::MultiControlWrapperHelper::RegisterControlWrapper(class sfx::ControlWrapperBase &)
-include/sfx2/controlwrapper.hxx:388
- sfx::MultiControlWrapper::MultiControlWrapper<ValueT>()
-include/sfx2/controlwrapper.hxx:391
- const type-parameter-?-? & sfx::MultiControlWrapper::GetDefaultValue() const
-include/sfx2/controlwrapper.hxx:393
- void sfx::MultiControlWrapper::SetDefaultValue(const type-parameter-?-? &)
-include/sfx2/controlwrapper.hxx:396
- type-parameter-?-? sfx::MultiControlWrapper::GetControlValue() const
-include/sfx2/controlwrapper.hxx:398
- void sfx::MultiControlWrapper::SetControlValue(type-parameter-?-?)
-include/sfx2/dialoghelper.hxx:30
- void setPreviewsToSamePlace(const class vcl::Window *,class VclBuilderContainer *)
include/sfx2/docfilt.hxx:83
_Bool SfxFilter::GetGpgEncryption() const
-include/sfx2/itemwrapper.hxx:153
- sfx::IdentItemWrapper::IdentItemWrapper<ItemT>(unsigned short)
include/sfx2/lokcharthelper.hxx:41
void LokChartHelper::Invalidate()
include/sfx2/msg.hxx:120
@@ -588,16 +560,10 @@ include/svl/itempool.hxx:196
void SfxItemPool::dumpAsXml(struct _xmlTextWriter *) const
include/svtools/ctrlbox.hxx:208
long LineListBox::GetWidth() const
-include/svtools/ctrlbox.hxx:223
- void LineListBox::SelectEntry(enum SvxBorderLineStyle,_Bool)
-include/svtools/ctrlbox.hxx:228
- void LineListBox::SetColor(const class Color &)
+include/svtools/ctrlbox.hxx:220
+ int LineListBox::GetEntryPos(enum SvxBorderLineStyle) const
include/svtools/dialogcontrolling.hxx:167
void svt::ControlDependencyManager::enableOnCheckMark(class CheckBox &,class vcl::Window &,class vcl::Window &)
-include/svtools/valueset.hxx:315
- void ValueSet::InsertItem(unsigned short,const class rtl::OUString &,unsigned long)
-include/svtools/valueset.hxx:347
- unsigned long ValueSet::GetSelectItemPos() const
include/svx/ClassificationEditView.hxx:42
void svx::ClassificationEditView::SetCharAttributes()
include/svx/ClassificationEditView.hxx:48
@@ -606,38 +572,18 @@ include/svx/ClassificationField.hxx:48
const class rtl::OUString & svx::ClassificationResult::getDisplayText() const
include/svx/ClassificationField.hxx:53
_Bool svx::ClassificationResult::operator==(const class svx::ClassificationResult &) const
-include/svx/colorbox.hxx:150
- SvxColorListBoxWrapper::SvxColorListBoxWrapper(class SvxColorListBox &)
-include/svx/dlgctrl.hxx:275
- class SvxTabPage * SvxPixelCtl::GetTabPage() const
include/svx/framelink.hxx:201
_Bool operator>(const class svx::frame::Style &,const class svx::frame::Style &)
include/svx/framelink.hxx:238
_Bool svx::frame::StyleVectorCombination::operator<(const class svx::frame::StyleVectorCombination &) const
-include/svx/frmsel.hxx:107
- int svx::FrameSelector::GetEnabledBorderIndex(enum svx::FrameBorderType) const
-include/svx/frmsel.hxx:181
- _Bool svx::FrameSelector::ContainsClickPoint(const class Point &) const
include/svx/svdlayer.hxx:75
_Bool SdrLayer::operator==(const class SdrLayer &) const
-include/svx/svdlayer.hxx:129
- class SdrLayerAdmin * SdrLayerAdmin::GetParent() const
include/svx/svdpage.hxx:105
class SdrModel & SdrObjList::getSdrModelFromSdrObjList() const
include/svx/svdpntv.hxx:462
_Bool SdrPaintView::IsSwapAsynchron() const
-include/svx/SvxPresetListBox.hxx:51
- void SvxPresetListBox::SetRenameHdl(const class Link<class SvxPresetListBox *, void> &)
-include/svx/SvxPresetListBox.hxx:55
- void SvxPresetListBox::SetDeleteHdl(const class Link<class SvxPresetListBox *, void> &)
-include/svx/SvxPresetListBox.hxx:60
- void SvxPresetListBox::FillPresetListBox(class XGradientList &,unsigned int)
-include/svx/SvxPresetListBox.hxx:61
- void SvxPresetListBox::FillPresetListBox(class XHatchList &,unsigned int)
-include/svx/SvxPresetListBox.hxx:62
- void SvxPresetListBox::FillPresetListBox(class XBitmapList &,unsigned int)
-include/svx/SvxPresetListBox.hxx:63
- void SvxPresetListBox::FillPresetListBox(class XPatternList &,unsigned int)
+include/svx/SvxPresetListBox.hxx:41
+ void SvxPresetListBox::FillPresetListBoxImpl(type-parameter-?-? &,unsigned int)
include/svx/xpoly.hxx:82
_Bool XPolygon::operator==(const class XPolygon &) const
include/tools/bigint.hxx:86
@@ -712,9 +658,9 @@ include/vcl/commandevent.hxx:289
CommandLongPressData::CommandLongPressData()
include/vcl/cursor.hxx:96
_Bool vcl::Cursor::operator!=(const class vcl::Cursor &) const
-include/vcl/customweld.hxx:70
+include/vcl/customweld.hxx:71
void weld::CustomWidgetController::SetAccessibleName(const class rtl::OUString &)
-include/vcl/customweld.hxx:111
+include/vcl/customweld.hxx:112
void weld::CustomWeld::queue_draw_area(int,int,int,int)
include/vcl/edit.hxx:206
_Bool Edit::IsSelectAllSingleClick() const
@@ -764,8 +710,6 @@ include/vcl/settings.hxx:654
_Bool HelpSettings::operator!=(const class HelpSettings &) const
include/vcl/settings.hxx:708
_Bool AllSettings::operator!=(const class AllSettings &) const
-include/vcl/spinfld.hxx:55
- const class Link<class SpinField &, void> & SpinField::GetDownHdl() const
include/vcl/svapp.hxx:178
ApplicationEvent::ApplicationEvent(enum ApplicationEvent::Type,const class std::__debug::vector<class rtl::OUString, class std::allocator<class rtl::OUString> > &)
include/vcl/svapp.hxx:812
@@ -850,9 +794,7 @@ include/vcl/weld.hxx:1078
class rtl::OUString weld::MessageDialogController::get_primary_text() const
include/vcl/window.hxx:430
const char * ImplDbgCheckWindow(const void *)
-include/vcl/window.hxx:1200
- void vcl::Window::InvertTracking(const class tools::Polygon &,enum ShowTrackFlags)
-include/vcl/window.hxx:1240
+include/vcl/window.hxx:1239
class Size vcl::Window::PaintActiveFloatingWindow(class VirtualDevice &) const
libreofficekit/qa/gtktiledviewer/gtv-signal-handlers.hxx:35
void openLokDialog(struct _GtkWidget *,void *)
@@ -988,8 +930,6 @@ sd/source/ui/inc/optsitem.hxx:178
_Bool SdOptionsContents::operator==(const class SdOptionsContents &) const
sd/source/ui/inc/unomodel.hxx:136
_Bool SdXImpressDocument::operator==(const class SdXImpressDocument &) const
-sdext/source/minimizer/pppoptimizer.hxx:40
- PPPOptimizer::PPPOptimizer(const class com::sun::star::uno::Reference<class com::sun::star::uno::XComponentContext> &,const class com::sun::star::uno::Reference<class com::sun::star::frame::XFrame> &)
sfx2/source/appl/shutdownicon.hxx:82
class rtl::OUString ShutdownIcon::getShortcutName()
sfx2/source/appl/shutdownicon.hxx:98
@@ -1046,8 +986,6 @@ svgio/inc/svgstyleattributes.hxx:370
enum svgio::svgreader::FontStretch svgio::svgreader::SvgStyleAttributes::getFontStretch() const
svx/inc/sdr/contact/viewcontactofgraphic.hxx:56
class SdrGrafObj & sdr::contact::ViewContactOfGraphic::GetGrafObject()
-svx/source/inc/svxpixelctlaccessiblecontext.hxx:146
- void SvxPixelCtlAccessible::LoseFocus()
svx/source/svdraw/svdpdf.hxx:92
double ImpSdrPdfImport::Matrix::b() const
svx/source/svdraw/svdpdf.hxx:94
@@ -1208,12 +1146,6 @@ sw/source/core/text/txtpaint.hxx:73
DbgRect::DbgRect(class OutputDevice *,const class tools::Rectangle &,const _Bool,class Color)
sw/source/filter/ww8/ww8struc.hxx:243
WW8_BRCVer6::WW8_BRCVer6()
-sw/source/uibase/inc/prcntfld.hxx:57
- void PercentField::SetAccessibleName(const class rtl::OUString &)
-sw/source/uibase/inc/prcntfld.hxx:58
- void PercentField::SetText(const class rtl::OUString &)
-sw/source/uibase/inc/prcntfld.hxx:59
- void PercentField::SetMetricFieldMin(long)
sw/source/uibase/inc/swcont.hxx:86
_Bool SwContent::operator==(const class SwContent &) const
test/source/sheet/xsubtotalfield.cxx:28
@@ -1284,9 +1216,7 @@ vcl/inc/qt5/Qt5Painter.hxx:56
void Qt5Painter::update()
vcl/inc/regionband.hxx:27
const char * ImplDbgTestRegionBand(const void *)
-vcl/inc/salgdi.hxx:220
- class basegfx::B2DPolygon SalGraphics::mirror(const class basegfx::B2DPolygon &,const class OutputDevice *) const
-vcl/inc/salgdi.hxx:223
+vcl/inc/salgdi.hxx:222
class basegfx::B2DHomMatrix SalGraphics::mirror(const class basegfx::B2DHomMatrix &,const class OutputDevice *) const
vcl/inc/salmenu.hxx:46
SalMenuButtonItem::SalMenuButtonItem()
diff --git a/compilerplugins/clang/unusedmethods.unused-returns.results b/compilerplugins/clang/unusedmethods.unused-returns.results
index 9f43b7e9421d..cd74a8ba1912 100644
--- a/compilerplugins/clang/unusedmethods.unused-returns.results
+++ b/compilerplugins/clang/unusedmethods.unused-returns.results
@@ -294,7 +294,7 @@ sw/source/uibase/inc/mailmergewizard.hxx:79
_Bool SwMailMergeWizard::skipUntil(unsigned short)
ucb/source/ucp/webdav-neon/ContentProperties.hxx:169
_Bool webdav_ucp::CachableContentProperties::containsAllNames(const class com::sun::star::uno::Sequence<struct com::sun::star::beans::Property> &,class std::__debug::vector<class rtl::OUString, class std::allocator<class rtl::OUString> > &) const
-ucb/source/ucp/webdav-neon/NeonSession.hxx:232
+ucb/source/ucp/webdav-neon/NeonSession.hxx:239
_Bool webdav_ucp::NeonSession::UNLOCK(struct ne_lock *)
vcl/inc/font/FeatureCollector.hxx:48
_Bool vcl::font::FeatureCollector::collect()
@@ -310,7 +310,7 @@ vcl/inc/salframe.hxx:222
_Bool SalFrame::SetPluginParent(struct SystemParentData *)
vcl/inc/salgdi.hxx:219
class basegfx::B2DPoint SalGraphics::mirror(const class basegfx::B2DPoint &,const class OutputDevice *) const
-vcl/inc/salgdi.hxx:402
+vcl/inc/salgdi.hxx:401
_Bool SalGraphics::BlendBitmap(const struct SalTwoRect &,const class SalBitmap &,const class OutputDevice *)
vcl/inc/unx/gtk/gtkdata.hxx:164
int GtkSalDisplay::CaptureMouse(class SalFrame *)
diff --git a/cui/source/inc/numpages.hxx b/cui/source/inc/numpages.hxx
index e3f24ca4aa34..d4d3ffb7e8aa 100644
--- a/cui/source/inc/numpages.hxx
+++ b/cui/source/inc/numpages.hxx
@@ -59,8 +59,6 @@ class SvxNumberingPreview : public vcl::Window
void SetNumRule(const SvxNumRule* pNum)
{pActNum = pNum; Invalidate();};
- void SetPositionMode()
- { bPosition = true;}
void SetLevel(sal_uInt16 nSet) {nActLevel = nSet;}
};
diff --git a/include/svtools/ctrlbox.hxx b/include/svtools/ctrlbox.hxx
index f3ce987ef6aa..65c2f5d62a6a 100644
--- a/include/svtools/ctrlbox.hxx
+++ b/include/svtools/ctrlbox.hxx
@@ -216,8 +216,6 @@ public:
ColorFunc pColor2Fn = &sameColor,
ColorDistFunc pColorDistFn = &sameDistColor);
- using ListBox::GetEntryPos;
- sal_Int32 GetEntryPos( SvxBorderLineStyle nStyle ) const;
SvxBorderLineStyle GetEntryStyle( sal_Int32 nPos ) const;
SvxBorderLineStyle GetSelectEntryStyle() const;
diff --git a/include/svx/SvxPresetListBox.hxx b/include/svx/SvxPresetListBox.hxx
index 599caf48d00c..8002d04a04f6 100644
--- a/include/svx/SvxPresetListBox.hxx
+++ b/include/svx/SvxPresetListBox.hxx
@@ -35,9 +35,6 @@ private:
DECL_LINK( OnMenuItemSelected, Menu*, bool );
- template< typename ListType, typename EntryType >
- void FillPresetListBoxImpl(ListType& pList, sal_uInt32 nStartIndex);
-
public:
SvxPresetListBox(vcl::Window* pParent, WinBits nWinStyle);
diff --git a/svtools/source/control/ctrlbox.cxx b/svtools/source/control/ctrlbox.cxx
index 1a10694313bb..20da4fc8d25e 100644
--- a/svtools/source/control/ctrlbox.cxx
+++ b/svtools/source/control/ctrlbox.cxx
@@ -536,23 +536,6 @@ void LineListBox::InsertEntry(
rWidthImpl, nStyle, nMinWidth, pColor1Fn, pColor2Fn, pColorDistFn));
}
-sal_Int32 LineListBox::GetEntryPos( SvxBorderLineStyle nStyle ) const
-{
- if(nStyle == SvxBorderLineStyle::NONE && !m_sNone.isEmpty())
- return 0;
- for ( size_t i = 0, n = m_vLineList.size(); i < n; ++i ) {
- auto& pData = m_vLineList[ i ];
- if ( pData->GetStyle() == nStyle )
- {
- size_t nPos = i;
- if (!m_sNone.isEmpty())
- nPos ++;
- return static_cast<sal_Int32>(nPos);
- }
- }
- return LISTBOX_ENTRY_NOTFOUND;
-}
-
SvxBorderLineStyle LineListBox::GetEntryStyle( sal_Int32 nPos ) const
{
ImpLineListData* pData = (0 <= nPos && static_cast<size_t>(nPos) < m_vLineList.size()) ? m_vLineList[ nPos ].get() : nullptr;
diff --git a/svx/source/tbxctrls/SvxPresetListBox.cxx b/svx/source/tbxctrls/SvxPresetListBox.cxx
index 2dbac4a4d5bd..c66f031e7dc4 100644
--- a/svx/source/tbxctrls/SvxPresetListBox.cxx
+++ b/svx/source/tbxctrls/SvxPresetListBox.cxx
@@ -81,18 +81,6 @@ void SvxPresetListBox::DrawLayout()
SetColCount(getColumnCount());
SetLineCount(5);
}
-template< typename ListType, typename EntryType >
-void SvxPresetListBox::FillPresetListBoxImpl(ListType & pList, sal_uInt32 nStartIndex)
-{
- const Size aSize( GetIconSize() );
- BitmapEx aBitmap;
- for(long nIndex = 0; nIndex < pList.Count(); nIndex++, nStartIndex++)
- {
- aBitmap = pList.GetBitmapForPreview(nIndex, aSize);
- EntryType* pItem = static_cast<EntryType*>( pList.Get(nIndex) );
- InsertItem(nStartIndex, Image(aBitmap), pItem->GetName());
- }
-}
IMPL_LINK(SvxPresetListBox, OnMenuItemSelected, Menu*, pMenu, bool)
{
More information about the Libreoffice-commits
mailing list