[Libreoffice-commits] core.git: animations/source basctl/source basegfx/source basegfx/test basic/source bridges/source canvas/source chart2/qa chart2/source codemaker/source comphelper/source compilerplugins/clang connectivity/source cppuhelper/source cppu/qa cppu/source cpputools/source cui/source dbaccess/qa dbaccess/source desktop/source desktop/unx drawinglayer/source editeng/source embeddedobj/source emfio/source eventattacher/source extensions/source filter/source forms/source formula/source fpicker/source framework/source helpcompiler/source hwpfilter/source i18nutil/source idlc/source idl/source io/source javaunohelper/source jvmfwk/plugins jvmfwk/source l10ntools/source libreofficekit/qa lingucomponent/source linguistic/source lotuswordpro/source odk/source oox/source opencl/source package/source pyuno/source remotebridges/source reportdesign/source sal/osl sal/qa sal/rtl sax/source scaddins/source sc/qa scripting/source sc/source sdext/source sd/qa sd/source sfx2/source slideshow/sourc e smoketest/libtest.cxx solenv/bin sot/source starmath/source stoc/source svgio/source svl/qa svl/source svtools/source svx/source sw/qa sw/source test/source testtools/source toolkit/source tools/source ucbhelper/source ucb/source unodevtools/source unoidl/source unotest/source unotools/source unoxml/source vbahelper/source vcl/backendtest vcl/headless vcl/qa vcl/qt5 vcl/source vcl/unx vcl/workben writerfilter/source writerperfect/source xmlhelp/source xmloff/source xmlscript/source xmlsecurity/source
Libreoffice Gerrit user
logerrit at kemper.freedesktop.org
Mon Sep 17 07:06:34 UTC 2018
animations/source/animcore/animcore.cxx | 44 -
basctl/source/basicide/baside3.cxx | 2
basctl/source/basicide/bastypes.cxx | 2
basctl/source/basicide/localizationmgr.cxx | 6
basctl/source/dlged/dlged.cxx | 4
basctl/source/dlged/dlgedview.cxx | 2
basegfx/source/polygon/b2dpolygonclipper.cxx | 2
basegfx/source/polygon/b2dpolygontools.cxx | 2
basegfx/source/polygon/b3dpolypolygontools.cxx | 2
basegfx/source/tools/gradienttools.cxx | 6
basegfx/source/tools/stringconversiontools.cxx | 4
basegfx/test/boxclipper.cxx | 2
basic/source/basmgr/basmgr.cxx | 6
basic/source/classes/image.cxx | 6
basic/source/classes/sbunoobj.cxx | 58 -
basic/source/classes/sbxmod.cxx | 8
basic/source/comp/parser.cxx | 2
basic/source/runtime/methods.cxx | 12
basic/source/runtime/methods1.cxx | 14
basic/source/runtime/runtime.cxx | 6
basic/source/sbx/sbxform.cxx | 2
basic/source/sbx/sbxscan.cxx | 2
basic/source/uno/dlgcont.cxx | 2
basic/source/uno/scriptcont.cxx | 2
bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx | 2
bridges/source/jni_uno/jni_bridge.cxx | 4
bridges/source/jni_uno/jni_data.cxx | 2
canvas/source/cairo/cairo_canvashelper_text.cxx | 2
canvas/source/tools/spriteredrawmanager.cxx | 4
chart2/qa/extras/chart2import.cxx | 4
chart2/source/controller/dialogs/res_Trendline.cxx | 2
chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx | 8
chart2/source/controller/main/ChartController_Position.cxx | 2
chart2/source/controller/main/ChartController_Window.cxx | 2
chart2/source/controller/main/DrawCommandDispatch.cxx | 2
chart2/source/controller/main/ElementSelector.cxx | 2
chart2/source/tools/DiagramHelper.cxx | 4
chart2/source/tools/ExplicitCategoriesProvider.cxx | 10
chart2/source/view/axes/ScaleAutomatism.cxx | 2
chart2/source/view/axes/VAxisProperties.cxx | 10
chart2/source/view/axes/VCartesianAxis.cxx | 24
chart2/source/view/axes/VCartesianGrid.cxx | 4
chart2/source/view/charttypes/AreaChart.cxx | 2
chart2/source/view/charttypes/BarChart.cxx | 2
chart2/source/view/charttypes/VSeriesPlotter.cxx | 2
chart2/source/view/diagram/VDiagram.cxx | 4
chart2/source/view/main/ChartView.cxx | 2
chart2/source/view/main/LabelPositionHelper.cxx | 2
chart2/source/view/main/ShapeFactory.cxx | 14
chart2/source/view/main/VDataSeries.cxx | 4
codemaker/source/codemaker/global.cxx | 2
comphelper/source/misc/base64.cxx | 2
comphelper/source/misc/mimeconfighelper.cxx | 2
comphelper/source/misc/syntaxhighlight.cxx | 5
comphelper/source/processfactory/processfactory.cxx | 2
comphelper/source/streaming/seekableinput.cxx | 2
compilerplugins/clang/external.cxx | 323 ++++++++++
connectivity/source/commontools/CommonTools.cxx | 4
connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx | 2
connectivity/source/commontools/TKeys.cxx | 2
connectivity/source/commontools/TTableHelper.cxx | 2
connectivity/source/commontools/dbtools.cxx | 10
connectivity/source/commontools/dbtools2.cxx | 6
connectivity/source/drivers/evoab2/NResultSet.cxx | 7
connectivity/source/drivers/firebird/Util.cxx | 4
connectivity/source/drivers/hsqldb/HStorageMap.cxx | 4
connectivity/source/drivers/jdbc/Object.cxx | 4
connectivity/source/drivers/mork/MQueryHelper.cxx | 2
connectivity/source/drivers/mork/mork_helper.cxx | 2
connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx | 4
connectivity/source/drivers/odbc/OFunctions.cxx | 2
connectivity/source/drivers/postgresql/pq_connection.cxx | 6
connectivity/source/drivers/postgresql/pq_driver.cxx | 6
connectivity/source/manager/mdrivermanager.cxx | 2
connectivity/source/parse/sqlnode.cxx | 4
cppu/qa/cppumaker/test_cppumaker.cxx | 2
cppu/source/LogBridge/LogBridge.cxx | 2
cppu/source/threadpool/current.cxx | 6
cppuhelper/source/implbase_ex.cxx | 2
cppuhelper/source/macro_expander.cxx | 2
cppuhelper/source/propshlp.cxx | 6
cpputools/source/unoexe/unoexe.cxx | 2
cui/source/customize/cfg.cxx | 10
cui/source/dialogs/FontFeaturesDialog.cxx | 4
cui/source/dialogs/scriptdlg.cxx | 2
cui/source/factory/cuiexp.cxx | 2
cui/source/options/optlingu.cxx | 2
cui/source/options/optpath.cxx | 2
cui/source/options/optsave.cxx | 2
cui/source/options/treeopt.cxx | 6
cui/source/tabpages/backgrnd.cxx | 2
cui/source/tabpages/chardlg.cxx | 2
cui/source/tabpages/macroass.cxx | 2
cui/source/tabpages/page.cxx | 10
cui/source/tabpages/paragrph.cxx | 4
cui/source/tabpages/tabstpge.cxx | 2
dbaccess/qa/unit/embeddeddb_performancetest.cxx | 6
dbaccess/source/core/api/FilteredContainer.cxx | 10
dbaccess/source/core/api/View.cxx | 2
dbaccess/source/core/dataaccess/databasedocument.cxx | 2
dbaccess/source/filter/xml/xmlExport.cxx | 2
dbaccess/source/filter/xml/xmlfilter.cxx | 4
dbaccess/source/filter/xml/xmlservices.cxx | 6
dbaccess/source/ui/browser/unodatbr.cxx | 6
dbaccess/source/ui/control/RelationControl.cxx | 2
dbaccess/source/ui/control/SqlNameEdit.cxx | 2
dbaccess/source/ui/control/dbtreelistbox.cxx | 2
dbaccess/source/ui/dlg/DbAdminImpl.cxx | 2
dbaccess/source/ui/dlg/dbwizsetup.cxx | 2
dbaccess/source/ui/dlg/indexdialog.cxx | 8
dbaccess/source/ui/dlg/queryfilter.cxx | 4
dbaccess/source/ui/misc/uiservices.cxx | 6
dbaccess/source/ui/querydesign/ConnectionLine.cxx | 6
dbaccess/source/ui/querydesign/QueryTableView.cxx | 2
desktop/source/app/officeipcthread.cxx | 6
desktop/source/app/opencl.cxx | 2
desktop/source/deployment/gui/dp_gui_service.cxx | 2
desktop/source/deployment/misc/dp_misc.cxx | 2
desktop/source/migration/migration.cxx | 4
desktop/source/migration/services/wordbookmigration.cxx | 2
desktop/source/minidump/minidump.cxx | 8
desktop/source/offacc/acceptor.cxx | 6
desktop/source/pkgchk/unopkg/unopkg_misc.cxx | 4
desktop/unx/source/pagein.c | 2
desktop/unx/source/start.c | 4
drawinglayer/source/primitive2d/borderlineprimitive2d.cxx | 2
drawinglayer/source/primitive2d/polygonprimitive2d.cxx | 2
drawinglayer/source/primitive2d/textlayoutdevice.cxx | 4
drawinglayer/source/tools/wmfemfhelper.cxx | 40 -
editeng/source/accessibility/AccessibleEditableTextPara.cxx | 2
editeng/source/accessibility/AccessibleStaticTextBase.cxx | 2
editeng/source/editeng/editobj.cxx | 4
editeng/source/editeng/impedit.cxx | 2
editeng/source/items/frmitems.cxx | 2
editeng/source/items/paperinf.cxx | 2
editeng/source/misc/svxacorr.cxx | 4
editeng/source/rtf/rtfitem.cxx | 2
editeng/source/uno/unoedprx.cxx | 4
editeng/source/uno/unofield.cxx | 6
editeng/source/uno/unoipset.cxx | 2
editeng/source/uno/unonrule.cxx | 4
editeng/source/uno/unotext.cxx | 8
embeddedobj/source/commonembedding/inplaceobj.cxx | 2
embeddedobj/source/commonembedding/persistence.cxx | 4
embeddedobj/source/msole/olepersist.cxx | 2
emfio/source/reader/emfreader.cxx | 4
eventattacher/source/eventattacher.cxx | 4
extensions/source/abpilot/abpfinalpage.cxx | 2
extensions/source/abpilot/datasourcehandling.cxx | 2
extensions/source/bibliography/bibload.cxx | 2
extensions/source/bibliography/datman.cxx | 6
extensions/source/bibliography/framectr.cxx | 4
extensions/source/dbpilots/dbpservices.cxx | 5
extensions/source/propctrlr/pcrservices.cxx | 5
extensions/source/propctrlr/propertycomposer.cxx | 2
extensions/source/propctrlr/stringrepresentation.cxx | 6
extensions/source/propctrlr/xsddatatypes.cxx | 2
extensions/source/scanner/sane.cxx | 2
extensions/source/update/check/download.cxx | 2
filter/source/config/cache/cacheitem.cxx | 2
filter/source/flash/swffilter.cxx | 4
filter/source/flash/swfwriter.cxx | 2
filter/source/flash/swfwriter1.cxx | 2
filter/source/flash/swfwriter2.cxx | 4
filter/source/graphicfilter/idxf/dxfgrprd.cxx | 4
filter/source/graphicfilter/ieps/ieps.cxx | 4
filter/source/graphicfilter/ipict/shape.cxx | 4
filter/source/msfilter/escherex.cxx | 18
filter/source/msfilter/eschesdo.cxx | 2
filter/source/msfilter/msdffimp.cxx | 8
filter/source/msfilter/msoleexp.cxx | 6
filter/source/msfilter/msvbahelper.cxx | 12
filter/source/msfilter/svdfppt.cxx | 24
filter/source/msfilter/util.cxx | 2
filter/source/pdf/impdialog.cxx | 2
filter/source/svg/svgexport.cxx | 6
filter/source/xsltdialog/xmlfilterdialogcomponent.cxx | 6
forms/source/component/DatabaseForm.cxx | 2
forms/source/misc/InterfaceContainer.cxx | 4
formula/source/core/api/FormulaCompiler.cxx | 2
formula/source/core/api/token.cxx | 2
formula/source/ui/dlg/FormulaHelper.cxx | 2
fpicker/source/office/RemoteFilesDialog.cxx | 2
framework/source/accelerators/acceleratorconfiguration.cxx | 4
framework/source/fwe/helper/actiontriggerhelper.cxx | 14
framework/source/jobs/jobdata.cxx | 2
framework/source/recording/dispatchrecorder.cxx | 4
framework/source/services/ContextChangeEventMultiplexer.cxx | 2
framework/source/uielement/toolbarsmenucontroller.cxx | 4
framework/source/uifactory/factoryconfiguration.cxx | 2
helpcompiler/source/HelpCompiler.cxx | 2
helpcompiler/source/HelpLinker.cxx | 10
hwpfilter/source/grammar.cxx | 6
hwpfilter/source/hwpeq.cxx | 4
hwpfilter/source/lexer.cxx | 24
hwpfilter/source/mzstring.cxx | 2
i18nutil/source/utility/casefolding.cxx | 2
i18nutil/source/utility/unicode.cxx | 2
idl/source/prj/globals.cxx | 2
idl/source/prj/svidl.cxx | 4
idlc/source/astscope.cxx | 2
idlc/source/idlccompile.cxx | 2
idlc/source/parser.y | 12
io/source/acceptor/acc_socket.cxx | 2
io/source/connector/ctr_socket.cxx | 2
javaunohelper/source/bootstrap.cxx | 2
jvmfwk/plugins/sunmajor/pluginlib/util.cxx | 6
jvmfwk/source/elements.cxx | 2
l10ntools/source/helpex.cxx | 2
l10ntools/source/treex.cxx | 2
libreofficekit/qa/gtktiledviewer/gtv-calc-header-bar.cxx | 4
libreofficekit/qa/tilebench/tilebench.cxx | 6
lingucomponent/source/hyphenator/hyphen/hyphenimp.cxx | 2
lingucomponent/source/languageguessing/guess.cxx | 2
lingucomponent/source/languageguessing/guesslang.cxx | 2
lingucomponent/source/lingutil/lingutil.cxx | 2
lingucomponent/source/numbertext/numbertext.cxx | 2
lingucomponent/source/spellcheck/spell/sspellimp.cxx | 2
lingucomponent/source/thesaurus/libnth/nthesimp.cxx | 2
linguistic/source/convdic.cxx | 2
linguistic/source/convdiclist.cxx | 4
linguistic/source/dlistimp.cxx | 2
linguistic/source/gciterator.cxx | 6
linguistic/source/hhconvdic.cxx | 4
linguistic/source/lngopt.cxx | 2
linguistic/source/lngsvcmgr.cxx | 2
linguistic/source/misc.cxx | 2
linguistic/source/spelldsp.cxx | 2
linguistic/source/spelldta.cxx | 2
lotuswordpro/source/filter/bencont.cxx | 2
lotuswordpro/source/filter/lwpfilter.cxx | 4
lotuswordpro/source/filter/xfilter/xfbase64.cxx | 2
odk/source/unoapploader/unx/unoapploader.c | 4
oox/source/crypto/AgileEngine.cxx | 2
oox/source/drawingml/customshapegeometry.cxx | 2
oox/source/drawingml/diagram/diagram.cxx | 6
oox/source/drawingml/table/tablecell.cxx | 8
oox/source/drawingml/table/tableproperties.cxx | 8
oox/source/drawingml/textcharacterproperties.cxx | 2
oox/source/drawingml/textliststyle.cxx | 2
oox/source/export/chartexport.cxx | 20
oox/source/export/drawingml.cxx | 10
oox/source/export/shapes.cxx | 8
oox/source/export/vmlexport.cxx | 10
oox/source/ole/olehelper.cxx | 2
oox/source/ole/vbaexport.cxx | 2
oox/source/ppt/presentationfragmenthandler.cxx | 2
oox/source/ppt/slidepersist.cxx | 2
oox/source/vml/vmlformatting.cxx | 4
oox/source/vml/vmlshape.cxx | 4
opencl/source/openclwrapper.cxx | 2
package/source/manifest/ManifestReader.cxx | 2
package/source/manifest/ManifestWriter.cxx | 2
package/source/xstor/xfactory.cxx | 2
package/source/xstor/xstorage.cxx | 2
package/source/zippackage/ZipPackage.cxx | 2
pyuno/source/loader/pyuno_loader.cxx | 6
pyuno/source/module/pyuno.cxx | 52 -
pyuno/source/module/pyuno_callable.cxx | 4
pyuno/source/module/pyuno_iterator.cxx | 10
pyuno/source/module/pyuno_struct.cxx | 12
remotebridges/source/unourl_resolver/unourl_resolver.cxx | 4
reportdesign/source/core/api/FixedLine.cxx | 2
reportdesign/source/core/api/FixedText.cxx | 2
reportdesign/source/core/api/FormattedField.cxx | 2
reportdesign/source/core/api/ImageControl.cxx | 2
reportdesign/source/core/api/ReportComponent.cxx | 2
reportdesign/source/core/api/ReportDefinition.cxx | 6
reportdesign/source/core/api/Section.cxx | 4
reportdesign/source/core/api/Shape.cxx | 2
reportdesign/source/core/sdr/ReportUndoFactory.cxx | 2
reportdesign/source/core/sdr/RptObject.cxx | 2
reportdesign/source/filter/xml/xmlExport.cxx | 4
reportdesign/source/filter/xml/xmlExportDocumentHandler.cxx | 4
reportdesign/source/filter/xml/xmlGroup.cxx | 2
reportdesign/source/filter/xml/xmlSection.cxx | 2
reportdesign/source/filter/xml/xmlTable.cxx | 2
reportdesign/source/filter/xml/xmlfilter.cxx | 4
reportdesign/source/ui/dlg/GroupsSorting.cxx | 2
reportdesign/source/ui/dlg/Navigator.cxx | 4
reportdesign/source/ui/misc/UITools.cxx | 2
reportdesign/source/ui/report/ReportSection.cxx | 2
reportdesign/source/ui/report/ScrollHelper.cxx | 2
reportdesign/source/ui/report/SectionWindow.cxx | 4
reportdesign/source/ui/report/ViewsWindow.cxx | 2
reportdesign/source/ui/report/dlgedfunc.cxx | 2
sal/osl/unx/file_path_helper.cxx | 6
sal/osl/unx/pipe.cxx | 4
sal/osl/unx/process.cxx | 6
sal/osl/unx/socket.cxx | 20
sal/osl/unx/uunxapi.cxx | 2
sal/qa/osl/file/osl_File.cxx | 44 -
sal/qa/osl/module/osl_Module.cxx | 2
sal/qa/osl/mutex/osl_Mutex.cxx | 4
sal/qa/osl/pipe/osl_Pipe.cxx | 4
sal/qa/osl/process/osl_Thread.cxx | 12
sal/qa/osl/process/osl_process.cxx | 4
sal/qa/osl/process/osl_process_child.cxx | 4
sal/qa/osl/security/osl_Security.cxx | 2
sal/qa/rtl/alloc/rtl_alloc.cxx | 2
sal/qa/rtl/doublelock/rtl_doublelocking.cxx | 2
sal/qa/rtl/locale/rtl_locale.cxx | 2
sal/qa/rtl/process/rtl_Process.cxx | 8
sal/qa/rtl/ref/rtl_ref.cxx | 2
sal/qa/rtl/strings/test_ostring_concat.cxx | 2
sal/qa/rtl/strings/test_oustring_concat.cxx | 2
sal/qa/rtl/strings/test_oustring_stringliterals.cxx | 4
sal/qa/rtl/strings/test_strings_valuex.cxx | 4
sal/rtl/bootstrap.cxx | 4
sal/rtl/hash.cxx | 2
sal/rtl/string.cxx | 2
sax/source/tools/converter.cxx | 2
sax/source/tools/fastserializer.cxx | 4
sc/qa/extras/new_cond_format.cxx | 2
sc/qa/unit/chart2dataprovider.cxx | 6
sc/qa/unit/filters-test.cxx | 4
sc/qa/unit/parallelism.cxx | 2
sc/qa/unit/subsequent_export-test.cxx | 2
sc/qa/unit/tiledrendering/tiledrendering.cxx | 2
sc/qa/unit/ucalc.cxx | 4
sc/qa/unit/ucalc_formula.cxx | 12
sc/source/core/data/bcaslot.cxx | 2
sc/source/core/data/column2.cxx | 2
sc/source/core/data/dociter.cxx | 4
sc/source/core/data/dpobject.cxx | 4
sc/source/core/data/drwlayer.cxx | 8
sc/source/core/data/patattr.cxx | 6
sc/source/core/data/table2.cxx | 2
sc/source/core/data/table3.cxx | 4
sc/source/core/opencl/formulagroupcl.cxx | 4
sc/source/core/tool/addincol.cxx | 2
sc/source/core/tool/address.cxx | 2
sc/source/core/tool/detfunc.cxx | 4
sc/source/core/tool/interpr1.cxx | 10
sc/source/core/tool/interpr3.cxx | 2
sc/source/core/tool/interpr6.cxx | 2
sc/source/core/tool/prnsave.cxx | 2
sc/source/core/tool/refupdat.cxx | 4
sc/source/filter/excel/xelink.cxx | 2
sc/source/filter/excel/xename.cxx | 2
sc/source/filter/excel/xetable.cxx | 2
sc/source/filter/excel/xilink.cxx | 2
sc/source/filter/html/htmlpars.cxx | 2
sc/source/filter/lotus/filter.cxx | 2
sc/source/filter/oox/sheetdatabuffer.cxx | 4
sc/source/filter/oox/stylesbuffer.cxx | 2
sc/source/ui/Accessibility/AccessibleSpreadsheet.cxx | 2
sc/source/ui/app/inputhdl.cxx | 2
sc/source/ui/attrdlg/scuiexp.cxx | 2
sc/source/ui/dbgui/scuiasciiopt.cxx | 2
sc/source/ui/docshell/docfunc.cxx | 4
sc/source/ui/drawfunc/fusel2.cxx | 2
sc/source/ui/miscdlgs/autofmt.cxx | 2
sc/source/ui/undo/undocell.cxx | 2
sc/source/ui/unoobj/PivotTableDataSequence.cxx | 2
sc/source/ui/unoobj/servuno.cxx | 2
sc/source/ui/vba/vbaborders.cxx | 2
sc/source/ui/vba/vbacomments.cxx | 2
sc/source/ui/vba/vbapivottables.cxx | 2
sc/source/ui/vba/vbarange.cxx | 32
sc/source/ui/vba/vbawindows.cxx | 2
sc/source/ui/view/editsh.cxx | 2
sc/source/ui/view/output.cxx | 6
sc/source/ui/view/output2.cxx | 8
sc/source/ui/view/tabview.cxx | 2
sc/source/ui/view/viewfunc.cxx | 2
scaddins/source/analysis/analysishelper.cxx | 10
scaddins/source/analysis/bessel.cxx | 8
scaddins/source/datefunc/datefunc.cxx | 4
scaddins/source/pricing/black_scholes.cxx | 24
scaddins/source/pricing/pricing.cxx | 2
scripting/source/dlgprov/dlgprov.cxx | 4
scripting/source/provider/MasterScriptProvider.cxx | 14
scripting/source/stringresource/stringresource.cxx | 20
scripting/source/vbaevents/eventhelper.cxx | 26
sd/qa/unit/export-tests-ooxml2.cxx | 4
sd/qa/unit/import-tests.cxx | 2
sd/source/core/EffectMigration.cxx | 4
sd/source/core/drawdoc3.cxx | 4
sd/source/core/sdpage.cxx | 6
sd/source/core/text/textapi.cxx | 2
sd/source/filter/eppt/eppt.cxx | 2
sd/source/filter/eppt/epptso.cxx | 4
sd/source/filter/eppt/pptexanimations.cxx | 2
sd/source/filter/html/pubdlg.cxx | 4
sd/source/filter/ppt/pptinanimations.cxx | 2
sd/source/filter/xml/sdxmlwrp.cxx | 4
sd/source/ui/accessibility/SdShapeTypes.cxx | 2
sd/source/ui/animations/CustomAnimationList.cxx | 2
sd/source/ui/animations/CustomAnimationPane.cxx | 4
sd/source/ui/annotations/annotationwindow.cxx | 2
sd/source/ui/app/optsitem.cxx | 2
sd/source/ui/controller/slidelayoutcontroller.cxx | 8
sd/source/ui/dlg/NavigatorChildWindow.cxx | 2
sd/source/ui/func/fuconrec.cxx | 2
sd/source/ui/func/fumorph.cxx | 2
sd/source/ui/func/fupage.cxx | 2
sd/source/ui/remotecontrol/BluetoothServer.cxx | 4
sd/source/ui/slideshow/slideshow.cxx | 2
sd/source/ui/slidesorter/controller/SlsSelectionFunction.cxx | 2
sd/source/ui/slidesorter/view/SlsTheme.cxx | 4
sd/source/ui/table/TableDesignPane.cxx | 2
sd/source/ui/unoidl/UnoDocumentSettings.cxx | 2
sd/source/ui/unoidl/unolayer.cxx | 2
sd/source/ui/unoidl/unomodel.cxx | 8
sd/source/ui/unoidl/unopage.cxx | 4
sd/source/ui/unoidl/unopool.cxx | 2
sd/source/ui/unoidl/unosrch.cxx | 2
sd/source/ui/view/drviews7.cxx | 2
sd/source/ui/view/drviewse.cxx | 2
sd/source/ui/view/sdview3.cxx | 4
sdext/source/minimizer/graphiccollector.cxx | 14
sdext/source/minimizer/impoptimizer.cxx | 16
sdext/source/minimizer/optimizerdialogcontrols.cxx | 18
sdext/source/pdfimport/test/pdfunzip.cxx | 14
sdext/source/pdfimport/tree/drawtreevisiting.cxx | 6
sdext/source/pdfimport/xpdfwrapper/pdfioutdev_gpl.cxx | 28
sfx2/source/appl/appinit.cxx | 2
sfx2/source/appl/appserv.cxx | 2
sfx2/source/appl/fileobj.cxx | 2
sfx2/source/appl/linkmgr2.cxx | 2
sfx2/source/appl/newhelp.cxx | 4
sfx2/source/appl/opengrf.cxx | 2
sfx2/source/appl/sfxhelp.cxx | 8
sfx2/source/appl/workwin.cxx | 6
sfx2/source/bastyp/fltfnc.cxx | 4
sfx2/source/config/evntconf.cxx | 4
sfx2/source/control/dispatch.cxx | 8
sfx2/source/control/shell.cxx | 8
sfx2/source/dialog/filedlghelper.cxx | 8
sfx2/source/dialog/filtergrouping.cxx | 16
sfx2/source/dialog/templdlg.cxx | 10
sfx2/source/dialog/versdlg.cxx | 2
sfx2/source/doc/DocumentMetadataAccess.cxx | 2
sfx2/source/doc/Metadatable.cxx | 4
sfx2/source/doc/docinsert.cxx | 2
sfx2/source/doc/objstor.cxx | 2
sfx2/source/doc/printhelper.cxx | 4
sfx2/source/doc/sfxbasemodel.cxx | 4
sfx2/source/sidebar/Deck.cxx | 2
sfx2/source/view/sfxbasecontroller.cxx | 2
sfx2/source/view/viewfrm.cxx | 4
sfx2/source/view/viewsh.cxx | 4
slideshow/source/engine/eventmultiplexer.cxx | 2
slideshow/source/engine/opengl/Operation.cxx | 2
slideshow/source/engine/opengl/TransitionImpl.cxx | 12
slideshow/source/engine/shapes/gdimtftools.cxx | 2
slideshow/source/engine/slide/layermanager.cxx | 2
smoketest/libtest.cxx | 4
solenv/bin/concat-deps.c | 2
sot/source/sdstor/storage.cxx | 2
sot/source/sdstor/ucbstorage.cxx | 6
starmath/source/dialog.cxx | 2
starmath/source/mathmlattr.cxx | 4
stoc/source/invocation/invocation.cxx | 4
stoc/source/javaloader/javaloader.cxx | 2
svgio/source/svgreader/svgimagenode.cxx | 2
svgio/source/svgreader/svgstyleattributes.cxx | 4
svl/qa/unit/svl.cxx | 2
svl/source/numbers/zforfind.cxx | 2
svl/source/numbers/zformat.cxx | 4
svl/source/undo/undo.cxx | 2
svtools/source/brwbox/brwbox3.cxx | 2
svtools/source/config/extcolorcfg.cxx | 2
svtools/source/contnr/fileview.cxx | 2
svtools/source/control/ctrlbox.cxx | 4
svtools/source/misc/bindablecontrolhelper.cxx | 2
svtools/source/misc/templatefoldercache.cxx | 4
svtools/source/misc/unitconv.cxx | 60 -
svx/source/accessibility/AccessibleTextHelper.cxx | 2
svx/source/accessibility/ShapeTypeHandler.cxx | 2
svx/source/accessibility/SvxShapeTypes.cxx | 2
svx/source/customshapes/EnhancedCustomShape2d.cxx | 2
svx/source/customshapes/EnhancedCustomShapeFontWork.cxx | 20
svx/source/dialog/docrecovery.cxx | 2
svx/source/dialog/framelink.cxx | 4
svx/source/dialog/framelinkarray.cxx | 8
svx/source/dialog/srchdlg.cxx | 4
svx/source/dialog/svxruler.cxx | 6
svx/source/engine3d/helperhittest3d.cxx | 2
svx/source/engine3d/view3d1.cxx | 2
svx/source/fmcomp/fmgridcl.cxx | 2
svx/source/fmcomp/fmgridif.cxx | 6
svx/source/fmcomp/gridcols.cxx | 8
svx/source/form/datanavi.cxx | 2
svx/source/form/fmPropBrw.cxx | 2
svx/source/form/fmshimp.cxx | 6
svx/source/form/fmvwimp.cxx | 2
svx/source/form/navigatortree.cxx | 2
svx/source/gallery2/galctrl.cxx | 2
svx/source/gengal/gengal.cxx | 4
svx/source/items/pageitem.cxx | 2
svx/source/sdr/contact/viewobjectcontactofunocontrol.cxx | 8
svx/source/sdr/overlay/overlayselection.cxx | 4
svx/source/svdraw/svddrgmt.cxx | 2
svx/source/svdraw/svdedtv1.cxx | 2
svx/source/svdraw/svdhdl.cxx | 5
svx/source/svdraw/svdibrow.cxx | 6
svx/source/svdraw/svdmodel.cxx | 2
svx/source/svdraw/svdoashp.cxx | 2
svx/source/svdraw/svdobj.cxx | 2
svx/source/svdraw/svdocirc.cxx | 4
svx/source/svdraw/svdomeas.cxx | 2
svx/source/svdraw/svdopath.cxx | 4
svx/source/svdraw/svdotext.cxx | 4
svx/source/svdraw/svdotextdecomposition.cxx | 6
svx/source/svdraw/svdpage.cxx | 2
svx/source/svdraw/svdtrans.cxx | 6
svx/source/table/tablecontroller.cxx | 2
svx/source/table/tablemodel.cxx | 4
svx/source/table/tablertfexporter.cxx | 2
svx/source/table/tablertfimporter.cxx | 2
svx/source/table/viewcontactoftableobj.cxx | 2
svx/source/toolbars/extrusionbar.cxx | 16
svx/source/toolbars/fontworkbar.cxx | 10
svx/source/unodraw/UnoNamespaceMap.cxx | 4
svx/source/unodraw/unobrushitemhelper.cxx | 4
svx/source/unodraw/unoprov.cxx | 60 -
svx/source/unodraw/unoshap3.cxx | 2
svx/source/unodraw/unoshape.cxx | 2
svx/source/xoutdev/xattr.cxx | 2
sw/qa/core/uwriter.cxx | 4
sw/qa/extras/globalfilter/globalfilter.cxx | 2
sw/qa/extras/odfexport/odfexport.cxx | 2
sw/qa/extras/odfimport/odfimport.cxx | 2
sw/qa/extras/ooxmlexport/ooxmlexport2.cxx | 2
sw/qa/extras/ooxmlimport/ooxmlimport.cxx | 2
sw/qa/extras/tiledrendering/tiledrendering.cxx | 2
sw/qa/extras/uiwriter/uiwriter.cxx | 2
sw/source/core/access/accpara.cxx | 4
sw/source/core/bastyp/calc.cxx | 2
sw/source/core/bastyp/swregion.cxx | 2
sw/source/core/crsr/crsrsh.cxx | 2
sw/source/core/crsr/crstrvl.cxx | 2
sw/source/core/crsr/findattr.cxx | 2
sw/source/core/crsr/findtxt.cxx | 2
sw/source/core/crsr/pam.cxx | 2
sw/source/core/crsr/trvlfnfl.cxx | 4
sw/source/core/doc/DocumentStylePoolManager.cxx | 2
sw/source/core/doc/dbgoutsw.cxx | 2
sw/source/core/doc/docglbl.cxx | 8
sw/source/core/doc/docnum.cxx | 2
sw/source/core/doc/docredln.cxx | 2
sw/source/core/doc/gctable.cxx | 2
sw/source/core/doc/notxtfrm.cxx | 4
sw/source/core/doc/tblrwcl.cxx | 6
sw/source/core/doc/textboxhelper.cxx | 2
sw/source/core/docnode/ndtbl1.cxx | 10
sw/source/core/docnode/node.cxx | 18
sw/source/core/docnode/node2lay.cxx | 4
sw/source/core/docnode/nodes.cxx | 4
sw/source/core/draw/dcontact.cxx | 4
sw/source/core/draw/dpage.cxx | 2
sw/source/core/draw/dview.cxx | 2
sw/source/core/edit/autofmt.cxx | 2
sw/source/core/edit/edfcol.cxx | 22
sw/source/core/edit/edtab.cxx | 4
sw/source/core/fields/expfld.cxx | 2
sw/source/core/frmedt/fetab.cxx | 2
sw/source/core/layout/frmtool.cxx | 6
sw/source/core/layout/ftnfrm.cxx | 2
sw/source/core/layout/hffrm.cxx | 2
sw/source/core/layout/newfrm.cxx | 8
sw/source/core/layout/tabfrm.cxx | 4
sw/source/core/layout/trvlfrm.cxx | 4
sw/source/core/layout/virtoutp.cxx | 2
sw/source/core/table/swtable.cxx | 6
sw/source/core/text/frmform.cxx | 2
sw/source/core/text/frminf.cxx | 2
sw/source/core/text/inftxt.cxx | 4
sw/source/core/text/itratr.cxx | 2
sw/source/core/text/itrform2.cxx | 2
sw/source/core/text/itrpaint.cxx | 2
sw/source/core/text/porlay.cxx | 6
sw/source/core/text/porlin.cxx | 2
sw/source/core/text/txtfrm.cxx | 4
sw/source/core/text/txtftn.cxx | 2
sw/source/core/txtnode/ndtxt.cxx | 2
sw/source/core/txtnode/swfont.cxx | 2
sw/source/core/txtnode/thints.cxx | 2
sw/source/core/txtnode/txtedt.cxx | 2
sw/source/core/undo/untbl.cxx | 2
sw/source/core/unocore/unofield.cxx | 2
sw/source/core/unocore/unoidx.cxx | 6
sw/source/core/unocore/unoobj.cxx | 2
sw/source/core/unocore/unosett.cxx | 8
sw/source/core/unocore/unostyle.cxx | 6
sw/source/core/unocore/unotbl.cxx | 2
sw/source/filter/basflt/fltini.cxx | 8
sw/source/filter/html/htmlatr.cxx | 4
sw/source/filter/html/htmlftn.cxx | 4
sw/source/filter/ww8/WW8TableInfo.cxx | 2
sw/source/filter/ww8/docxattributeoutput.cxx | 2
sw/source/filter/ww8/docxexportfilter.cxx | 6
sw/source/filter/ww8/docxsdrexport.cxx | 4
sw/source/filter/ww8/rtfsdrexport.cxx | 6
sw/source/filter/ww8/writerwordglue.cxx | 12
sw/source/filter/ww8/wrtw8esh.cxx | 6
sw/source/filter/ww8/wrtw8nds.cxx | 4
sw/source/filter/ww8/ww8atr.cxx | 2
sw/source/filter/ww8/ww8graf.cxx | 8
sw/source/filter/ww8/ww8graf2.cxx | 2
sw/source/filter/ww8/ww8par.cxx | 6
sw/source/filter/ww8/ww8par2.cxx | 4
sw/source/filter/ww8/ww8par3.cxx | 4
sw/source/filter/ww8/ww8par5.cxx | 10
sw/source/filter/ww8/ww8par6.cxx | 20
sw/source/filter/ww8/ww8scan.cxx | 18
sw/source/filter/xml/xmlithlp.cxx | 2
sw/source/ui/chrdlg/drpcps.cxx | 2
sw/source/ui/config/optcomp.cxx | 2
sw/source/ui/frmdlg/column.cxx | 3
sw/source/ui/table/autoformatpreview.cxx | 4
sw/source/ui/vba/vbaborders.cxx | 2
sw/source/ui/vba/vbavariables.cxx | 2
sw/source/uibase/app/apphdl.cxx | 2
sw/source/uibase/app/swmodul1.cxx | 2
sw/source/uibase/docvw/AnnotationMenuButton.cxx | 2
sw/source/uibase/docvw/edtwin.cxx | 4
sw/source/uibase/fldui/fldmgr.cxx | 2
sw/source/uibase/misc/glosdoc.cxx | 2
sw/source/uibase/sidebar/PageStylesPanel.cxx | 4
sw/source/uibase/uiview/viewport.cxx | 4
sw/source/uibase/uiview/viewtab.cxx | 2
sw/source/uibase/uno/unomailmerge.cxx | 2
sw/source/uibase/utlui/uitool.cxx | 6
test/source/bootstrapfixture.cxx | 2
test/source/sheet/xsheetoutline.cxx | 4
testtools/source/bridgetest/bridgetest.cxx | 6
testtools/source/bridgetest/cppobj.cxx | 4
toolkit/source/awt/vclxwindow.cxx | 2
toolkit/source/controls/stdtabcontrollermodel.cxx | 4
toolkit/source/controls/unocontrolcontainer.cxx | 2
toolkit/source/helper/property.cxx | 6
toolkit/source/helper/unowrapper.cxx | 2
tools/source/generic/poly.cxx | 4
ucb/source/core/ucbstore.cxx | 2
ucb/source/ucp/file/filrow.cxx | 2
ucb/source/ucp/ftp/ftpdirp.cxx | 2
ucb/source/ucp/ftp/ftploaderthread.cxx | 4
ucb/source/ucp/ftp/ftpurl.cxx | 2
ucb/source/ucp/hierarchy/hierarchydata.cxx | 2
ucb/source/ucp/webdav-neon/LinkSequence.cxx | 9
ucb/source/ucp/webdav-neon/LockEntrySequence.cxx | 9
ucb/source/ucp/webdav-neon/LockSequence.cxx | 9
ucb/source/ucp/webdav-neon/NeonPropFindRequest.cxx | 12
ucb/source/ucp/webdav-neon/NeonSession.cxx | 22
ucb/source/ucp/webdav-neon/UCBDeadPropertyValue.cxx | 9
ucbhelper/source/client/proxydecider.cxx | 4
unodevtools/source/skeletonmaker/cppcompskeleton.cxx | 24
unodevtools/source/skeletonmaker/cpptypemaker.cxx | 18
unodevtools/source/skeletonmaker/javacompskeleton.cxx | 30
unodevtools/source/skeletonmaker/javatypemaker.cxx | 18
unodevtools/source/skeletonmaker/skeletoncommon.cxx | 14
unoidl/source/sourceprovider-parser.y | 2
unoidl/source/unoidl-check.cxx | 6
unoidl/source/unoidlprovider.cxx | 2
unotest/source/cpp/filters-test.cxx | 2
unotools/source/config/configvaluecontainer.cxx | 4
unotools/source/config/defaultoptions.cxx | 2
unotools/source/config/optionsdlg.cxx | 6
unotools/source/config/saveopt.cxx | 2
unotools/source/i18n/localedatawrapper.cxx | 8
unotools/source/misc/fontcvt.cxx | 2
unotools/source/ucbhelper/progresshandlerwrap.cxx | 2
unotools/source/ucbhelper/tempfile.cxx | 10
unoxml/source/dom/documentbuilder.cxx | 2
vbahelper/source/vbahelper/vbahelper.cxx | 6
vbahelper/source/vbahelper/vbawindowbase.cxx | 2
vcl/backendtest/VisualBackendTest.cxx | 8
vcl/headless/svpbmp.cxx | 2
vcl/headless/svpgdi.cxx | 2
vcl/headless/svpprn.cxx | 2
vcl/qa/cppunit/canvasbitmaptest.cxx | 2
vcl/qa/cppunit/jpeg/JpegReaderTest.cxx | 6
vcl/qa/cppunit/svm/svmtest.cxx | 8
vcl/qt5/Qt5Graphics_Controls.cxx | 3
vcl/source/app/dbggui.cxx | 2
vcl/source/app/i18nhelp.cxx | 2
vcl/source/app/svapp.cxx | 2
vcl/source/app/svmain.cxx | 2
vcl/source/control/field.cxx | 2
vcl/source/control/longcurr.cxx | 2
vcl/source/control/tabctrl.cxx | 2
vcl/source/filter/FilterConfigCache.cxx | 2
vcl/source/filter/graphicfilter.cxx | 2
vcl/source/filter/graphicfilter2.cxx | 2
vcl/source/filter/jpeg/JpegReader.cxx | 18
vcl/source/filter/jpeg/JpegWriter.cxx | 10
vcl/source/filter/jpeg/jpegc.cxx | 16
vcl/source/fontsubset/cff.cxx | 2
vcl/source/fontsubset/sft.cxx | 2
vcl/source/gdi/bmpfast.cxx | 16
vcl/source/gdi/impvect.cxx | 16
vcl/source/gdi/pdfwriter_impl.cxx | 2
vcl/source/gdi/pdfwriter_impl2.cxx | 8
vcl/source/gdi/region.cxx | 2
vcl/source/gdi/sallayout.cxx | 2
vcl/source/gdi/svmconverter.cxx | 16
vcl/source/gdi/vectorgraphicdata.cxx | 2
vcl/source/helper/commandinfoprovider.cxx | 22
vcl/source/image/ImplImageTree.cxx | 6
vcl/source/opengl/OpenGLContext.cxx | 2
vcl/source/outdev/hatch.cxx | 6
vcl/source/outdev/map.cxx | 2
vcl/source/window/accel.cxx | 2
vcl/source/window/builder.cxx | 4
vcl/source/window/keycod.cxx | 3
vcl/source/window/layout.cxx | 6
vcl/source/window/menu.cxx | 2
vcl/source/window/printdlg.cxx | 2
vcl/source/window/status.cxx | 2
vcl/source/window/syschild.cxx | 2
vcl/source/window/syswin.cxx | 2
vcl/source/window/tabdlg.cxx | 2
vcl/source/window/toolbox.cxx | 4
vcl/source/window/window2.cxx | 2
vcl/source/window/winproc.cxx | 10
vcl/unx/generic/app/i18n_cb.cxx | 10
vcl/unx/generic/app/saldata.cxx | 2
vcl/unx/generic/app/saldisp.cxx | 16
vcl/unx/generic/app/salinst.cxx | 2
vcl/unx/generic/app/sm.cxx | 8
vcl/unx/generic/dtrans/X11_selection.cxx | 2
vcl/unx/generic/dtrans/bmp.cxx | 14
vcl/unx/generic/fontmanager/fontmanager.cxx | 2
vcl/unx/generic/print/genprnpsp.cxx | 4
vcl/unx/generic/print/printerjob.cxx | 6
vcl/unx/generic/window/salframe.cxx | 2
vcl/unx/generic/window/screensaverinhibitor.cxx | 2
vcl/unx/glxtest.cxx | 2
vcl/unx/gtk/a11y/atkcomponent.cxx | 2
vcl/unx/gtk/a11y/atkfactory.cxx | 2
vcl/unx/gtk/a11y/atklistener.cxx | 2
vcl/unx/gtk/a11y/atktext.cxx | 2
vcl/unx/gtk/a11y/atktextattributes.cxx | 6
vcl/unx/gtk/a11y/atkutil.cxx | 2
vcl/unx/gtk/gloactiongroup.cxx | 2
vcl/unx/gtk/glomenu.cxx | 6
vcl/unx/gtk/gtkdata.cxx | 6
vcl/unx/gtk/gtksalframe.cxx | 6
vcl/unx/gtk/gtksalmenu.cxx | 10
vcl/unx/gtk/salnativewidgets-gtk.cxx | 2
vcl/unx/gtk3/gtk3gtkdata.cxx | 6
vcl/unx/gtk3/gtk3gtkframe.cxx | 6
vcl/unx/gtk3/gtk3gtkinst.cxx | 10
vcl/unx/gtk3/gtk3salnativewidgets-gtk.cxx | 4
vcl/unx/gtk3_kde5/kde5_filepicker_ipc.cxx | 2
vcl/unx/kde4/KDE4FilePicker.cxx | 4
vcl/unx/kde4/KDESalGraphics.cxx | 4
vcl/workben/svdem.cxx | 2
vcl/workben/svpclient.cxx | 2
vcl/workben/svptest.cxx | 2
writerfilter/source/dmapper/CellColorHandler.cxx | 2
writerfilter/source/dmapper/ConversionHelper.cxx | 2
writerfilter/source/dmapper/DomainMapperTableHandler.cxx | 14
writerfilter/source/dmapper/NumberingManager.cxx | 8
writerfilter/source/dmapper/PropertyMap.cxx | 4
writerfilter/source/dmapper/SdtHelper.cxx | 2
writerfilter/source/dmapper/StyleSheetTable.cxx | 2
writerfilter/source/rtftok/rtfdispatchvalue.cxx | 2
writerperfect/source/calc/MSWorksCalcImportFilter.cxx | 2
xmlhelp/source/cxxhelp/provider/databases.cxx | 2
xmlhelp/source/treeview/tvread.cxx | 12
xmloff/source/chart/SchXMLChartContext.cxx | 4
xmloff/source/chart/SchXMLTools.cxx | 2
xmloff/source/core/DocumentSettingsContext.cxx | 2
xmloff/source/core/DomExport.cxx | 6
xmloff/source/draw/shapeexport.cxx | 10
xmloff/source/draw/xexptran.cxx | 16
xmloff/source/draw/ximpcustomshape.cxx | 44 -
xmloff/source/forms/controlpropertymap.cxx | 4
xmloff/source/style/XMLFontAutoStylePool.cxx | 6
xmloff/source/style/xmlnumfe.cxx | 2
xmloff/source/table/XMLTableExport.cxx | 2
xmloff/source/text/txtflde.cxx | 18
xmloff/source/transform/EventOASISTContext.cxx | 2
xmloff/source/xforms/SchemaRestrictionContext.cxx | 16
xmloff/source/xforms/xformsexport.cxx | 26
xmlscript/source/xmldlg_imexp/xmldlg_export.cxx | 2
xmlsecurity/source/helper/documentsignaturehelper.cxx | 2
xmlsecurity/source/xmlsec/errorcallback.cxx | 7
xmlsecurity/source/xmlsec/nss/nssinitializer.cxx | 5
xmlsecurity/source/xmlsec/nss/securityenvironment_nssimpl.cxx | 6
xmlsecurity/source/xmlsec/nss/x509certificate_nssimpl.cxx | 4
xmlsecurity/source/xmlsec/saxhelper.cxx | 6
xmlsecurity/source/xmlsec/xmlstreamio.cxx | 16
787 files changed, 2337 insertions(+), 1878 deletions(-)
New commits:
commit 206b5b2661be37efdff3c6aedb6f248c4636be79
Author: Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Sat Sep 15 19:13:19 2018 +0200
Commit: Stephan Bergmann <sbergman at redhat.com>
CommitDate: Mon Sep 17 09:05:38 2018 +0200
New loplugin:external
...warning about (for now only) functions and variables with external linkage
that likely don't need it.
The problems with moving entities into unnamed namespacs and breaking ADL
(as alluded to in comments in compilerplugins/clang/external.cxx) are
illustrated by the fact that while
struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }
returns 1, both moving just the struct S2 into an nunnamed namespace,
struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
namespace { struct S2: S1 { int f() { return 1; } }; }
int f(S2 s) { return s.f(); }
}
int main() { return f(N::S2()); }
as well as moving just the function f overload into an unnamed namespace,
struct S1 { int f() { return 0; } };
int f(S1 s) { return s.f(); }
namespace N {
struct S2: S1 { int f() { return 1; } };
namespace { int f(S2 s) { return s.f(); } }
}
int main() { return f(N::S2()); }
would each change the program to return 0 instead.
Change-Id: I4d09f7ac5e8f9bcd6e6bde4712608444b642265c
Reviewed-on: https://gerrit.libreoffice.org/60539
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman at redhat.com>
diff --git a/animations/source/animcore/animcore.cxx b/animations/source/animcore/animcore.cxx
index 5e0bff6362a8..12ba771046ab 100644
--- a/animations/source/animcore/animcore.cxx
+++ b/animations/source/animcore/animcore.cxx
@@ -491,112 +491,112 @@ AnimationNode::AnimationNode( const AnimationNode& rNode )
{
}
-Sequence<OUString> getSupportedServiceNames_PAR()
+static Sequence<OUString> getSupportedServiceNames_PAR()
{
return { "com.sun.star.animations.ParallelTimeContainer" };
}
-OUString getImplementationName_PAR()
+static OUString getImplementationName_PAR()
{
return OUString( "animcore::ParallelTimeContainer" );
}
-Sequence<OUString> getSupportedServiceNames_SEQ()
+static Sequence<OUString> getSupportedServiceNames_SEQ()
{
return { "com.sun.star.animations.SequenceTimeContainer" };
}
-OUString getImplementationName_SEQ()
+static OUString getImplementationName_SEQ()
{
return OUString( "animcore::SequenceTimeContainer" );
}
-Sequence<OUString> getSupportedServiceNames_ITERATE()
+static Sequence<OUString> getSupportedServiceNames_ITERATE()
{
return { "com.sun.star.animations.IterateContainer" };
}
-OUString getImplementationName_ITERATE()
+static OUString getImplementationName_ITERATE()
{
return OUString( "animcore::IterateContainer" );
}
-Sequence<OUString> getSupportedServiceNames_ANIMATE()
+static Sequence<OUString> getSupportedServiceNames_ANIMATE()
{
return { "com.sun.star.animations.Animate" };
}
-OUString getImplementationName_ANIMATE()
+static OUString getImplementationName_ANIMATE()
{
return OUString( "animcore::Animate" );
}
-Sequence<OUString> getSupportedServiceNames_SET()
+static Sequence<OUString> getSupportedServiceNames_SET()
{
return { "com.sun.star.animations.AnimateSet" };
}
-OUString getImplementationName_SET()
+static OUString getImplementationName_SET()
{
return OUString( "animcore::AnimateSet" );
}
-Sequence<OUString> getSupportedServiceNames_ANIMATECOLOR()
+static Sequence<OUString> getSupportedServiceNames_ANIMATECOLOR()
{
return { "com.sun.star.animations.AnimateColor" };
}
-OUString getImplementationName_ANIMATECOLOR()
+static OUString getImplementationName_ANIMATECOLOR()
{
return OUString( "animcore::AnimateColor" );
}
-Sequence<OUString> getSupportedServiceNames_ANIMATEMOTION()
+static Sequence<OUString> getSupportedServiceNames_ANIMATEMOTION()
{
return { "com.sun.star.animations.AnimateMotion" };
}
-OUString getImplementationName_ANIMATEMOTION()
+static OUString getImplementationName_ANIMATEMOTION()
{
return OUString( "animcore::AnimateMotion" );
}
-Sequence<OUString> getSupportedServiceNames_ANIMATETRANSFORM()
+static Sequence<OUString> getSupportedServiceNames_ANIMATETRANSFORM()
{
return { "com.sun.star.animations.AnimateTransform" };
}
-OUString getImplementationName_ANIMATETRANSFORM()
+static OUString getImplementationName_ANIMATETRANSFORM()
{
return OUString( "animcore::AnimateTransform" );
}
-Sequence<OUString> getSupportedServiceNames_TRANSITIONFILTER()
+static Sequence<OUString> getSupportedServiceNames_TRANSITIONFILTER()
{
return { "com.sun.star.animations.TransitionFilter" };
}
-OUString getImplementationName_TRANSITIONFILTER()
+static OUString getImplementationName_TRANSITIONFILTER()
{
return OUString( "animcore::TransitionFilter" );
}
-Sequence<OUString> getSupportedServiceNames_AUDIO()
+static Sequence<OUString> getSupportedServiceNames_AUDIO()
{
return { "com.sun.star.animations.Audio" };
}
-OUString getImplementationName_AUDIO()
+static OUString getImplementationName_AUDIO()
{
return OUString( "animcore::Audio" );
}
-Sequence<OUString> getSupportedServiceNames_COMMAND()
+static Sequence<OUString> getSupportedServiceNames_COMMAND()
{
return { "com.sun.star.animations.Command" };
}
-OUString getImplementationName_COMMAND()
+static OUString getImplementationName_COMMAND()
{
return OUString( "animcore::Command" );
}
diff --git a/basctl/source/basicide/baside3.cxx b/basctl/source/basicide/baside3.cxx
index dfa698a4a345..1e216698d1d9 100644
--- a/basctl/source/basicide/baside3.cxx
+++ b/basctl/source/basicide/baside3.cxx
@@ -744,7 +744,7 @@ void DialogWindow::SaveDialog()
}
}
-std::vector< lang::Locale > implGetLanguagesOnlyContainedInFirstSeq
+static std::vector< lang::Locale > implGetLanguagesOnlyContainedInFirstSeq
( const Sequence< lang::Locale >& aFirstSeq, const Sequence< lang::Locale >& aSecondSeq )
{
std::vector< lang::Locale > avRet;
diff --git a/basctl/source/basicide/bastypes.cxx b/basctl/source/basicide/bastypes.cxx
index 47fee717fa00..916b72eca1fb 100644
--- a/basctl/source/basicide/bastypes.cxx
+++ b/basctl/source/basicide/bastypes.cxx
@@ -707,7 +707,7 @@ LibInfo::Item::Item (
LibInfo::Item::~Item ()
{ }
-bool QueryDel(const OUString& rName, const OUString &rStr, weld::Widget* pParent)
+static bool QueryDel(const OUString& rName, const OUString &rStr, weld::Widget* pParent)
{
OUStringBuffer aNameBuf( rName );
aNameBuf.append('\'');
diff --git a/basctl/source/basicide/localizationmgr.cxx b/basctl/source/basicide/localizationmgr.cxx
index 8822ee21c9ba..743e43089deb 100644
--- a/basctl/source/basicide/localizationmgr.cxx
+++ b/basctl/source/basicide/localizationmgr.cxx
@@ -97,7 +97,7 @@ void LocalizationMgr::handleTranslationbar ()
// TODO: -> export from toolkit
-bool isLanguageDependentProperty( const OUString& aName )
+static bool isLanguageDependentProperty( const OUString& aName )
{
static struct Prop
{
@@ -160,7 +160,7 @@ void LocalizationMgr::implEnableDisableResourceForAllLibraryDialogs( HandleResou
}
-OUString implCreatePureResourceId
+static OUString implCreatePureResourceId
( const OUString& aDialogName, const OUString& aCtrlName,
const OUString& aPropName,
const Reference< XStringResourceManager >& xStringResourceManager )
@@ -770,7 +770,7 @@ void LocalizationMgr::handleBasicStopped()
}
-DialogWindow* FindDialogWindowForEditor( DlgEditor const * pEditor )
+static DialogWindow* FindDialogWindowForEditor( DlgEditor const * pEditor )
{
Shell::WindowTable const& aWindowTable = GetShell()->GetWindowTable();
for (auto const& window : aWindowTable)
diff --git a/basctl/source/dlged/dlged.cxx b/basctl/source/dlged/dlged.cxx
index 1e6b11d53a19..23f41d06e6e9 100644
--- a/basctl/source/dlged/dlged.cxx
+++ b/basctl/source/dlged/dlged.cxx
@@ -646,7 +646,7 @@ void DlgEditor::Cut()
}
-void implCopyStreamToByteSequence( const Reference< XInputStream >& xStream,
+static void implCopyStreamToByteSequence( const Reference< XInputStream >& xStream,
Sequence< sal_Int8 >& bytes )
{
xStream->readBytes( bytes, xStream->available() );
@@ -1102,7 +1102,7 @@ namespace Print
long const nBorder = 300;
}
-void lcl_PrintHeader( Printer* pPrinter, const OUString& rTitle ) // not working yet
+static void lcl_PrintHeader( Printer* pPrinter, const OUString& rTitle ) // not working yet
{
pPrinter->Push();
diff --git a/basctl/source/dlged/dlgedview.cxx b/basctl/source/dlged/dlgedview.cxx
index 12d2d57bb99a..b1a2603abb30 100644
--- a/basctl/source/dlged/dlgedview.cxx
+++ b/basctl/source/dlged/dlgedview.cxx
@@ -123,7 +123,7 @@ void DlgEdView::MakeVisible( const tools::Rectangle& rRect, vcl::Window& rWin )
}
}
-SdrObject* impLocalHitCorrection(SdrObject* pRetval, const Point& rPnt, sal_uInt16 nTol)
+static SdrObject* impLocalHitCorrection(SdrObject* pRetval, const Point& rPnt, sal_uInt16 nTol)
{
DlgEdObj* pDlgEdObj = dynamic_cast< DlgEdObj* >(pRetval);
diff --git a/basegfx/source/polygon/b2dpolygonclipper.cxx b/basegfx/source/polygon/b2dpolygonclipper.cxx
index 5057fc52d977..f4b26f260972 100644
--- a/basegfx/source/polygon/b2dpolygonclipper.cxx
+++ b/basegfx/source/polygon/b2dpolygonclipper.cxx
@@ -552,7 +552,7 @@ namespace basegfx
* outside |inside |intersect with clip plane follwed by next
*
*/
- sal_uInt32 scissorLineSegment( ::basegfx::B2DPoint *in_vertex, // input buffer
+ static sal_uInt32 scissorLineSegment( ::basegfx::B2DPoint *in_vertex, // input buffer
sal_uInt32 in_count, // number of verts in input buffer
::basegfx::B2DPoint *out_vertex, // output buffer
scissor_plane const *pPlane, // scissoring plane
diff --git a/basegfx/source/polygon/b2dpolygontools.cxx b/basegfx/source/polygon/b2dpolygontools.cxx
index 94590d7483a8..b5d2abf7e4be 100644
--- a/basegfx/source/polygon/b2dpolygontools.cxx
+++ b/basegfx/source/polygon/b2dpolygontools.cxx
@@ -1654,7 +1654,7 @@ namespace basegfx
return createPolygonFromEllipse( rCenter, fRadius, fRadius );
}
- B2DPolygon impCreateUnitCircle(sal_uInt32 nStartQuadrant)
+ static B2DPolygon impCreateUnitCircle(sal_uInt32 nStartQuadrant)
{
B2DPolygon aUnitCircle;
const double fKappa((M_SQRT2 - 1.0) * 4.0 / 3.0);
diff --git a/basegfx/source/polygon/b3dpolypolygontools.cxx b/basegfx/source/polygon/b3dpolypolygontools.cxx
index 0130dd5d7081..f3975a7a51c0 100644
--- a/basegfx/source/polygon/b3dpolypolygontools.cxx
+++ b/basegfx/source/polygon/b3dpolypolygontools.cxx
@@ -223,7 +223,7 @@ namespace basegfx
// helper for getting the 3D Point from given cartesian coordinates. fHor is defined from
// [F_PI2 .. -F_PI2], fVer from [0.0 .. F_2PI]
- inline B3DPoint getPointFromCartesian(double fHor, double fVer)
+ static inline B3DPoint getPointFromCartesian(double fHor, double fVer)
{
const double fCosVer(cos(fVer));
return B3DPoint(fCosVer * cos(fHor), sin(fVer), fCosVer * -sin(fHor));
diff --git a/basegfx/source/tools/gradienttools.cxx b/basegfx/source/tools/gradienttools.cxx
index b05d9b219a53..082f564556a4 100644
--- a/basegfx/source/tools/gradienttools.cxx
+++ b/basegfx/source/tools/gradienttools.cxx
@@ -45,7 +45,7 @@ namespace basegfx
/** Most of the setup for linear & axial gradient is the same, except
for the border treatment. Factored out here.
*/
- ODFGradientInfo init1DGradientInfo(
+ static ODFGradientInfo init1DGradientInfo(
const B2DRange& rTargetRange,
sal_uInt32 nSteps,
double fBorder,
@@ -115,7 +115,7 @@ namespace basegfx
/** Most of the setup for radial & ellipsoidal gradient is the same,
except for the border treatment. Factored out here.
*/
- ODFGradientInfo initEllipticalGradientInfo(
+ static ODFGradientInfo initEllipticalGradientInfo(
const B2DRange& rTargetRange,
const B2DVector& rOffset,
sal_uInt32 nSteps,
@@ -184,7 +184,7 @@ namespace basegfx
/** Setup for rect & square gradient is exactly the same. Factored out
here.
*/
- ODFGradientInfo initRectGradientInfo(
+ static ODFGradientInfo initRectGradientInfo(
const B2DRange& rTargetRange,
const B2DVector& rOffset,
sal_uInt32 nSteps,
diff --git a/basegfx/source/tools/stringconversiontools.cxx b/basegfx/source/tools/stringconversiontools.cxx
index b14fce0fb557..6e48c22b1f89 100644
--- a/basegfx/source/tools/stringconversiontools.cxx
+++ b/basegfx/source/tools/stringconversiontools.cxx
@@ -35,7 +35,7 @@ namespace basegfx
}
}
- void skipSpacesAndCommas(sal_Int32& io_rPos,
+ static void skipSpacesAndCommas(sal_Int32& io_rPos,
const OUString& rStr,
const sal_Int32 nLen)
{
@@ -46,7 +46,7 @@ namespace basegfx
}
}
- bool getDoubleChar(double& o_fRetval,
+ static bool getDoubleChar(double& o_fRetval,
sal_Int32& io_rPos,
const OUString& rStr)
{
diff --git a/basegfx/test/boxclipper.cxx b/basegfx/test/boxclipper.cxx
index f155c6a73b34..49015b66deef 100644
--- a/basegfx/test/boxclipper.cxx
+++ b/basegfx/test/boxclipper.cxx
@@ -49,7 +49,7 @@ double getRandomOrdinal( const std::size_t n )
return comphelper::rng::uniform_size_distribution(0, n-1);
}
-inline bool compare(const B2DPoint& left, const B2DPoint& right)
+static inline bool compare(const B2DPoint& left, const B2DPoint& right)
{
return left.getX()<right.getX()
|| (rtl::math::approxEqual(left.getX(),right.getX()) && left.getY()<right.getY());
diff --git a/basic/source/basmgr/basmgr.cxx b/basic/source/basmgr/basmgr.cxx
index 08e13d857eae..c404b7b893c6 100644
--- a/basic/source/basmgr/basmgr.cxx
+++ b/basic/source/basmgr/basmgr.cxx
@@ -497,7 +497,7 @@ BasicManager::BasicManager( SotStorage& rStorage, const OUString& rBaseURL, Star
}
}
-void copyToLibraryContainer( StarBASIC* pBasic, const LibraryContainerInfo& rInfo )
+static void copyToLibraryContainer( StarBASIC* pBasic, const LibraryContainerInfo& rInfo )
{
uno::Reference< script::XLibraryContainer > xScriptCont( rInfo.mxScriptCont.get() );
if ( !xScriptCont.is() )
@@ -1771,7 +1771,7 @@ void ModuleContainer_Impl::removeByName( const OUString& Name )
}
-uno::Sequence< sal_Int8 > implGetDialogData( SbxObject* pDialog )
+static uno::Sequence< sal_Int8 > implGetDialogData( SbxObject* pDialog )
{
SvMemoryStream aMemStream;
pDialog->Store( aMemStream );
@@ -1784,7 +1784,7 @@ uno::Sequence< sal_Int8 > implGetDialogData( SbxObject* pDialog )
return aData;
}
-SbxObject* implCreateDialog( const uno::Sequence< sal_Int8 >& aData )
+static SbxObject* implCreateDialog( const uno::Sequence< sal_Int8 >& aData )
{
sal_Int8* pData = const_cast< uno::Sequence< sal_Int8 >& >(aData).getArray();
SvMemoryStream aMemStream( pData, aData.getLength(), StreamMode::READ );
diff --git a/basic/source/classes/image.cxx b/basic/source/classes/image.cxx
index a2a340a84eb4..28667187513e 100644
--- a/basic/source/classes/image.cxx
+++ b/basic/source/classes/image.cxx
@@ -68,13 +68,13 @@ void SbiImage::Clear()
bError = false;
}
-bool SbiGood( SvStream const & r )
+static bool SbiGood( SvStream const & r )
{
return r.good();
}
// Open Record
-sal_uInt64 SbiOpenRecord( SvStream& r, FileOffset nSignature, sal_uInt16 nElem )
+static sal_uInt64 SbiOpenRecord( SvStream& r, FileOffset nSignature, sal_uInt16 nElem )
{
sal_uInt64 nPos = r.Tell();
r.WriteUInt16( static_cast<sal_uInt16>( nSignature ) )
@@ -83,7 +83,7 @@ sal_uInt64 SbiOpenRecord( SvStream& r, FileOffset nSignature, sal_uInt16 nElem )
}
// Close Record
-void SbiCloseRecord( SvStream& r, sal_uInt64 nOff )
+static void SbiCloseRecord( SvStream& r, sal_uInt64 nOff )
{
sal_uInt64 nPos = r.Tell();
r.Seek( nOff + 2 );
diff --git a/basic/source/classes/sbunoobj.cxx b/basic/source/classes/sbunoobj.cxx
index a83bcd3c3961..3e9df83c4df7 100644
--- a/basic/source/classes/sbunoobj.cxx
+++ b/basic/source/classes/sbunoobj.cxx
@@ -160,14 +160,14 @@ void SetSbUnoObjectDfltPropName( SbxObject* pObj )
}
// save CoreReflection statically
-Reference< XIdlReflection > getCoreReflection_Impl()
+static Reference< XIdlReflection > getCoreReflection_Impl()
{
return css::reflection::theCoreReflection::get(
comphelper::getProcessComponentContext());
}
// save CoreReflection statically
-Reference< XHierarchicalNameAccess > const & getCoreReflection_HierarchicalNameAccess_Impl()
+static Reference< XHierarchicalNameAccess > const & getCoreReflection_HierarchicalNameAccess_Impl()
{
static Reference< XHierarchicalNameAccess > xCoreReflection_HierarchicalNameAccess;
@@ -184,7 +184,7 @@ Reference< XHierarchicalNameAccess > const & getCoreReflection_HierarchicalNameA
}
// Hold TypeProvider statically
-Reference< XHierarchicalNameAccess > const & getTypeProvider_Impl()
+static Reference< XHierarchicalNameAccess > const & getTypeProvider_Impl()
{
static Reference< XHierarchicalNameAccess > xAccess;
@@ -210,7 +210,7 @@ Reference< XHierarchicalNameAccess > const & getTypeProvider_Impl()
}
// Hold TypeConverter statically
-Reference< XTypeConverter > const & getTypeConverter_Impl()
+static Reference< XTypeConverter > const & getTypeConverter_Impl()
{
static Reference< XTypeConverter > xTypeConverter;
@@ -287,7 +287,7 @@ namespace
}
}
-void implAppendExceptionMsg( OUStringBuffer& _inout_rBuffer, const Exception& _e, const OUString& _rExceptionType, sal_Int32 _nLevel )
+static void implAppendExceptionMsg( OUStringBuffer& _inout_rBuffer, const Exception& _e, const OUString& _rExceptionType, sal_Int32 _nLevel )
{
_inout_rBuffer.append( "\n" );
lcl_indent( _inout_rBuffer, _nLevel );
@@ -306,14 +306,14 @@ void implAppendExceptionMsg( OUStringBuffer& _inout_rBuffer, const Exception& _e
}
// construct an error message for the exception
-OUString implGetExceptionMsg( const Exception& e, const OUString& aExceptionType_ )
+static OUString implGetExceptionMsg( const Exception& e, const OUString& aExceptionType_ )
{
OUStringBuffer aMessageBuf;
implAppendExceptionMsg( aMessageBuf, e, aExceptionType_, 0 );
return aMessageBuf.makeStringAndClear();
}
-OUString implGetExceptionMsg( const Any& _rCaughtException )
+static OUString implGetExceptionMsg( const Any& _rCaughtException )
{
auto e = o3tl::tryAccess<Exception>(_rCaughtException);
OSL_PRECOND( e, "implGetExceptionMsg: illegal argument!" );
@@ -324,7 +324,7 @@ OUString implGetExceptionMsg( const Any& _rCaughtException )
return implGetExceptionMsg( *e, _rCaughtException.getValueTypeName() );
}
-Any convertAny( const Any& rVal, const Type& aDestType )
+static Any convertAny( const Any& rVal, const Type& aDestType )
{
Any aConvertedVal;
Reference< XTypeConverter > xConverter = getTypeConverter_Impl();
@@ -352,25 +352,25 @@ Any convertAny( const Any& rVal, const Type& aDestType )
// TODO: source out later
-Reference<XIdlClass> TypeToIdlClass( const Type& rType )
+static Reference<XIdlClass> TypeToIdlClass( const Type& rType )
{
return getCoreReflection_Impl()->forName(rType.getTypeName());
}
// Exception type unknown
template< class EXCEPTION >
-OUString implGetExceptionMsg( const EXCEPTION& e )
+static OUString implGetExceptionMsg( const EXCEPTION& e )
{
return implGetExceptionMsg( e, cppu::UnoType<decltype(e)>::get().getTypeName() );
}
-void implHandleBasicErrorException( BasicErrorException const & e )
+static void implHandleBasicErrorException( BasicErrorException const & e )
{
ErrCode nError = StarBASIC::GetSfxFromVBError( static_cast<sal_uInt16>(e.ErrorCode) );
StarBASIC::Error( nError, e.ErrorMessageArgument );
}
-void implHandleWrappedTargetException( const Any& _rWrappedTargetException )
+static void implHandleWrappedTargetException( const Any& _rWrappedTargetException )
{
Any aExamine( _rWrappedTargetException );
@@ -477,7 +477,7 @@ static SbxObject* lcl_getNativeObject( sal_uInt32 nIndex )
}
// convert from Uno to Sbx
-SbxDataType unoToSbxType( TypeClass eType )
+static SbxDataType unoToSbxType( TypeClass eType )
{
SbxDataType eRetType = SbxVOID;
@@ -512,7 +512,7 @@ SbxDataType unoToSbxType( TypeClass eType )
return eRetType;
}
-SbxDataType unoToSbxType( const Reference< XIdlClass >& xIdlClass )
+static SbxDataType unoToSbxType( const Reference< XIdlClass >& xIdlClass )
{
SbxDataType eRetType = SbxVOID;
if( xIdlClass.is() )
@@ -812,7 +812,7 @@ void unoToSbxValue( SbxVariable* pVar, const Any& aValue )
}
// Deliver the reflection for Sbx types
-Type getUnoTypeForSbxBaseType( SbxDataType eType )
+static Type getUnoTypeForSbxBaseType( SbxDataType eType )
{
Type aRetType = cppu::UnoType<void>::get();
switch( eType )
@@ -848,7 +848,7 @@ Type getUnoTypeForSbxBaseType( SbxDataType eType )
}
// Converting of Sbx to Uno without a know target class for TypeClass_ANY
-Type getUnoTypeForSbxValue( const SbxValue* pVal )
+static Type getUnoTypeForSbxValue( const SbxValue* pVal )
{
Type aRetType = cppu::UnoType<void>::get();
if( !pVal )
@@ -973,7 +973,7 @@ Type getUnoTypeForSbxValue( const SbxValue* pVal )
}
// converting of Sbx to Uno without known target class for TypeClass_ANY
-Any sbxToUnoValueImpl( const SbxValue* pVar, bool bBlockConversionToSmallestType = false )
+static Any sbxToUnoValueImpl( const SbxValue* pVar, bool bBlockConversionToSmallestType = false )
{
SbxDataType eBaseType = pVar->SbxValue::GetType();
if( eBaseType == SbxOBJECT )
@@ -1449,7 +1449,7 @@ Any sbxToUnoValue( const SbxValue* pVar, const Type& rType, Property const * pUn
return aRetVal;
}
-void processAutomationParams( SbxArray* pParams, Sequence< Any >& args, sal_uInt32 nParamCount )
+static void processAutomationParams( SbxArray* pParams, Sequence< Any >& args, sal_uInt32 nParamCount )
{
AutomationNamedArgsSbxArray* pArgNamesArray = dynamic_cast<AutomationNamedArgsSbxArray*>( pParams );
@@ -1498,7 +1498,7 @@ enum class INVOKETYPE
GetProp = 0,
Func
};
-Any invokeAutomationMethod( const OUString& Name, Sequence< Any > const & args, SbxArray* pParams, sal_uInt32 nParamCount, Reference< XInvocation > const & rxInvocation, INVOKETYPE invokeType )
+static Any invokeAutomationMethod( const OUString& Name, Sequence< Any > const & args, SbxArray* pParams, sal_uInt32 nParamCount, Reference< XInvocation > const & rxInvocation, INVOKETYPE invokeType )
{
Sequence< sal_Int16 > OutParamIndex;
Sequence< Any > OutParam;
@@ -1536,7 +1536,7 @@ Any invokeAutomationMethod( const OUString& Name, Sequence< Any > const & args,
}
// Debugging help method to readout the imlemented interfaces of an object
-OUString Impl_GetInterfaceInfo( const Reference< XInterface >& x, const Reference< XIdlClass >& xClass, sal_uInt16 nRekLevel )
+static OUString Impl_GetInterfaceInfo( const Reference< XInterface >& x, const Reference< XIdlClass >& xClass, sal_uInt16 nRekLevel )
{
Type aIfaceType = cppu::UnoType<XInterface>::get();
static Reference< XIdlClass > xIfaceClass = TypeToIdlClass( aIfaceType );
@@ -1572,7 +1572,7 @@ OUString Impl_GetInterfaceInfo( const Reference< XInterface >& x, const Referenc
return aRetStr.makeStringAndClear();
}
-OUString getDbgObjectNameImpl(SbUnoObject& rUnoObj)
+static OUString getDbgObjectNameImpl(SbUnoObject& rUnoObj)
{
OUString aName = rUnoObj.GetClassName();
if( aName.isEmpty() )
@@ -1589,7 +1589,7 @@ OUString getDbgObjectNameImpl(SbUnoObject& rUnoObj)
return aName;
}
-OUString getDbgObjectName(SbUnoObject& rUnoObj)
+static OUString getDbgObjectName(SbUnoObject& rUnoObj)
{
OUString aName = getDbgObjectNameImpl(rUnoObj);
if( aName.isEmpty() )
@@ -1711,7 +1711,7 @@ bool checkUnoObjectType(SbUnoObject& rUnoObj, const OUString& rClass)
}
// Debugging help method to readout the imlemented interfaces of an object
-OUString Impl_GetSupportedInterfaces(SbUnoObject& rUnoObj)
+static OUString Impl_GetSupportedInterfaces(SbUnoObject& rUnoObj)
{
Any aToInspectObj = rUnoObj.getUnoAny();
@@ -1762,7 +1762,7 @@ OUString Impl_GetSupportedInterfaces(SbUnoObject& rUnoObj)
// Debugging help method SbxDataType -> String
-OUString Dbg_SbxDataType2String( SbxDataType eType )
+static OUString Dbg_SbxDataType2String( SbxDataType eType )
{
OUStringBuffer aRet;
switch( +eType )
@@ -1806,7 +1806,7 @@ OUString Dbg_SbxDataType2String( SbxDataType eType )
}
// Debugging help method to display the properties of a SbUnoObjects
-OUString Impl_DumpProperties(SbUnoObject& rUnoObj)
+static OUString Impl_DumpProperties(SbUnoObject& rUnoObj)
{
OUStringBuffer aRet;
aRet.append("Properties of object ");
@@ -1883,7 +1883,7 @@ OUString Impl_DumpProperties(SbUnoObject& rUnoObj)
}
// Debugging help method to display the methods of an SbUnoObjects
-OUString Impl_DumpMethods(SbUnoObject& rUnoObj)
+static OUString Impl_DumpMethods(SbUnoObject& rUnoObj)
{
OUStringBuffer aRet;
aRet.append("Methods of object ");
@@ -2826,7 +2826,7 @@ Any SbUnoObject::getUnoAny()
}
// help method to create an Uno-Struct per CoreReflection
-SbUnoObject* Impl_CreateUnoStruct( const OUString& aClassName )
+static SbUnoObject* Impl_CreateUnoStruct( const OUString& aClassName )
{
// get CoreReflection
Reference< XIdlReflection > xCoreReflection = getCoreReflection_Impl();
@@ -3181,7 +3181,7 @@ void RTL_Impl_EqualUnoObjects( SbxArray& rPar )
// if it fails for whatever reason
// returned Reference<> be null e.g. .is() will be false
-Reference< XTypeDescriptionEnumeration > getTypeDescriptorEnumeration( const OUString& sSearchRoot,
+static Reference< XTypeDescriptionEnumeration > getTypeDescriptorEnumeration( const OUString& sSearchRoot,
const Sequence< TypeClass >& types,
TypeDescriptionSearchDepth depth )
{
@@ -3893,7 +3893,7 @@ private:
// Function to replace AllListenerAdapterService::createAllListerAdapter
-Reference< XInterface > createAllListenerAdapter
+static Reference< XInterface > createAllListenerAdapter
(
const Reference< XInvocationAdapterFactory2 >& xInvocationAdapterFactory,
const Reference< XIdlClass >& xListenerType,
diff --git a/basic/source/classes/sbxmod.cxx b/basic/source/classes/sbxmod.cxx
index 559c1649337f..c9663ef08bd0 100644
--- a/basic/source/classes/sbxmod.cxx
+++ b/basic/source/classes/sbxmod.cxx
@@ -395,7 +395,7 @@ uno::Reference< frame::XModel > getDocumentModel( StarBASIC* pb )
return xModel;
}
-uno::Reference< vba::XVBACompatibility > getVBACompatibility( const uno::Reference< frame::XModel >& rxModel )
+static uno::Reference< vba::XVBACompatibility > getVBACompatibility( const uno::Reference< frame::XModel >& rxModel )
{
uno::Reference< vba::XVBACompatibility > xVBACompat;
try
@@ -409,7 +409,7 @@ uno::Reference< vba::XVBACompatibility > getVBACompatibility( const uno::Referen
return xVBACompat;
}
-bool getDefaultVBAMode( StarBASIC* pb )
+static bool getDefaultVBAMode( StarBASIC* pb )
{
uno::Reference< frame::XModel > xModel( getDocumentModel( pb ) );
if (!xModel.is())
@@ -929,7 +929,7 @@ static void SendHint( SbxObject* pObj, SfxHintId nId, SbMethod* p )
// #57841 Clear Uno-Objects, which were helt in RTL functions,
// at the end of the program, so that nothing were helt.
-void ClearUnoObjectsInRTL_Impl_Rek( StarBASIC* pBasic )
+static void ClearUnoObjectsInRTL_Impl_Rek( StarBASIC* pBasic )
{
// delete the return value of CreateUnoService
SbxVariable* pVar = pBasic->GetRtl()->Find( "CreateUnoService", SbxClassType::Method );
@@ -969,7 +969,7 @@ void ClearUnoObjectsInRTL_Impl_Rek( StarBASIC* pBasic )
}
}
-void ClearUnoObjectsInRTL_Impl( StarBASIC* pBasic )
+static void ClearUnoObjectsInRTL_Impl( StarBASIC* pBasic )
{
// #67781 Delete return values of the Uno-methods
clearUnoMethods();
diff --git a/basic/source/comp/parser.cxx b/basic/source/comp/parser.cxx
index 553f9707a060..caca02573343 100644
--- a/basic/source/comp/parser.cxx
+++ b/basic/source/comp/parser.cxx
@@ -830,7 +830,7 @@ void SbiParser::Option()
}
}
-void addStringConst( SbiSymPool& rPool, const OUString& pSym, const OUString& rStr )
+static void addStringConst( SbiSymPool& rPool, const OUString& pSym, const OUString& rStr )
{
SbiConstDef* pConst = new SbiConstDef( pSym );
pConst->SetType( SbxSTRING );
diff --git a/basic/source/runtime/methods.cxx b/basic/source/runtime/methods.cxx
index b9bdbec05748..629e3728980c 100644
--- a/basic/source/runtime/methods.cxx
+++ b/basic/source/runtime/methods.cxx
@@ -327,7 +327,7 @@ void SbRtl_Asc(StarBASIC *, SbxArray & rPar, bool)
}
}
-void implChr( SbxArray& rPar, bool bChrW )
+static void implChr( SbxArray& rPar, bool bChrW )
{
if ( rPar.Count() < 2 )
{
@@ -631,7 +631,7 @@ void SbRtl_MkDir(StarBASIC * pBasic, SbxArray & rPar, bool bWrite)
// In OSL only empty directories can be deleted
// so we have to delete all files recursively
-void implRemoveDirRecursive( const OUString& aDirPath )
+static void implRemoveDirRecursive( const OUString& aDirPath )
{
DirectoryItem aItem;
FileBase::RC nRet = DirectoryItem::get( aDirPath, aItem );
@@ -2521,7 +2521,7 @@ void SbRtl_IsMissing(StarBASIC *, SbxArray & rPar, bool)
}
// Function looks for wildcards, removes them and always returns the pure path
-OUString implSetupWildcard( const OUString& rFileParam, SbiRTLData* pRTLData )
+static OUString implSetupWildcard( const OUString& rFileParam, SbiRTLData* pRTLData )
{
static sal_Char cDelim1 = '/';
static sal_Char cDelim2 = '\\';
@@ -2587,7 +2587,7 @@ OUString implSetupWildcard( const OUString& rFileParam, SbiRTLData* pRTLData )
return aPathStr;
}
-inline bool implCheckWildcard( const OUString& rName, SbiRTLData const * pRTLData )
+static inline bool implCheckWildcard( const OUString& rName, SbiRTLData const * pRTLData )
{
bool bMatch = true;
@@ -2599,7 +2599,7 @@ inline bool implCheckWildcard( const OUString& rName, SbiRTLData const * pRTLDat
}
-bool isRootDir( const OUString& aDirURLStr )
+static bool isRootDir( const OUString& aDirURLStr )
{
INetURLObject aDirURLObj( aDirURLStr );
bool bRoot = false;
@@ -3725,7 +3725,7 @@ OUString getBasicTypeName( SbxDataType eType )
return OUString::createFromAscii(pTypeNames[nPos]);
}
-OUString getObjectTypeName( SbxVariable* pVar )
+static OUString getObjectTypeName( SbxVariable* pVar )
{
OUString sRet( "Object" );
if ( pVar )
diff --git a/basic/source/runtime/methods1.cxx b/basic/source/runtime/methods1.cxx
index 7f5ab0233096..514c8e1e85b0 100644
--- a/basic/source/runtime/methods1.cxx
+++ b/basic/source/runtime/methods1.cxx
@@ -1127,7 +1127,7 @@ static bool lcl_WriteReadSbxArray( SbxDimArray& rArr, SvStream* pStrm,
return true;
}
-void PutGet( SbxArray& rPar, bool bPut )
+static void PutGet( SbxArray& rPar, bool bPut )
{
if ( rPar.Count() != 4 )
{
@@ -1802,7 +1802,7 @@ struct IntervalInfo
bool mbSimple;
};
-IntervalInfo const * getIntervalInfo( const OUString& rStringCode )
+static IntervalInfo const * getIntervalInfo( const OUString& rStringCode )
{
static IntervalInfo const aIntervalTable[] =
{
@@ -1828,7 +1828,7 @@ IntervalInfo const * getIntervalInfo( const OUString& rStringCode )
return nullptr;
}
-inline void implGetDayMonthYear( sal_Int16& rnYear, sal_Int16& rnMonth, sal_Int16& rnDay, double dDate )
+static inline void implGetDayMonthYear( sal_Int16& rnYear, sal_Int16& rnMonth, sal_Int16& rnDay, double dDate )
{
rnDay = implGetDateDay( dDate );
rnMonth = implGetDateMonth( dDate );
@@ -1840,7 +1840,7 @@ inline void implGetDayMonthYear( sal_Int16& rnYear, sal_Int16& rnMonth, sal_Int1
@return the year number, truncated if necessary and in that case also
rMonth and rDay adjusted.
*/
-inline sal_Int16 limitDate( sal_Int32 n32Year, sal_Int16& rMonth, sal_Int16& rDay )
+static inline sal_Int16 limitDate( sal_Int32 n32Year, sal_Int16& rMonth, sal_Int16& rDay )
{
if( n32Year > SAL_MAX_INT16 )
{
@@ -1957,7 +1957,7 @@ void SbRtl_DateAdd(StarBASIC *, SbxArray & rPar, bool)
rPar.Get(0)->PutDate( dNewDate );
}
-inline double RoundImpl( double d )
+static inline double RoundImpl( double d )
{
return ( d >= 0 ) ? floor( d + 0.5 ) : -floor( -d + 0.5 );
}
@@ -2087,7 +2087,7 @@ void SbRtl_DateDiff(StarBASIC *, SbxArray & rPar, bool)
rPar.Get(0)->PutDouble( dRet );
}
-double implGetDateOfFirstDayInFirstWeek
+static double implGetDateOfFirstDayInFirstWeek
( sal_Int16 nYear, sal_Int16& nFirstDay, sal_Int16& nFirstWeek, bool* pbError = nullptr )
{
ErrCode nError = ERRCODE_NONE;
@@ -2438,7 +2438,7 @@ void SbRtl_Round(StarBASIC *, SbxArray & rPar, bool)
rPar.Get(0)->PutDouble( dRes );
}
-void CallFunctionAccessFunction( const Sequence< Any >& aArgs, const OUString& sFuncName, SbxVariable* pRet )
+static void CallFunctionAccessFunction( const Sequence< Any >& aArgs, const OUString& sFuncName, SbxVariable* pRet )
{
static Reference< XFunctionAccess > xFunc;
try
diff --git a/basic/source/runtime/runtime.cxx b/basic/source/runtime/runtime.cxx
index eb94a927be03..b8d16c79578e 100644
--- a/basic/source/runtime/runtime.cxx
+++ b/basic/source/runtime/runtime.cxx
@@ -1568,7 +1568,7 @@ void SbiRuntime::StepGET()
}
// #67607 copy Uno-Structs
-inline bool checkUnoStructCopy( bool bVBA, SbxVariableRef const & refVal, SbxVariableRef const & refVar )
+static inline bool checkUnoStructCopy( bool bVBA, SbxVariableRef const & refVal, SbxVariableRef const & refVar )
{
SbxDataType eVarType = refVar->GetType();
SbxDataType eValType = refVal->GetType();
@@ -2155,7 +2155,7 @@ void SbiRuntime::StepREDIM()
// Helper function for StepREDIMP
-void implCopyDimArray( SbxDimArray* pNewArray, SbxDimArray* pOldArray, short nMaxDimIndex,
+static void implCopyDimArray( SbxDimArray* pNewArray, SbxDimArray* pOldArray, short nMaxDimIndex,
short nActualDim, sal_Int32* pActualIndices, sal_Int32* pLowerBounds, sal_Int32* pUpperBounds )
{
sal_Int32& ri = pActualIndices[nActualDim];
@@ -4282,7 +4282,7 @@ void SbiRuntime::StepDCREATE_REDIMP( sal_uInt32 nOp1, sal_uInt32 nOp2 )
// Helper function for StepDCREATE_IMPL / bRedimp = true
-void implCopyDimArray_DCREATE( SbxDimArray* pNewArray, SbxDimArray* pOldArray, short nMaxDimIndex,
+static void implCopyDimArray_DCREATE( SbxDimArray* pNewArray, SbxDimArray* pOldArray, short nMaxDimIndex,
short nActualDim, sal_Int32* pActualIndices, sal_Int32* pLowerBounds, sal_Int32* pUpperBounds )
{
sal_Int32& ri = pActualIndices[nActualDim];
diff --git a/basic/source/sbx/sbxform.cxx b/basic/source/sbx/sbxform.cxx
index 6e61a9af0ae3..69d917ae3a1f 100644
--- a/basic/source/sbx/sbxform.cxx
+++ b/basic/source/sbx/sbxform.cxx
@@ -80,7 +80,7 @@ COMMENT: Visual-Basic treats the following (invalid) format-strings
// be generated. That's a StarBasic 'extension'.
-double get_number_of_digits( double dNumber )
+static double get_number_of_digits( double dNumber )
//double floor_log10_fabs( double dNumber )
{
if( dNumber==0.0 )
diff --git a/basic/source/sbx/sbxscan.cxx b/basic/source/sbx/sbxscan.cxx
index 081d5b4735a5..97c52b174ed0 100644
--- a/basic/source/sbx/sbxscan.cxx
+++ b/basic/source/sbx/sbxscan.cxx
@@ -66,7 +66,7 @@ void ImpGetIntntlSep( sal_Unicode& rcDecimalSep, sal_Unicode& rcThousandSep, sal
terminating NULL character to be part of the string and returns bool
instead of pointer, if character is 0 returns false.
*/
-bool ImpStrChr( const sal_Unicode* p, sal_Unicode c )
+static bool ImpStrChr( const sal_Unicode* p, sal_Unicode c )
{
if (!c)
return false;
diff --git a/basic/source/uno/dlgcont.cxx b/basic/source/uno/dlgcont.cxx
index 8757f01df6a9..7165a99b4fc0 100644
--- a/basic/source/uno/dlgcont.cxx
+++ b/basic/source/uno/dlgcont.cxx
@@ -111,7 +111,7 @@ bool SfxDialogLibraryContainer::isLibraryElementValid(const Any& rElement) const
return SfxDialogLibrary::containsValidDialog(rElement);
}
-bool writeOasis2OOoLibraryElement(
+static bool writeOasis2OOoLibraryElement(
const Reference< XInputStream >& xInput, const Reference< XOutputStream >& xOutput )
{
Reference< XComponentContext > xContext(
diff --git a/basic/source/uno/scriptcont.cxx b/basic/source/uno/scriptcont.cxx
index f72ad68c518e..520318c92e54 100644
--- a/basic/source/uno/scriptcont.cxx
+++ b/basic/source/uno/scriptcont.cxx
@@ -534,7 +534,7 @@ void SAL_CALL SfxScriptLibraryContainer::changeLibraryPassword( const OUString&
}
-void setStreamKey( const uno::Reference< io::XStream >& xStream, const OUString& aPass )
+static void setStreamKey( const uno::Reference< io::XStream >& xStream, const OUString& aPass )
{
uno::Reference< embed::XEncryptionProtectedSource > xEncrStream( xStream, uno::UNO_QUERY );
if ( xEncrStream.is() )
diff --git a/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx b/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx
index 12148904f9fd..6e860ea257ac 100644
--- a/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx
+++ b/bridges/source/cpp_uno/gcc3_linux_x86-64/cpp2uno.cxx
@@ -400,7 +400,7 @@ const int codeSnippetSize = 24;
// Note: The code snippet we build here must not create a stack frame,
// otherwise the UNO exceptions stop working thanks to non-existing
// unwinding info.
-unsigned char * codeSnippet( unsigned char * code,
+static unsigned char * codeSnippet( unsigned char * code,
sal_Int32 nFunctionIndex, sal_Int32 nVtableOffset,
bool bHasHiddenParam )
{
diff --git a/bridges/source/jni_uno/jni_bridge.cxx b/bridges/source/jni_uno/jni_bridge.cxx
index 7f38d3221420..6ff327a1eb06 100644
--- a/bridges/source/jni_uno/jni_bridge.cxx
+++ b/bridges/source/jni_uno/jni_bridge.cxx
@@ -422,7 +422,7 @@ using namespace ::jni_uno;
extern "C" {
-void java_env_dispose(uno_Environment * env) {
+static void java_env_dispose(uno_Environment * env) {
auto * envData
= static_cast<jni_uno::JniUnoEnvironmentData *>(env->pContext);
if (envData != nullptr) {
@@ -456,7 +456,7 @@ void java_env_dispose(uno_Environment * env) {
}
}
-void java_env_disposing(uno_Environment * env) {
+static void java_env_disposing(uno_Environment * env) {
java_env_dispose(env);
delete static_cast<jni_uno::JniUnoEnvironmentData *>(env->pContext);
}
diff --git a/bridges/source/jni_uno/jni_data.cxx b/bridges/source/jni_uno/jni_data.cxx
index ac86fd391e4f..ebe2ce48cc1d 100644
--- a/bridges/source/jni_uno/jni_data.cxx
+++ b/bridges/source/jni_uno/jni_data.cxx
@@ -31,7 +31,7 @@ namespace jni_uno
{
-inline std::unique_ptr<rtl_mem> seq_allocate(
+static inline std::unique_ptr<rtl_mem> seq_allocate(
sal_Int32 nElements, sal_Int32 nSize )
{
std::unique_ptr< rtl_mem > seq(
diff --git a/canvas/source/cairo/cairo_canvashelper_text.cxx b/canvas/source/cairo/cairo_canvashelper_text.cxx
index b0d07f87cdbe..e7ce4131b251 100644
--- a/canvas/source/cairo/cairo_canvashelper_text.cxx
+++ b/canvas/source/cairo/cairo_canvashelper_text.cxx
@@ -165,7 +165,7 @@ namespace cairocanvas
}
};
- bool setupTextOutput( OutputDevice& rOutDev,
+ static bool setupTextOutput( OutputDevice& rOutDev,
const rendering::XCanvas* pOwner,
::Point& o_rOutPos,
const rendering::ViewState& viewState,
diff --git a/canvas/source/tools/spriteredrawmanager.cxx b/canvas/source/tools/spriteredrawmanager.cxx
index 08621b11700e..f24ef41caf53 100644
--- a/canvas/source/tools/spriteredrawmanager.cxx
+++ b/canvas/source/tools/spriteredrawmanager.cxx
@@ -301,7 +301,7 @@ namespace canvas
}
#if OSL_DEBUG_LEVEL > 0
- bool impIsEqualB2DRange(const basegfx::B2DRange& rRangeA, const basegfx::B2DRange& rRangeB, double fSmallValue)
+ static bool impIsEqualB2DRange(const basegfx::B2DRange& rRangeA, const basegfx::B2DRange& rRangeB, double fSmallValue)
{
return fabs(rRangeB.getMinX() - rRangeA.getMinX()) <= fSmallValue
&& fabs(rRangeB.getMinY() - rRangeA.getMinY()) <= fSmallValue
@@ -309,7 +309,7 @@ namespace canvas
&& fabs(rRangeB.getMaxY() - rRangeA.getMaxY()) <= fSmallValue;
}
- bool impIsEqualB2DVector(const basegfx::B2DVector& rVecA, const basegfx::B2DVector& rVecB, double fSmallValue)
+ static bool impIsEqualB2DVector(const basegfx::B2DVector& rVecA, const basegfx::B2DVector& rVecB, double fSmallValue)
{
return fabs(rVecB.getX() - rVecA.getX()) <= fSmallValue
&& fabs(rVecB.getY() - rVecA.getY()) <= fSmallValue;
diff --git a/chart2/qa/extras/chart2import.cxx b/chart2/qa/extras/chart2import.cxx
index 787760578bc1..590cd377c937 100644
--- a/chart2/qa/extras/chart2import.cxx
+++ b/chart2/qa/extras/chart2import.cxx
@@ -181,7 +181,7 @@ private:
};
-uno::Reference<drawing::XShape>
+static uno::Reference<drawing::XShape>
getShapeByName(const uno::Reference<drawing::XShapes>& rShapes, const OUString& rName,
const std::function<bool(const uno::Reference<drawing::XShape>&)>& pCondition
= nullptr)
@@ -348,7 +348,7 @@ void Chart2ImportTest::testSteppedLines()
}
}
-uno::Sequence < OUString > getChartColumnDescriptions( uno::Reference< chart::XChartDocument > const & xChart1Doc)
+static uno::Sequence < OUString > getChartColumnDescriptions( uno::Reference< chart::XChartDocument > const & xChart1Doc)
{
CPPUNIT_ASSERT(xChart1Doc.is());
uno::Reference< chart::XChartDataArray > xChartData ( xChart1Doc->getData(), UNO_QUERY_THROW);
diff --git a/chart2/source/controller/dialogs/res_Trendline.cxx b/chart2/source/controller/dialogs/res_Trendline.cxx
index a28a9da7f311..f75ce892183e 100644
--- a/chart2/source/controller/dialogs/res_Trendline.cxx
+++ b/chart2/source/controller/dialogs/res_Trendline.cxx
@@ -32,7 +32,7 @@
namespace chart
{
-void lcl_setValue( FormattedField& rFmtField, double fValue )
+static void lcl_setValue( FormattedField& rFmtField, double fValue )
{
rFmtField.SetValue( fValue );
rFmtField.SetDefaultValue( fValue );
diff --git a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
index ed1f69d808d2..5768c108a8c9 100644
--- a/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
+++ b/chart2/source/controller/itemsetwrapper/AxisItemConverter.cxx
@@ -147,7 +147,7 @@ bool AxisItemConverter::GetItemProperty( tWhichIdType nWhichId, tPropertyNameWit
return true;
}
-bool lcl_hasTimeIntervalValue( const uno::Any& rAny )
+static bool lcl_hasTimeIntervalValue( const uno::Any& rAny )
{
bool bRet = false;
TimeInterval aValue;
@@ -439,19 +439,19 @@ void AxisItemConverter::FillSpecialItem( sal_uInt16 nWhichId, SfxItemSet & rOutI
}
}
-bool lcl_isDateAxis( const SfxItemSet & rItemSet )
+static bool lcl_isDateAxis( const SfxItemSet & rItemSet )
{
sal_Int32 nAxisType = rItemSet.Get( SCHATTR_AXISTYPE ).GetValue();//css::chart2::AxisType
return (nAxisType == chart2::AxisType::DATE);
}
-bool lcl_isAutoMajor( const SfxItemSet & rItemSet )
+static bool lcl_isAutoMajor( const SfxItemSet & rItemSet )
{
bool bRet = rItemSet.Get( SCHATTR_AXIS_AUTO_STEP_MAIN ).GetValue();
return bRet;
}
-bool lcl_isAutoMinor( const SfxItemSet & rItemSet )
+static bool lcl_isAutoMinor( const SfxItemSet & rItemSet )
{
bool bRet = rItemSet.Get( SCHATTR_AXIS_AUTO_STEP_HELP ).GetValue();
return bRet;
diff --git a/chart2/source/controller/main/ChartController_Position.cxx b/chart2/source/controller/main/ChartController_Position.cxx
index 31576ed554d9..37e832977dfb 100644
--- a/chart2/source/controller/main/ChartController_Position.cxx
+++ b/chart2/source/controller/main/ChartController_Position.cxx
@@ -45,7 +45,7 @@ namespace chart
using namespace ::com::sun::star;
using namespace ::com::sun::star::chart2;
-void lcl_getPositionAndSizeFromItemSet( const SfxItemSet& rItemSet, awt::Rectangle& rPosAndSize, const awt::Size& rOriginalSize )
+static void lcl_getPositionAndSizeFromItemSet( const SfxItemSet& rItemSet, awt::Rectangle& rPosAndSize, const awt::Size& rOriginalSize )
{
long nPosX(0);
long nPosY(0);
diff --git a/chart2/source/controller/main/ChartController_Window.cxx b/chart2/source/controller/main/ChartController_Window.cxx
index f7e4a415290a..5e307d7a409b 100644
--- a/chart2/source/controller/main/ChartController_Window.cxx
+++ b/chart2/source/controller/main/ChartController_Window.cxx
@@ -494,7 +494,7 @@ void ChartController::execute_Paint(vcl::RenderContext& rRenderContext, const to
}
}
-bool isDoubleClick( const MouseEvent& rMEvt )
+static bool isDoubleClick( const MouseEvent& rMEvt )
{
return rMEvt.GetClicks() == 2 && rMEvt.IsLeft() &&
!rMEvt.IsMod1() && !rMEvt.IsMod2() && !rMEvt.IsShift();
diff --git a/chart2/source/controller/main/DrawCommandDispatch.cxx b/chart2/source/controller/main/DrawCommandDispatch.cxx
index dc6f6f16bf21..73bcc680ff1f 100644
--- a/chart2/source/controller/main/DrawCommandDispatch.cxx
+++ b/chart2/source/controller/main/DrawCommandDispatch.cxx
@@ -74,7 +74,7 @@ bool DrawCommandDispatch::isFeatureSupported( const OUString& rCommandURL )
return parseCommandURL( rCommandURL, &nFeatureId, &aBaseCommand, &aCustomShapeType );
}
-::basegfx::B2DPolyPolygon getPolygon(const char* pResId, const SdrModel& rModel)
+static ::basegfx::B2DPolyPolygon getPolygon(const char* pResId, const SdrModel& rModel)
{
::basegfx::B2DPolyPolygon aReturn;
XLineEndListRef pLineEndList = rModel.GetLineEndList();
diff --git a/chart2/source/controller/main/ElementSelector.cxx b/chart2/source/controller/main/ElementSelector.cxx
index f10ae63f92af..3b9b861f1e27 100644
--- a/chart2/source/controller/main/ElementSelector.cxx
+++ b/chart2/source/controller/main/ElementSelector.cxx
@@ -56,7 +56,7 @@ SelectorListBox::SelectorListBox( vcl::Window* pParent, WinBits nStyle )
{
}
-void lcl_addObjectsToList( const ObjectHierarchy& rHierarchy, const ObjectIdentifier & rParent, std::vector< ListBoxEntryData >& rEntries
+static void lcl_addObjectsToList( const ObjectHierarchy& rHierarchy, const ObjectIdentifier & rParent, std::vector< ListBoxEntryData >& rEntries
, const sal_Int32 nHierarchyDepth, const Reference< chart2::XChartDocument >& xChartDoc )
{
ObjectHierarchy::tChildContainer aChildren( rHierarchy.getChildren(rParent) );
diff --git a/chart2/source/tools/DiagramHelper.cxx b/chart2/source/tools/DiagramHelper.cxx
index 5c8c534fb496..faaf3c1a4fdd 100644
--- a/chart2/source/tools/DiagramHelper.cxx
+++ b/chart2/source/tools/DiagramHelper.cxx
@@ -926,7 +926,7 @@ Reference< data::XLabeledDataSequence >
return xResult;
}
-void lcl_generateAutomaticCategoriesFromChartType(
+static void lcl_generateAutomaticCategoriesFromChartType(
Sequence< OUString >& rRet,
const Reference< XChartType >& xChartType )
{
@@ -1598,7 +1598,7 @@ DiagramPositioningMode DiagramHelper::getDiagramPositioningMode( const uno::Refe
return eMode;
}
-void lcl_ensureRange0to1( double& rValue )
+static void lcl_ensureRange0to1( double& rValue )
{
if(rValue<0.0)
rValue=0.0;
diff --git a/chart2/source/tools/ExplicitCategoriesProvider.cxx b/chart2/source/tools/ExplicitCategoriesProvider.cxx
index ced3f5204b10..835f5243488e 100644
--- a/chart2/source/tools/ExplicitCategoriesProvider.cxx
+++ b/chart2/source/tools/ExplicitCategoriesProvider.cxx
@@ -152,7 +152,7 @@ sal_Int32 ExplicitCategoriesProvider::getCategoryLevelCount() const
return nCount;
}
-std::vector<sal_Int32> lcl_getLimitingBorders( const std::vector< ComplexCategory >& rComplexCategories )
+static std::vector<sal_Int32> lcl_getLimitingBorders( const std::vector< ComplexCategory >& rComplexCategories )
{
std::vector<sal_Int32> aLimitingBorders;
sal_Int32 nBorderIndex = 0; /*border below the index*/
@@ -250,7 +250,7 @@ uno::Sequence< OUString > SplitCategoriesProvider_ForLabeledDataSequences::getSt
return aRet;
}
-std::vector< ComplexCategory > lcl_DataSequenceToComplexCategoryVector(
+static std::vector< ComplexCategory > lcl_DataSequenceToComplexCategoryVector(
const uno::Sequence< OUString >& rStrings
, const std::vector<sal_Int32>& rLimitingBorders, bool bCreateSingleCategories )
{
@@ -290,7 +290,7 @@ std::vector< ComplexCategory > lcl_DataSequenceToComplexCategoryVector(
return aResult;
}
-sal_Int32 lcl_getCategoryCount( std::vector< ComplexCategory >& rComplexCategories )
+static sal_Int32 lcl_getCategoryCount( std::vector< ComplexCategory >& rComplexCategories )
{
sal_Int32 nCount = 0;
for (auto const& complexCategory : rComplexCategories)
@@ -298,7 +298,7 @@ sal_Int32 lcl_getCategoryCount( std::vector< ComplexCategory >& rComplexCategori
return nCount;
}
-Sequence< OUString > lcl_getExplicitSimpleCategories(
+static Sequence< OUString > lcl_getExplicitSimpleCategories(
const SplitCategoriesProvider& rSplitCategoriesProvider,
std::vector< std::vector< ComplexCategory > >& rComplexCats )
{
@@ -383,7 +383,7 @@ Sequence< OUString > ExplicitCategoriesProvider::getExplicitSimpleCategories(
return lcl_getExplicitSimpleCategories( rSplitCategoriesProvider, aComplexCats );
}
-bool lcl_fillDateCategories( const uno::Reference< data::XDataSequence >& xDataSequence, std::vector< double >& rDateCategories, bool bIsAutoDate, ChartModel& rModel )
+static bool lcl_fillDateCategories( const uno::Reference< data::XDataSequence >& xDataSequence, std::vector< double >& rDateCategories, bool bIsAutoDate, ChartModel& rModel )
{
bool bOnlyDatesFound = true;
bool bAnyDataFound = false;
diff --git a/chart2/source/view/axes/ScaleAutomatism.cxx b/chart2/source/view/axes/ScaleAutomatism.cxx
index e6f2d4d0192f..5a72a875168b 100644
--- a/chart2/source/view/axes/ScaleAutomatism.cxx
+++ b/chart2/source/view/axes/ScaleAutomatism.cxx
@@ -40,7 +40,7 @@ using ::com::sun::star::chart::TimeUnit::YEAR;
const sal_Int32 MAXIMUM_MANUAL_INCREMENT_COUNT = 500;
const sal_Int32 MAXIMUM_SUB_INCREMENT_COUNT = 100;
-sal_Int32 lcl_getMaximumAutoIncrementCount( sal_Int32 nAxisType )
+static sal_Int32 lcl_getMaximumAutoIncrementCount( sal_Int32 nAxisType )
{
sal_Int32 nMaximumAutoIncrementCount = 10;
if( nAxisType==AxisType::DATE )
diff --git a/chart2/source/view/axes/VAxisProperties.cxx b/chart2/source/view/axes/VAxisProperties.cxx
index c2385db62631..fd16b851412b 100644
--- a/chart2/source/view/axes/VAxisProperties.cxx
+++ b/chart2/source/view/axes/VAxisProperties.cxx
@@ -43,7 +43,7 @@ AxisLabelAlignment::AxisLabelAlignment() :
mfInnerTickDirection(1.0),
meAlignment(LABEL_ALIGN_RIGHT_TOP) {}
-sal_Int32 lcl_calcTickLengthForDepth(sal_Int32 nDepth,sal_Int32 nTickmarkStyle)
+static sal_Int32 lcl_calcTickLengthForDepth(sal_Int32 nDepth,sal_Int32 nTickmarkStyle)
{
sal_Int32 const nWidth = AXIS2D_TICKLENGTH; //@maybefuturetodo this length could be offered by the model
double fPercent = 1.0;
@@ -67,7 +67,7 @@ sal_Int32 lcl_calcTickLengthForDepth(sal_Int32 nDepth,sal_Int32 nTickmarkStyle)
return static_cast<sal_Int32>(nWidth*fPercent);
}
-double lcl_getTickOffset(sal_Int32 nLength,sal_Int32 nTickmarkStyle)
+static double lcl_getTickOffset(sal_Int32 nLength,sal_Int32 nTickmarkStyle)
{
double fPercent = 0.0; //0<=fPercent<=1
//0.0: completely inner
@@ -180,7 +180,7 @@ AxisProperties::AxisProperties( const uno::Reference< XAxis >& xAxisModel
{
}
-LabelAlignment lcl_getLabelAlignmentForZAxis( const AxisProperties& rAxisProperties )
+static LabelAlignment lcl_getLabelAlignmentForZAxis( const AxisProperties& rAxisProperties )
{
LabelAlignment aRet( LABEL_ALIGN_RIGHT );
if (rAxisProperties.maLabelAlignment.mfLabelDirection < 0)
@@ -188,7 +188,7 @@ LabelAlignment lcl_getLabelAlignmentForZAxis( const AxisProperties& rAxisPropert
return aRet;
}
-LabelAlignment lcl_getLabelAlignmentForYAxis( const AxisProperties& rAxisProperties )
+static LabelAlignment lcl_getLabelAlignmentForYAxis( const AxisProperties& rAxisProperties )
{
LabelAlignment aRet( LABEL_ALIGN_RIGHT );
if (rAxisProperties.maLabelAlignment.mfLabelDirection < 0)
@@ -196,7 +196,7 @@ LabelAlignment lcl_getLabelAlignmentForYAxis( const AxisProperties& rAxisPropert
return aRet;
}
-LabelAlignment lcl_getLabelAlignmentForXAxis( const AxisProperties& rAxisProperties )
+static LabelAlignment lcl_getLabelAlignmentForXAxis( const AxisProperties& rAxisProperties )
{
LabelAlignment aRet( LABEL_ALIGN_BOTTOM );
if (rAxisProperties.maLabelAlignment.mfLabelDirection < 0)
diff --git a/chart2/source/view/axes/VCartesianAxis.cxx b/chart2/source/view/axes/VCartesianAxis.cxx
index a047f7239b59..c6f59216593e 100644
--- a/chart2/source/view/axes/VCartesianAxis.cxx
+++ b/chart2/source/view/axes/VCartesianAxis.cxx
@@ -76,7 +76,7 @@ VCartesianAxis::~VCartesianAxis()
m_pPosHelper = nullptr;
}
-void lcl_ResizeTextShapeToFitAvailableSpace( Reference< drawing::XShape > const & xShape2DText,
+static void lcl_ResizeTextShapeToFitAvailableSpace( Reference< drawing::XShape > const & xShape2DText,
const AxisLabelProperties& rAxisLabelProperties,
const OUString& rLabel,
const tNameSequence& rPropNames,
@@ -123,7 +123,7 @@ void lcl_ResizeTextShapeToFitAvailableSpace( Reference< drawing::XShape > const
}
}
-Reference< drawing::XShape > createSingleLabel(
+static Reference< drawing::XShape > createSingleLabel(
const Reference< lang::XMultiServiceFactory>& xShapeFactory
, const Reference< drawing::XShapes >& xTarget
, const awt::Point& rAnchorScreenPosition2D
@@ -154,7 +154,7 @@ Reference< drawing::XShape > createSingleLabel(
return xShape2DText;
}
-bool lcl_doesShapeOverlapWithTickmark( const Reference< drawing::XShape >& xShape
+static bool lcl_doesShapeOverlapWithTickmark( const Reference< drawing::XShape >& xShape
, double fRotationAngleDegree
, const basegfx::B2DVector& rTickScreenPosition )
{
@@ -169,7 +169,7 @@ bool lcl_doesShapeOverlapWithTickmark( const Reference< drawing::XShape >& xShap
return aShapeRect.isInside(aPosition);
}
-void lcl_getRotatedPolygon( B2DPolygon &aPoly, const ::basegfx::B2DRectangle &aRect, const awt::Point &aPos, const double fRotationAngleDegree )
+static void lcl_getRotatedPolygon( B2DPolygon &aPoly, const ::basegfx::B2DRectangle &aRect, const awt::Point &aPos, const double fRotationAngleDegree )
{
aPoly = basegfx::utils::createPolygonFromRect( aRect );
@@ -189,7 +189,7 @@ void lcl_getRotatedPolygon( B2DPolygon &aPoly, const ::basegfx::B2DRectangle &aR
aPoly.transform( aMatrix );
}
-bool doesOverlap( const Reference< drawing::XShape >& xShape1
+static bool doesOverlap( const Reference< drawing::XShape >& xShape1
, const Reference< drawing::XShape >& xShape2
, double fRotationAngleDegree )
{
@@ -212,7 +212,7 @@ bool doesOverlap( const Reference< drawing::XShape >& xShape1
return (overlapPoly.count() > 0);
}
-void removeShapesAtWrongRhythm( TickIter& rIter
+static void removeShapesAtWrongRhythm( TickIter& rIter
, sal_Int32 nCorrectRhythm
, sal_Int32 nMaxTickToCheck
, const Reference< drawing::XShapes >& xTarget )
@@ -309,7 +309,7 @@ TickInfo* LabelIterator::nextInfo()
return pTickInfo;
}
-B2DVector lcl_getLabelsDistance( TickIter& rIter, const B2DVector& rDistanceTickToText, double fRotationAngleDegree )
+static B2DVector lcl_getLabelsDistance( TickIter& rIter, const B2DVector& rDistanceTickToText, double fRotationAngleDegree )
{
//calculates the height or width of a line of labels
//thus a following line of labels can be shifted for that distance
@@ -349,7 +349,7 @@ B2DVector lcl_getLabelsDistance( TickIter& rIter, const B2DVector& rDistanceTick
return aRet;
}
-void lcl_shiftLabels( TickIter& rIter, const B2DVector& rStaggerDistance )
+static void lcl_shiftLabels( TickIter& rIter, const B2DVector& rStaggerDistance )
{
if(rStaggerDistance.getLength()==0.0)
return;
@@ -369,7 +369,7 @@ void lcl_shiftLabels( TickIter& rIter, const B2DVector& rStaggerDistance )
}
}
-bool lcl_hasWordBreak( const Reference<drawing::XShape>& xShape )
+static bool lcl_hasWordBreak( const Reference<drawing::XShape>& xShape )
{
if (!xShape.is())
return false;
@@ -411,7 +411,7 @@ bool lcl_hasWordBreak( const Reference<drawing::XShape>& xShape )
return false;
}
-OUString getTextLabelString(
+static OUString getTextLabelString(
const FixedNumberFormatter& rFixedNumberFormatter, const uno::Sequence<OUString>* pCategories,
const TickInfo* pTickInfo, bool bComplexCat, Color& rExtraColor, bool& rHasExtraColor )
{
@@ -435,7 +435,7 @@ OUString getTextLabelString(
return rFixedNumberFormatter.getFormattedString(pTickInfo->getUnscaledTickValue(), rExtraColor, rHasExtraColor);
}
-void getAxisLabelProperties(
+static void getAxisLabelProperties(
tNameSequence& rPropNames, tAnySequence& rPropValues, const AxisProperties& rAxisProp,
const AxisLabelProperties& rAxisLabelProp,
sal_Int32 nLimitedSpaceForText, bool bLimitedHeight )
@@ -1475,7 +1475,7 @@ TickFactory2D* VCartesianAxis::createTickFactory2D()
return new TickFactory2D( m_aScale, m_aIncrement, aStart, aEnd, aLabelLineStart-aStart );
}
-void lcl_hideIdenticalScreenValues( TickIter& rTickIter )
+static void lcl_hideIdenticalScreenValues( TickIter& rTickIter )
{
TickInfo* pPrevTickInfo = rTickIter.firstInfo();
if (!pPrevTickInfo)
diff --git a/chart2/source/view/axes/VCartesianGrid.cxx b/chart2/source/view/axes/VCartesianGrid.cxx
index a9df579ac353..df74eeeaf05d 100644
--- a/chart2/source/view/axes/VCartesianGrid.cxx
+++ b/chart2/source/view/axes/VCartesianGrid.cxx
@@ -135,7 +135,7 @@ void GridLinePoints::update( double fScaledTickValue )
P0[m_nDimensionIndex] = P1[m_nDimensionIndex] = P2[m_nDimensionIndex] = fScaledTickValue;
}
-void addLine2D( drawing::PointSequenceSequence& rPoints, sal_Int32 nIndex
+static void addLine2D( drawing::PointSequenceSequence& rPoints, sal_Int32 nIndex
, const GridLinePoints& rScaledLogicPoints
, const Reference< XTransformation > & xTransformation
)
@@ -150,7 +150,7 @@ void addLine2D( drawing::PointSequenceSequence& rPoints, sal_Int32 nIndex
rPoints[nIndex][1].Y = static_cast<sal_Int32>(aPB.PositionY);
}
-void addLine3D( drawing::PolyPolygonShape3D& rPoints, sal_Int32 nIndex
+static void addLine3D( drawing::PolyPolygonShape3D& rPoints, sal_Int32 nIndex
, const GridLinePoints& rBasePoints
, const Reference< XTransformation > & xTransformation )
{
diff --git a/chart2/source/view/charttypes/AreaChart.cxx b/chart2/source/view/charttypes/AreaChart.cxx
index 58acc66a749c..005d7c4afba8 100644
--- a/chart2/source/view/charttypes/AreaChart.cxx
+++ b/chart2/source/view/charttypes/AreaChart.cxx
@@ -162,7 +162,7 @@ void AreaChart::addSeries( std::unique_ptr<VDataSeries> pSeries, sal_Int32 zSlot
VSeriesPlotter::addSeries( std::move(pSeries), zSlot, xSlot, ySlot );
}
-void lcl_removeDuplicatePoints( drawing::PolyPolygonShape3D& rPolyPoly, PlottingPositionHelper& rPosHelper )
+static void lcl_removeDuplicatePoints( drawing::PolyPolygonShape3D& rPolyPoly, PlottingPositionHelper& rPosHelper )
{
sal_Int32 nPolyCount = rPolyPoly.SequenceX.getLength();
if(!nPolyCount)
diff --git a/chart2/source/view/charttypes/BarChart.cxx b/chart2/source/view/charttypes/BarChart.cxx
index 3d9aae4bf942..f265f27171fe 100644
--- a/chart2/source/view/charttypes/BarChart.cxx
+++ b/chart2/source/view/charttypes/BarChart.cxx
@@ -432,7 +432,7 @@ void BarChart::adaptOverlapAndGapwidthForGroupBarsPerAxis()
}
}
-E3dScene* lcl_getE3dScene(uno::Reference<uno::XInterface> const & xInterface)
+static E3dScene* lcl_getE3dScene(uno::Reference<uno::XInterface> const & xInterface)
{
E3dScene* pScene = nullptr;
diff --git a/chart2/source/view/charttypes/VSeriesPlotter.cxx b/chart2/source/view/charttypes/VSeriesPlotter.cxx
index 4b4602af7589..8eab6c1694b1 100644
--- a/chart2/source/view/charttypes/VSeriesPlotter.cxx
+++ b/chart2/source/view/charttypes/VSeriesPlotter.cxx
@@ -1273,7 +1273,7 @@ void VSeriesPlotter::createRegressionCurvesShapes( VDataSeries const & rVDataSer
}
}
-sal_Int32 lcl_getOUStringMaxLineLength ( OUStringBuffer const & aString )
+static sal_Int32 lcl_getOUStringMaxLineLength ( OUStringBuffer const & aString )
{
const sal_Int32 nStringLength = aString.getLength();
sal_Int32 nMaxLineLength = 0;
diff --git a/chart2/source/view/diagram/VDiagram.cxx b/chart2/source/view/diagram/VDiagram.cxx
index 29a33b248a46..2a72cfbd57dd 100644
--- a/chart2/source/view/diagram/VDiagram.cxx
+++ b/chart2/source/view/diagram/VDiagram.cxx
@@ -206,7 +206,7 @@ void VDiagram::createShapes_2d()
adjustPosAndSize_2d( m_aAvailablePosIncludingAxes, m_aAvailableSizeIncludingAxes );
}
-E3dScene* lcl_getE3dScene( const uno::Reference< drawing::XShape >& xShape )
+static E3dScene* lcl_getE3dScene( const uno::Reference< drawing::XShape >& xShape )
{
E3dScene* pRet=nullptr;
uno::Reference< lang::XUnoTunnel > xUnoTunnel( xShape, uno::UNO_QUERY );
@@ -223,7 +223,7 @@ E3dScene* lcl_getE3dScene( const uno::Reference< drawing::XShape >& xShape )
return pRet;
}
-void lcl_setLightSources(
+static void lcl_setLightSources(
const uno::Reference< beans::XPropertySet > & xSource,
const uno::Reference< beans::XPropertySet > & xDest )
{
diff --git a/chart2/source/view/main/ChartView.cxx b/chart2/source/view/main/ChartView.cxx
index f53fd6b39549..50a619dce5f4 100644
--- a/chart2/source/view/main/ChartView.cxx
+++ b/chart2/source/view/main/ChartView.cxx
@@ -1280,7 +1280,7 @@ css::uno::Sequence< OUString > SAL_CALL ChartView::getSupportedServiceNames()
return { CHART_VIEW_SERVICE_NAME };
}
-::basegfx::B3DHomMatrix createTransformationSceneToScreen(
+static ::basegfx::B3DHomMatrix createTransformationSceneToScreen(
const ::basegfx::B2IRectangle& rDiagramRectangleWithoutAxes )
{
::basegfx::B3DHomMatrix aM;
diff --git a/chart2/source/view/main/LabelPositionHelper.cxx b/chart2/source/view/main/LabelPositionHelper.cxx
index 377acbff4966..9b36d1435cf3 100644
--- a/chart2/source/view/main/LabelPositionHelper.cxx
+++ b/chart2/source/view/main/LabelPositionHelper.cxx
@@ -80,7 +80,7 @@ void LabelPositionHelper::changeTextAdjustment( tAnySequence& rPropValues, const
}
}
-void lcl_doDynamicFontResize( uno::Any* pAOldAndNewFontHeightAny
+static void lcl_doDynamicFontResize( uno::Any* pAOldAndNewFontHeightAny
, const awt::Size& rOldReferenceSize
, const awt::Size& rNewReferenceSize )
{
diff --git a/chart2/source/view/main/ShapeFactory.cxx b/chart2/source/view/main/ShapeFactory.cxx
index c545cc99ebf3..e9a9e6d5df11 100644
--- a/chart2/source/view/main/ShapeFactory.cxx
+++ b/chart2/source/view/main/ShapeFactory.cxx
@@ -111,7 +111,7 @@ void ShapeFactory::setPageSize(const uno::Reference<drawing::XShapes>&, const aw
// diverse tools::PolyPolygon create methods
-uno::Any createPolyPolygon_Cube(
+static uno::Any createPolyPolygon_Cube(
const drawing::Direction3D& rSize, double fRoundedEdge, bool bRounded )
{
OSL_PRECOND(fRoundedEdge>=0, "fRoundedEdge needs to be >= 0");
@@ -200,7 +200,7 @@ uno::Any createPolyPolygon_Cube(
return uno::Any( &aPP, cppu::UnoType<drawing::PolyPolygonShape3D>::get());
}
-uno::Any createPolyPolygon_Cylinder(
+static uno::Any createPolyPolygon_Cylinder(
double fHeight
, double fRadius
, sal_Int32& nVerticalSegmentCount )
@@ -282,7 +282,7 @@ uno::Any createPolyPolygon_Cylinder(
return uno::Any( &aPP, cppu::UnoType<drawing::PolyPolygonShape3D>::get());
}
-uno::Any createPolyPolygon_Cone( double fHeight, double fRadius, double fTopHeight
+static uno::Any createPolyPolygon_Cone( double fHeight, double fRadius, double fTopHeight
, sal_Int32& nVerticalSegmentCount )
{
OSL_PRECOND(fRadius>0, "The radius of a cone needs to be > 0");
@@ -706,7 +706,7 @@ uno::Reference<drawing::XShape>
return xShape;
}
-void appendAndCloseBezierCoords( drawing::PolyPolygonBezierCoords& rReturn, const drawing::PolyPolygonBezierCoords& rAdd, bool bAppendInverse )
+static void appendAndCloseBezierCoords( drawing::PolyPolygonBezierCoords& rReturn, const drawing::PolyPolygonBezierCoords& rAdd, bool bAppendInverse )
{
if(!rAdd.Coordinates.getLength())
return;
@@ -731,7 +731,7 @@ void appendAndCloseBezierCoords( drawing::PolyPolygonBezierCoords& rReturn, cons
rReturn.Flags[0][nOldCount+nAddCount] = rReturn.Flags[0][0];
}
-drawing::PolyPolygonBezierCoords getCircularArcBezierCoords(
+static drawing::PolyPolygonBezierCoords getCircularArcBezierCoords(
double fStartAngleRadian, double fWidthAngleRadian, double fUnitRadius
, const ::basegfx::B2DHomMatrix& rTransformationFromUnitCircle
, const double fAngleSubdivisionRadian )
@@ -842,7 +842,7 @@ drawing::PolyPolygonBezierCoords getCircularArcBezierCoords(
return aReturn;
}
-drawing::PolyPolygonBezierCoords getRingBezierCoords(
+static drawing::PolyPolygonBezierCoords getRingBezierCoords(
double fUnitCircleInnerRadius
, double fUnitCircleOuterRadius
, double fStartAngleRadian, double fWidthAngleRadian
@@ -1156,7 +1156,7 @@ uno::Reference< drawing::XShape >
return xShape;
}
-drawing::PolyPolygonShape3D createPolyPolygon_Symbol( const drawing::Position3D& rPos
+static drawing::PolyPolygonShape3D createPolyPolygon_Symbol( const drawing::Position3D& rPos
, const drawing::Direction3D& rSize
, sal_Int32 nStandardSymbol )
{
diff --git a/chart2/source/view/main/VDataSeries.cxx b/chart2/source/view/main/VDataSeries.cxx
index 34532c8a824f..20d7ab778ee9 100644
--- a/chart2/source/view/main/VDataSeries.cxx
+++ b/chart2/source/view/main/VDataSeries.cxx
@@ -766,7 +766,7 @@ double VDataSeries::getYMeanValue() const
return m_fYMeanValue;
}
-std::unique_ptr<Symbol> getSymbolPropertiesFromPropertySet( const uno::Reference< beans::XPropertySet >& xProp )
+static std::unique_ptr<Symbol> getSymbolPropertiesFromPropertySet( const uno::Reference< beans::XPropertySet >& xProp )
{
std::unique_ptr< Symbol > apSymbolProps( new Symbol() );
try
@@ -912,7 +912,7 @@ uno::Reference<beans::XPropertySet> VDataSeries::getPropertiesOfSeries() const
return uno::Reference<css::beans::XPropertySet>(m_xDataSeries, css::uno::UNO_QUERY);
}
-std::unique_ptr<DataPointLabel> getDataPointLabelFromPropertySet( const uno::Reference< beans::XPropertySet >& xProp )
+static std::unique_ptr<DataPointLabel> getDataPointLabelFromPropertySet( const uno::Reference< beans::XPropertySet >& xProp )
{
std::unique_ptr< DataPointLabel > apLabel( new DataPointLabel() );
try
diff --git a/codemaker/source/codemaker/global.cxx b/codemaker/source/codemaker/global.cxx
index daf031d7728d..8eb506e10e51 100644
--- a/codemaker/source/codemaker/global.cxx
+++ b/codemaker/source/codemaker/global.cxx
@@ -156,7 +156,7 @@ bool fileExists(const OString& fileName)
return false;
}
-bool checkFileContent(const OString& targetFileName, const OString& tmpFileName)
+static bool checkFileContent(const OString& targetFileName, const OString& tmpFileName)
{
FILE *target = fopen(targetFileName.getStr(), "r");
FILE *tmp = fopen(tmpFileName.getStr(), "r");
diff --git a/comphelper/source/misc/base64.cxx b/comphelper/source/misc/base64.cxx
index 4e3a6bc6ef00..8fd02f120f8f 100644
--- a/comphelper/source/misc/base64.cxx
+++ b/comphelper/source/misc/base64.cxx
@@ -60,7 +60,7 @@ const
// p q r s t u v w x y z
-void ThreeByteToFourByte(const sal_Int8* pBuffer, const sal_Int32 nStart, const sal_Int32 nFullLen, sal_Char* aCharBuffer)
+static void ThreeByteToFourByte(const sal_Int8* pBuffer, const sal_Int32 nStart, const sal_Int32 nFullLen, sal_Char* aCharBuffer)
{
sal_Int32 nLen(nFullLen - nStart);
if (nLen > 3)
diff --git a/comphelper/source/misc/mimeconfighelper.cxx b/comphelper/source/misc/mimeconfighelper.cxx
index c027bc1ff00f..8a4b002f7d77 100644
--- a/comphelper/source/misc/mimeconfighelper.cxx
+++ b/comphelper/source/misc/mimeconfighelper.cxx
@@ -66,7 +66,7 @@ OUString MimeConfigurationHelper::GetStringClassIDRepresentation( const uno::Seq
}
-sal_uInt8 GetDigit_Impl( sal_Char aChar )
+static sal_uInt8 GetDigit_Impl( sal_Char aChar )
{
if ( aChar >= '0' && aChar <= '9' )
return aChar - '0';
diff --git a/comphelper/source/misc/syntaxhighlight.cxx b/comphelper/source/misc/syntaxhighlight.cxx
index 76c8dfa862d3..3fb5bc057094 100644
--- a/comphelper/source/misc/syntaxhighlight.cxx
+++ b/comphelper/source/misc/syntaxhighlight.cxx
@@ -246,11 +246,14 @@ static const char* strListSqlKeyWords[] = {
};
-extern "C" int compare_strings( const void *arg1, const void *arg2 )
+extern "C" {
+
+static int compare_strings( const void *arg1, const void *arg2 )
{
return strcmp( static_cast<char const *>(arg1), *static_cast<char * const *>(arg2) );
}
+}
namespace
{
diff --git a/comphelper/source/processfactory/processfactory.cxx b/comphelper/source/processfactory/processfactory.cxx
index 211067a5e75f..f3654a243ca9 100644
--- a/comphelper/source/processfactory/processfactory.cxx
+++ b/comphelper/source/processfactory/processfactory.cxx
@@ -36,7 +36,7 @@ namespace comphelper
This function preserves only that the xProcessFactory variable will not be create when
the library is loaded.
*/
-Reference< XMultiServiceFactory > localProcessFactory( const Reference< XMultiServiceFactory >& xSMgr, bool bSet )
+static Reference< XMultiServiceFactory > localProcessFactory( const Reference< XMultiServiceFactory >& xSMgr, bool bSet )
{
Guard< Mutex > aGuard( Mutex::getGlobalMutex() );
diff --git a/comphelper/source/streaming/seekableinput.cxx b/comphelper/source/streaming/seekableinput.cxx
index d7f107eae72d..89d887ea3548 100644
--- a/comphelper/source/streaming/seekableinput.cxx
+++ b/comphelper/source/streaming/seekableinput.cxx
@@ -35,7 +35,7 @@ namespace comphelper
const sal_Int32 nConstBufferSize = 32000;
-void copyInputToOutput_Impl( const uno::Reference< io::XInputStream >& xIn,
+static void copyInputToOutput_Impl( const uno::Reference< io::XInputStream >& xIn,
const uno::Reference< io::XOutputStream >& xOut )
{
sal_Int32 nRead;
diff --git a/compilerplugins/clang/external.cxx b/compilerplugins/clang/external.cxx
new file mode 100644
index 000000000000..bb4bcbf36d08
--- /dev/null
+++ b/compilerplugins/clang/external.cxx
@@ -0,0 +1,323 @@
+/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4; fill-column: 100 -*- */
+/*
+ * This file is part of the LibreOffice project.
+ *
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/.
+ */
+
+#include <algorithm>
+#include <cassert>
+
+#include "clang/Sema/SemaDiagnostic.h"
+
+#include "check.hxx"
+#include "plugin.hxx"
+
+namespace
+{
+// It appears that, given a function declaration, there is no way to determine
+// the language linkage of the function's type, only of the function's name
+// (via FunctionDecl::isExternC); however, in a case like
+//
+// extern "C" { static void f(); }
+//
+// the function's name does not have C language linkage while the function's
+// type does (as clarified in C++11 [decl.link]); cf. <http://clang-developers.
+// 42468.n3.nabble.com/Language-linkage-of-function-type-tt4037248.html>
+// "Language linkage of function type":
+bool hasCLanguageLinkageType(FunctionDecl const* decl)
+{
+ assert(decl != nullptr);
+ if (decl->isExternC())
+ {
+ return true;
+ }
+ if (decl->isInExternCContext())
+ {
+ return true;
+ }
+ return false;
+}
+
+bool derivesFromTestFixture(CXXRecordDecl const* decl)
+{
+ static auto const pred = [](CXXBaseSpecifier const& spec) {
+ if (auto const t = spec.getType()->getAs<RecordType>())
+ { // (may be a template parameter)
+ return derivesFromTestFixture(dyn_cast<CXXRecordDecl>(t->getDecl()));
+ }
+ return false;
+ };
+ return loplugin::DeclCheck(decl).Class("TestFixture").Namespace("CppUnit").GlobalNamespace()
+ || std::any_of(decl->bases_begin(), decl->bases_end(), pred)
+ || std::any_of(decl->vbases_begin(), decl->vbases_end(), pred);
+}
+
+class External : public loplugin::FilteringPlugin<External>
+{
+public:
+ explicit External(loplugin::InstantiationData const& data)
+ : FilteringPlugin(data)
+ {
+ }
+
+ void run() override { TraverseDecl(compiler.getASTContext().getTranslationUnitDecl()); }
+
+ bool VisitTagDecl(TagDecl const* decl)
+ {
+ /*TODO:*/
+ return true; // in general, moving classes or enumerations into an unnamed namespace can break ADL
+ if (isa<ClassTemplateSpecializationDecl>(decl))
+ {
+ return true;
+ }
+ if (!decl->isThisDeclarationADefinition())
+ {
+ return true;
+ }
+ if (isa<CXXRecordDecl>(decl->getDeclContext()))
+ {
+ return true;
+ }
+ if (!compiler.getLangOpts().CPlusPlus)
+ {
+ return true;
+ }
+ if (auto const d = dyn_cast<CXXRecordDecl>(decl))
+ {
+ if (d->getDescribedClassTemplate() != nullptr)
+ {
+ return true;
+ }
+ if (auto const attr = d->getAttr<VisibilityAttr>())
+ {
+ if (attr->getVisibility() == VisibilityAttr::Default)
+ {
+ // If the class definition has explicit default visibility, then assume that it
+ // needs to be present (e.g., a backwards-compatibility stub like in
+ // cppuhelper/source/compat.cxx):
+ return true;
+ }
+ }
+ if (derivesFromTestFixture(d))
+ {
+ // The names of CppUnit tests (that can be specified with CPPUNIT_TEST_NAME) are
+ // tied to the fully-qualified names of classes derived from CppUnit::TestFixture,
+ // so avoid unnamed namespaces in those classes' names:
+ return true;
+ }
+ }
+ return handleDeclaration(decl);
+ }
+
+ bool VisitFunctionDecl(FunctionDecl const* decl)
+ {
+ if (isa<CXXMethodDecl>(decl))
+ {
+ return true;
+ }
+ if (decl->getTemplatedKind() != FunctionDecl::TK_NonTemplate)
+ {
+ return true;
+ }
+ if (!decl->isThisDeclarationADefinition())
+ {
+ return true;
+ }
+ if (decl->isMain())
+ {
+ return true;
+ }
+ if (auto const attr = decl->getAttr<VisibilityAttr>())
+ {
+ if (attr->getVisibility() == VisibilityAttr::Default)
+ {
+ // If the function definition has explicit default visibility, then assume that it
+ // needs to be present (e.g., only called via dlopen, or a backwards-compatibility
+ // stub like in sal/osl/all/compat.cxx):
+ return true;
+ }
+ }
+ auto const canon = decl->getCanonicalDecl();
+ if (hasCLanguageLinkageType(canon)
+ && (canon->hasAttr<ConstructorAttr>() || canon->hasAttr<DestructorAttr>()))
+ {
+ return true;
+ }
+ if (compiler.getDiagnostics().getDiagnosticLevel(diag::warn_unused_function,
+ decl->getLocation())
+ < DiagnosticsEngine::Warning)
+ {
+ // Don't warn about e.g.
+ //
+ // G_DEFINE_TYPE (GLOAction, g_lo_action, G_TYPE_OBJECT);
+ //
+ // in vcl/unx/gtk/gloactiongroup.cxx (which expands to non-static g_lo_action_get_type
+ // function definition), which is already wrapped in
+ //
+ // #pragma GCC diagnostic ignored "-Wunused-function"
+ return true;
+ }
+ return handleDeclaration(decl);
+ }
+
+ bool VisitVarDecl(VarDecl const* decl)
+ {
+ if (decl->isStaticDataMember())
+ {
+ return true;
+ }
+ if (isa<VarTemplateSpecializationDecl>(decl))
+ {
+ return true;
+ }
+ if (!decl->isThisDeclarationADefinition())
+ {
+ return true;
+ }
+ return handleDeclaration(decl);
+ }
+
+ bool VisitClassTemplateDecl(ClassTemplateDecl const* decl)
+ {
+ /*TODO:*/
+ return true; // in general, moving classes or enumerations into an unnamed namespace can break ADL
+ if (!decl->isThisDeclarationADefinition())
+ {
+ return true;
+ }
+ if (isa<CXXRecordDecl>(decl->getDeclContext()))
+ {
+ return true;
+ }
+ return handleDeclaration(decl);
+ }
+
+ bool VisitFunctionTemplateDecl(FunctionTemplateDecl const* decl)
+ {
+ if (!decl->isThisDeclarationADefinition())
+ {
+ return true;
+ }
+ if (isa<CXXRecordDecl>(decl->getDeclContext()))
+ {
+ return true;
+ }
+ return handleDeclaration(decl);
+ }
+
+ bool VisitVarTemplateDecl(VarTemplateDecl const* decl)
+ {
+ if (!decl->isThisDeclarationADefinition())
+ {
+ return true;
+ }
+ return handleDeclaration(decl);
+ }
+
+private:
+ template <typename T> void reportSpecializations(T specializations)
+ {
+ for (auto const d : specializations)
+ {
+ auto const k = d->getTemplateSpecializationKind();
+ if (isTemplateExplicitInstantiationOrSpecialization(k))
+ {
+ report(DiagnosticsEngine::Note,
+ "explicit %select{instantiation|specialization}0 is here", d->getLocation())
+ << (k == TSK_ExplicitSpecialization) << d->getSourceRange();
+ }
+ }
+ }
+
+ bool handleDeclaration(NamedDecl const* decl)
+ {
+ if (ignoreLocation(decl))
+ {
+ return true;
+ }
+ if (decl->getLinkageInternal() <
+#if CLANG_VERSION >= 40000
+ ModuleLinkage
+#else
+ ExternalLinkage
+#endif
+ )
+ {
+ return true;
+ }
+ //TODO: in some cases getLinkageInternal() appears to report ExternalLinkage instead of
+ // UniqueExternalLinkage:
+ if (decl->isInAnonymousNamespace())
+ {
+ return true;
+ }
+ for (Decl const* d = decl; d != nullptr; d = d->getPreviousDecl())
+ {
+ if (!compiler.getSourceManager().isInMainFile(d->getLocation()))
+ {
+ return true;
+ }
+ }
+ if (compiler.getSourceManager().isMacroBodyExpansion(decl->getLocation())
+ && (Lexer::getImmediateMacroName(decl->getLocation(), compiler.getSourceManager(),
+ compiler.getLangOpts())
+ == "MDDS_MTV_DEFINE_ELEMENT_CALLBACKS"))
+ {
+ // Even wrapping in an unnamed namespace or sneaking "static" into the macro wouldn't
+ // help, as then some of the functions it defines would be flagged as unused:
+ return true;
+ }
+ TypedefNameDecl const* typedefed = nullptr;
+ if (auto const d = dyn_cast<TagDecl>(decl))
+ {
+ typedefed = d->getTypedefNameForAnonDecl();
+ }
+ bool canStatic;
+ if (auto const d = dyn_cast<CXXRecordDecl>(decl))
+ {
+ canStatic = d->isUnion() && d->isAnonymousStructOrUnion();
+ }
+ else
+ {
+ canStatic = isa<FunctionDecl>(decl) || isa<VarDecl>(decl)
+ || isa<FunctionTemplateDecl>(decl) || isa<VarTemplateDecl>(decl);
+ }
+ auto const canUnnamed = compiler.getLangOpts().CPlusPlus
+ && !(isa<FunctionDecl>(decl) || isa<FunctionTemplateDecl>(decl));
+ // in general, moving functions into an unnamed namespace can break ADL
+ assert(canStatic || canUnnamed);
+ report(
+ DiagnosticsEngine::Warning,
+ ("externally available%select{| typedef'ed}0 entity %1 is not previously declared in an"
+ " included file (if it is only used in this translation unit,"
+ " %select{|make it static}2%select{| or }3%select{|put it in an unnamed namespace}4;"
+ " otherwise, provide a declaration of it in an included file)"),
+ decl->getLocation())
+ << (typedefed != nullptr) << (typedefed == nullptr ? decl : typedefed) << canStatic
+ << (canStatic && canUnnamed) << canUnnamed << decl->getSourceRange();
+ for (auto d = decl->getPreviousDecl(); d != nullptr; d = d->getPreviousDecl())
+ {
+ report(DiagnosticsEngine::Note, "previous declaration is here", d->getLocation())
+ << d->getSourceRange();
+ }
+ //TODO: Class template specializations can be in the enclosing namespace, so no need to
+ // list them here (as they won't need to be put into the unnamed namespace too, unlike for
+ // specializations of function and variable templates); and explicit function template
+ // specializations cannot have storage-class specifiers, so as we only suggest to make
+ // function templates static (but not to move them into an unnamed namespace), no need to
+ // list function template specializations here, either:
+ if (auto const d = dyn_cast<VarTemplateDecl>(decl))
+ {
+ reportSpecializations(d->specializations());
+ }
+ return true;
+ }
+};
+
+loplugin::Plugin::Registration<External> X("external");
+}
+
+/* vim:set shiftwidth=4 softtabstop=4 expandtab cinoptions=b1,g0,N-s cinkeys+=0=break: */
diff --git a/connectivity/source/commontools/CommonTools.cxx b/connectivity/source/commontools/CommonTools.cxx
index 51d449ad1bb0..61e14b44aee3 100644
--- a/connectivity/source/commontools/CommonTools.cxx
+++ b/connectivity/source/commontools/CommonTools.cxx
@@ -36,7 +36,7 @@
#include <rtl/process.h>
using namespace ::comphelper;
-inline sal_Unicode rtl_ascii_toUpperCase( sal_Unicode ch )
+static inline sal_Unicode rtl_ascii_toUpperCase( sal_Unicode ch )
{
return ch >= 0x0061 && ch <= 0x007a ? ch + 0x20 : ch;
}
@@ -168,7 +168,7 @@ namespace connectivity
namespace dbtools
{
-bool isCharOk(sal_Unicode c,const OUString& _rSpecials)
+static bool isCharOk(sal_Unicode c,const OUString& _rSpecials)
{
return ( ((c >= 97) && (c <= 122)) || ((c >= 65) && (c <= 90)) || ((c >= 48) && (c <= 57)) ||
diff --git a/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx b/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx
index bef6e6c5584f..95bae62bed1e 100644
--- a/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx
+++ b/connectivity/source/commontools/FDatabaseMetaDataResultSet.cxx
@@ -871,7 +871,7 @@ void SAL_CALL ODatabaseMetaDataResultSet::initialize( const Sequence< Any >& _aA
namespace connectivity
{
/// @throws Exception
- Reference< XInterface > ODatabaseMetaDataResultSet_CreateInstance(const Reference< XComponentContext >& )
+ static Reference< XInterface > ODatabaseMetaDataResultSet_CreateInstance(const Reference< XComponentContext >& )
{
return *(new ODatabaseMetaDataResultSet());
}
diff --git a/connectivity/source/commontools/TKeys.cxx b/connectivity/source/commontools/TKeys.cxx
index 81479b491d92..293a0dab4ccf 100644
--- a/connectivity/source/commontools/TKeys.cxx
+++ b/connectivity/source/commontools/TKeys.cxx
@@ -79,7 +79,7 @@ Reference< XPropertySet > OKeysHelper::createDescriptor()
/** returns the keyrule string for the primary key
*/
-OUString getKeyRuleString(bool _bUpdate,sal_Int32 _nKeyRule)
+static OUString getKeyRuleString(bool _bUpdate,sal_Int32 _nKeyRule)
{
const char* pKeyRule = nullptr;
switch ( _nKeyRule )
diff --git a/connectivity/source/commontools/TTableHelper.cxx b/connectivity/source/commontools/TTableHelper.cxx
index 92447c8e94db..7b9bb2e52984 100644
--- a/connectivity/source/commontools/TTableHelper.cxx
+++ b/connectivity/source/commontools/TTableHelper.cxx
@@ -94,7 +94,7 @@ public:
}
namespace connectivity
{
- OUString lcl_getServiceNameForSetting(const Reference< css::sdbc::XConnection >& _xConnection,const OUString& i_sSetting)
+ static OUString lcl_getServiceNameForSetting(const Reference< css::sdbc::XConnection >& _xConnection,const OUString& i_sSetting)
{
OUString sSupportService;
Any aValue;
diff --git a/connectivity/source/commontools/dbtools.cxx b/connectivity/source/commontools/dbtools.cxx
index 2476315bc46c..b8b8a4cdd29b 100644
--- a/connectivity/source/commontools/dbtools.cxx
+++ b/connectivity/source/commontools/dbtools.cxx
@@ -220,7 +220,7 @@ sal_Int32 getDefaultNumberFormat(sal_Int32 _nDataType,
return nFormat;
}
-Reference< XConnection> findConnection(const Reference< XInterface >& xParent)
+static Reference< XConnection> findConnection(const Reference< XInterface >& xParent)
{
Reference< XConnection> xConnection(xParent, UNO_QUERY);
if (!xConnection.is())
@@ -232,7 +232,7 @@ Reference< XConnection> findConnection(const Reference< XInterface >& xParent)
return xConnection;
}
-Reference< XDataSource> getDataSource_allowException(
+static Reference< XDataSource> getDataSource_allowException(
const OUString& _rsTitleOrPath,
const Reference< XComponentContext >& _rxContext )
{
@@ -260,7 +260,7 @@ Reference< XDataSource > getDataSource(
return xDS;
}
-Reference< XConnection > getConnection_allowException(
+static Reference< XConnection > getConnection_allowException(
const OUString& _rsTitleOrPath,
const OUString& _rsUser,
const OUString& _rsPwd,
@@ -337,7 +337,7 @@ Reference< XConnection> getConnection(const Reference< XRowSet>& _rxRowSet)
// helper function which allows to implement both the connectRowset and the ensureRowSetConnection semantics
// if connectRowset (which is deprecated) is removed, this function and one of its parameters are
// not needed anymore, the whole implementation can be moved into ensureRowSetConnection then)
-SharedConnection lcl_connectRowSet(const Reference< XRowSet>& _rxRowSet, const Reference< XComponentContext >& _rxContext,
+static SharedConnection lcl_connectRowSet(const Reference< XRowSet>& _rxRowSet, const Reference< XComponentContext >& _rxContext,
bool _bAttachAutoDisposer )
{
SharedConnection xConnection;
@@ -1197,7 +1197,7 @@ Reference< XDataSource> findDataSource(const Reference< XInterface >& _xParent)
return xDataSource;
}
-Reference< XSingleSelectQueryComposer > getComposedRowSetStatement( const Reference< XPropertySet >& _rxRowSet, const Reference< XComponentContext >& _rxContext )
+static Reference< XSingleSelectQueryComposer > getComposedRowSetStatement( const Reference< XPropertySet >& _rxRowSet, const Reference< XComponentContext >& _rxContext )
{
Reference< XSingleSelectQueryComposer > xComposer;
try
diff --git a/connectivity/source/commontools/dbtools2.cxx b/connectivity/source/commontools/dbtools2.cxx
index d17c96d400ee..b8643e642efd 100644
--- a/connectivity/source/commontools/dbtools2.cxx
+++ b/connectivity/source/commontools/dbtools2.cxx
@@ -940,17 +940,17 @@ sal_Int32 DBTypeConversion::convertUnicodeStringToLength( const OUString& _rSour
return nLen;
}
-OUString lcl_getReportEngines()
+static OUString lcl_getReportEngines()
{
return OUString("org.openoffice.Office.DataAccess/ReportEngines");
}
-OUString lcl_getDefaultReportEngine()
+static OUString lcl_getDefaultReportEngine()
{
return OUString("DefaultReportEngine");
}
-OUString lcl_getReportEngineNames()
+static OUString lcl_getReportEngineNames()
{
return OUString("ReportEngineNames");
}
diff --git a/connectivity/source/drivers/evoab2/NResultSet.cxx b/connectivity/source/drivers/evoab2/NResultSet.cxx
index e852309963ae..79557fd69789 100644
--- a/connectivity/source/drivers/evoab2/NResultSet.cxx
+++ b/connectivity/source/drivers/evoab2/NResultSet.cxx
@@ -297,8 +297,9 @@ getValue( EContact* pContact, sal_Int32 nColumnNum, GType nType, GValue* pStackV
return true;
}
-extern "C"
-int CompareContacts( gconstpointer _lhs, gconstpointer _rhs, gpointer _userData )
+extern "C" {
+
+static int CompareContacts( gconstpointer _lhs, gconstpointer _rhs, gpointer _userData )
{
EContact* lhs = const_cast< gpointer >( _lhs );
EContact* rhs = const_cast< gpointer >( _rhs );
@@ -355,6 +356,8 @@ int CompareContacts( gconstpointer _lhs, gconstpointer _rhs, gpointer _userData
return 0;
}
+}
+
OString OEvoabVersionHelper::getUserName( EBook *pBook )
{
OString aName;
diff --git a/connectivity/source/drivers/firebird/Util.cxx b/connectivity/source/drivers/firebird/Util.cxx
index 14844cfaaddb..6cc5d16484f9 100644
--- a/connectivity/source/drivers/firebird/Util.cxx
+++ b/connectivity/source/drivers/firebird/Util.cxx
@@ -67,7 +67,7 @@ void firebird::evaluateStatusVector(const ISC_STATUS_ARRAY& rStatusVector,
}
}
-sal_Int32 lcl_getNumberType( short aType, NumberSubType aSubType )
+static sal_Int32 lcl_getNumberType( short aType, NumberSubType aSubType )
{
switch(aSubType)
{
@@ -92,7 +92,7 @@ sal_Int32 lcl_getNumberType( short aType, NumberSubType aSubType )
}
}
}
-sal_Int32 lcl_getCharColumnType( short aType, const OUString& sCharset )
+static sal_Int32 lcl_getCharColumnType( short aType, const OUString& sCharset )
{
switch(aType)
{
diff --git a/connectivity/source/drivers/hsqldb/HStorageMap.cxx b/connectivity/source/drivers/hsqldb/HStorageMap.cxx
index f3214e94359c..04116d02f036 100644
--- a/connectivity/source/drivers/hsqldb/HStorageMap.cxx
+++ b/connectivity/source/drivers/hsqldb/HStorageMap.cxx
@@ -123,13 +123,13 @@ namespace connectivity
}
}
- TStorages& lcl_getStorageMap()
+ static TStorages& lcl_getStorageMap()
{
static TStorages s_aMap;
return s_aMap;
}
- OUString lcl_getNextCount()
+ static OUString lcl_getNextCount()
{
static sal_Int32 s_nCount = 0;
return OUString::number(s_nCount++);
diff --git a/connectivity/source/drivers/jdbc/Object.cxx b/connectivity/source/drivers/jdbc/Object.cxx
index 4a9a854d48f7..8fac24980fb7 100644
--- a/connectivity/source/drivers/jdbc/Object.cxx
+++ b/connectivity/source/drivers/jdbc/Object.cxx
@@ -40,7 +40,7 @@ using namespace ::com::sun::star::container;
using namespace ::com::sun::star::lang;
-::rtl::Reference< jvmaccess::VirtualMachine > const & getJavaVM2(const ::rtl::Reference< jvmaccess::VirtualMachine >& _rVM = ::rtl::Reference< jvmaccess::VirtualMachine >(),
+static ::rtl::Reference< jvmaccess::VirtualMachine > const & getJavaVM2(const ::rtl::Reference< jvmaccess::VirtualMachine >& _rVM = ::rtl::Reference< jvmaccess::VirtualMachine >(),
bool _bSet = false)
{
static ::rtl::Reference< jvmaccess::VirtualMachine > s_VM;
@@ -70,7 +70,7 @@ SDBThreadAttach::~SDBThreadAttach()
{
}
-oslInterlockedCount& getJavaVMRefCount()
+static oslInterlockedCount& getJavaVMRefCount()
{
static oslInterlockedCount s_nRefCount = 0;
return s_nRefCount;
diff --git a/connectivity/source/drivers/mork/MQueryHelper.cxx b/connectivity/source/drivers/mork/MQueryHelper.cxx
index 00cdf3df93c0..c2b3ccf5713b 100644
--- a/connectivity/source/drivers/mork/MQueryHelper.cxx
+++ b/connectivity/source/drivers/mork/MQueryHelper.cxx
@@ -41,7 +41,7 @@ using namespace ::com::sun::star::beans;
using namespace ::com::sun::star::sdbc;
-extern
+static
std::vector<bool> entryMatchedByExpression(MQueryHelper* _aQuery, MQueryExpression const * _aExpr, MQueryHelperResultEntry* entry);
MQueryHelperResultEntry::MQueryHelperResultEntry()
diff --git a/connectivity/source/drivers/mork/mork_helper.cxx b/connectivity/source/drivers/mork/mork_helper.cxx
index 07c70a1aa2d6..4cb11864fee5 100644
--- a/connectivity/source/drivers/mork/mork_helper.cxx
+++ b/connectivity/source/drivers/mork/mork_helper.cxx
@@ -4,7 +4,7 @@
#include <iostream>
#include <sal/log.hxx>
-bool openAddressBook(const std::string& path)
+static bool openAddressBook(const std::string& path)
{
MorkParser mork;
// Open and parse mork file
diff --git a/connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx b/connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx
index 903481e27fe0..5fb717fe3741 100644
--- a/connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx
+++ b/connectivity/source/drivers/mysqlc/mysqlc_databasemetadata.cxx
@@ -47,8 +47,8 @@ using namespace com::sun::star::sdbc;
static std::string wild("%");
-void lcl_setRows_throw(const Reference<XResultSet>& _xResultSet, sal_Int32 _nType,
- const std::vector<std::vector<Any>>& _rRows)
+static void lcl_setRows_throw(const Reference<XResultSet>& _xResultSet, sal_Int32 _nType,
+ const std::vector<std::vector<Any>>& _rRows)
{
Reference<XInitialization> xIni(_xResultSet, UNO_QUERY);
Sequence<Any> aArgs(2);
diff --git a/connectivity/source/drivers/odbc/OFunctions.cxx b/connectivity/source/drivers/odbc/OFunctions.cxx
index 9e546e389208..f740052325c3 100644
--- a/connectivity/source/drivers/odbc/OFunctions.cxx
+++ b/connectivity/source/drivers/odbc/OFunctions.cxx
@@ -79,7 +79,7 @@ T3SQLFreeHandle pODBC3SQLFreeHandle;
T3SQLGetCursorName pODBC3SQLGetCursorName;
T3SQLNativeSql pODBC3SQLNativeSql;
-bool LoadFunctions(oslModule pODBCso);
+static bool LoadFunctions(oslModule pODBCso);
// Take care of Dynamically loading of the DLL/shared lib and Addresses:
// Returns sal_True at success
diff --git a/connectivity/source/drivers/postgresql/pq_connection.cxx b/connectivity/source/drivers/postgresql/pq_connection.cxx
index fe113e0c0585..172c6fc5f130 100644
--- a/connectivity/source/drivers/postgresql/pq_connection.cxx
+++ b/connectivity/source/drivers/postgresql/pq_connection.cxx
@@ -117,11 +117,11 @@ public:
}
};
-OUString ConnectionGetImplementationName()
+static OUString ConnectionGetImplementationName()
{
return OUString( "org.openoffice.comp.connectivity.pq.Connection.noext" );
}
-css::uno::Sequence<OUString> ConnectionGetSupportedServiceNames()
+static css::uno::Sequence<OUString> ConnectionGetSupportedServiceNames()
{
return Sequence< OUString > { "com.sun.star.sdbc.Connection" };
}
@@ -640,7 +640,7 @@ Reference< XNameAccess > Connection::getUsers()
}
/// @throws Exception
-Reference< XInterface > ConnectionCreateInstance(
+static Reference< XInterface > ConnectionCreateInstance(
const Reference< XComponentContext > & ctx )
{
::rtl::Reference< comphelper::RefCountedMutex > ref = new comphelper::RefCountedMutex;
diff --git a/connectivity/source/drivers/postgresql/pq_driver.cxx b/connectivity/source/drivers/postgresql/pq_driver.cxx
index a51f69c848e9..a27bd95175d5 100644
--- a/connectivity/source/drivers/postgresql/pq_driver.cxx
+++ b/connectivity/source/drivers/postgresql/pq_driver.cxx
@@ -70,12 +70,12 @@ using com::sun::star::sdbcx::XTablesSupplier;
namespace pq_sdbc_driver
{
-OUString DriverGetImplementationName()
+static OUString DriverGetImplementationName()
{
return OUString( "org.openoffice.comp.connectivity.pq.Driver.noext" );
}
-Sequence< OUString > DriverGetSupportedServiceNames()
+static Sequence< OUString > DriverGetSupportedServiceNames()
{
return Sequence< OUString > { "com.sun.star.sdbc.Driver" };
}
@@ -154,7 +154,7 @@ Reference< XTablesSupplier > Driver::getDataDefinitionByURL(
}
-Reference< XInterface > DriverCreateInstance( const Reference < XComponentContext > & ctx )
+static Reference< XInterface > DriverCreateInstance( const Reference < XComponentContext > & ctx )
{
Reference< XInterface > ret = * new Driver( ctx );
return ret;
diff --git a/connectivity/source/manager/mdrivermanager.cxx b/connectivity/source/manager/mdrivermanager.cxx
index e9fdf9f8ad09..cac14c1d673f 100644
--- a/connectivity/source/manager/mdrivermanager.cxx
+++ b/connectivity/source/manager/mdrivermanager.cxx
@@ -50,7 +50,7 @@ using namespace ::osl;
#define SERVICE_SDBC_DRIVER "com.sun.star.sdbc.Driver"
/// @throws NoSuchElementException
-void throwNoSuchElementException()
+static void throwNoSuchElementException()
{
throw NoSuchElementException();
}
diff --git a/connectivity/source/parse/sqlnode.cxx b/connectivity/source/parse/sqlnode.cxx
index 2b2a687f6e47..683ac9e3b3c2 100644
--- a/connectivity/source/parse/sqlnode.cxx
+++ b/connectivity/source/parse/sqlnode.cxx
@@ -1786,7 +1786,7 @@ OSQLParseNode* OSQLParseNode::getByRule(OSQLParseNode::Rule eRule) const
return pRetNode;
}
-OSQLParseNode* MakeANDNode(OSQLParseNode *pLeftLeaf,OSQLParseNode *pRightLeaf)
+static OSQLParseNode* MakeANDNode(OSQLParseNode *pLeftLeaf,OSQLParseNode *pRightLeaf)
{
OSQLParseNode* pNewNode = new OSQLParseNode(OUString(),SQLNodeType::Rule,OSQLParser::RuleID(OSQLParseNode::boolean_term));
pNewNode->append(pLeftLeaf);
@@ -1795,7 +1795,7 @@ OSQLParseNode* MakeANDNode(OSQLParseNode *pLeftLeaf,OSQLParseNode *pRightLeaf)
return pNewNode;
}
... etc. - the rest is truncated
More information about the Libreoffice-commits
mailing list