[Libreoffice-commits] core.git: sc/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu Sep 27 14:31:25 UTC 2018


 sc/source/core/opencl/formulagroupcl.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit 06e81e90100bb7e3779e461c91530f4b2d9ee3ff
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Thu Sep 27 13:40:33 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Thu Sep 27 16:31:02 2018 +0200

    coverity#1439332 silence Identical code for different branches
    
    Change-Id: I9f477e063fd764fff24843562a2de34b5498d4c5
    Reviewed-on: https://gerrit.libreoffice.org/61038
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/sc/source/core/opencl/formulagroupcl.cxx b/sc/source/core/opencl/formulagroupcl.cxx
index 3e61e4283479..f4d1c518d319 100644
--- a/sc/source/core/opencl/formulagroupcl.cxx
+++ b/sc/source/core/opencl/formulagroupcl.cxx
@@ -2149,6 +2149,7 @@ static DynamicKernelArgument* VectorRefFactory( const ScCalcConfig& config, cons
     // SUMIFS does not perform parallel reduction at DoubleVectorRef level
     if (dynamic_cast<OpSumIfs*>(pCodeGen.get()))
     {
+        // coverity[identical_branches] - only identical if Base happens to be VectorRef
         if (index == 0) // the first argument of OpSumIfs cannot be strings anyway
             return new DynamicKernelSlidingArgument<VectorRef>(config, s, ft, pCodeGen, index);
         return new DynamicKernelSlidingArgument<Base>(config, s, ft, pCodeGen, index);


More information about the Libreoffice-commits mailing list