[Libreoffice-commits] core.git: editeng/source

Libreoffice Gerrit user logerrit at kemper.freedesktop.org
Thu Sep 27 14:32:17 UTC 2018


 editeng/source/rtf/svxrtf.cxx |    1 +
 1 file changed, 1 insertion(+)

New commits:
commit bfd2393ca7247aae1b09e661610a5f750b6e06fa
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Thu Sep 27 11:56:57 2018 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Thu Sep 27 16:31:51 2018 +0200

    ofz#10696 null-deref
    
    since...
    
    commit c6b8587eef3ead53418312c43012f4322789a33a
    Date:   Wed Sep 19 16:35:10 2018 +0200
    
        loplugin:useuniqueptr in SvxRTFParser
    
    Change-Id: Id901d5645500fedcb54b11e1b5b27fe81281f5a2
    Reviewed-on: https://gerrit.libreoffice.org/61033
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/editeng/source/rtf/svxrtf.cxx b/editeng/source/rtf/svxrtf.cxx
index bfd67ed4ced4..1c4f7f246d09 100644
--- a/editeng/source/rtf/svxrtf.cxx
+++ b/editeng/source/rtf/svxrtf.cxx
@@ -680,6 +680,7 @@ void SvxRTFParser::AttrGroupEnd()   // process the current, delete from Stack
     if( !aAttrStack.empty() )
     {
         std::unique_ptr<SvxRTFItemStackType> pOld = std::move(aAttrStack.back());
+        aAttrStack.pop_back();
         SvxRTFItemStackType *pCurrent = aAttrStack.empty() ? nullptr : aAttrStack.back().get();
 
         do {        // middle check loop


More information about the Libreoffice-commits mailing list