[Libreoffice-commits] core.git: sfx2/source

Tor Lillqvist (via logerrit) logerrit at kemper.freedesktop.org
Tue Apr 2 18:46:43 UTC 2019


 sfx2/source/doc/docfile.cxx |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

New commits:
commit b1881e85172f642a28b38be817ec499947ae6029
Author:     Tor Lillqvist <tml at collabora.com>
AuthorDate: Tue Apr 2 14:02:51 2019 +0300
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Tue Apr 2 21:45:17 2019 +0300

    Warn when getFileURLFromSystemPath() fails, not when it succeeds
    
    Also, display the name that the call failed for in the warning message.
    
    Change-Id: I0b6b7baca1d534b5bada5286b2b0e5b8e94f1832

diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx
index a389396caf56..e012672b6168 100644
--- a/sfx2/source/doc/docfile.cxx
+++ b/sfx2/source/doc/docfile.cxx
@@ -763,9 +763,9 @@ bool SfxMedium::IsStorage()
     {
         OUString aURL;
         if ( osl::FileBase::getFileURLFromSystemPath( pImpl->m_aName, aURL )
-             == osl::FileBase::E_None )
+             != osl::FileBase::E_None )
         {
-            SAL_WARN( "sfx.doc", "Physical name not convertible!");
+            SAL_WARN( "sfx.doc", "Physical name '" << pImpl->m_aName << "' not convertible to file URL");
         }
         pImpl->bIsStorage = SotStorage::IsStorageFile( aURL ) && !SotStorage::IsOLEStorage( aURL);
         if ( !pImpl->bIsStorage )


More information about the Libreoffice-commits mailing list