[Libreoffice-commits] core.git: sc/source

Dennis Francis (via logerrit) logerrit at kemper.freedesktop.org
Fri Apr 5 21:55:17 UTC 2019


 sc/source/ui/undo/undoblk.cxx |    4 ----
 1 file changed, 4 deletions(-)

New commits:
commit 9079da7f62febaf4cef0b77320c31b4e8bb6b5a5
Author:     Dennis Francis <dennis.francis at collabora.com>
AuthorDate: Thu Apr 4 14:07:11 2019 +0530
Commit:     Eike Rathke <erack at redhat.com>
CommitDate: Fri Apr 5 23:54:52 2019 +0200

    tdf#124326 : ScUndoDragDrop : don't do update references...
    
    on undo, as all affected formula-cells are preserved in original
    form in the undo document. This is ensured by the drag-drop
    move-block code (ScDocFunc::MoveBlock) which in-turn calls
    ScDocument::UpdateReference, which records all original
    formula-cells to the undo-document.
    
    Anyway the sc::RefMovedHint object created in ScUndoDragDrop::Undo
    is wrong, as it operates on original data-range(aCxt.maRange = aSrcRange)
    which is interpreted as "old data-range" in the context of undo-move
    operation.
    
    Change-Id: Ic48cc3fa51fdb17e9338f65ac95b8e8d30c2c92c
    Reviewed-on: https://gerrit.libreoffice.org/70315
    Tested-by: Jenkins
    Reviewed-by: Eike Rathke <erack at redhat.com>

diff --git a/sc/source/ui/undo/undoblk.cxx b/sc/source/ui/undo/undoblk.cxx
index 892febbaeb0c..a24ff8558d31 100644
--- a/sc/source/ui/undo/undoblk.cxx
+++ b/sc/source/ui/undo/undoblk.cxx
@@ -1352,10 +1352,6 @@ void ScUndoDragDrop::Undo()
                 pName->UpdateReference(aCxt, nTab);
         }
 
-        // Notify all listeners of the destination range, and have them update their references.
-        sc::RefMovedHint aHint(aDestRange, ScAddress(nColDelta, nRowDelta, nTabDelta), aCxt);
-        rDoc.BroadcastRefMoved(aHint);
-
         ScValidationDataList* pValidList = rDoc.GetValidationList();
         if (pValidList)
         {


More information about the Libreoffice-commits mailing list