[Libreoffice-commits] core.git: Branch 'libreoffice-6-2' - 2 commits - sw/source

[Michael Stahl (via logerrit)]

 sw/source/core/txtnode/ndtxt.cxx  |    5 ++++-
 sw/source/uibase/inc/wrtsh.hxx    |    2 +-
 sw/source/uibase/uiview/view2.cxx |    2 +-
 sw/source/uibase/wrtsh/move.cxx   |    3 ++-
 4 files changed, 8 insertions(+), 4 deletions(-)

New commits:
commit ab52cb7cdf9d69c58b06f93a5488a534e12ebcd2
Author:     Michael Stahl <Michael.Stahl at cib.de>
AuthorDate: Tue Apr 9 17:57:42 2019 +0200
Commit:     Thorsten Behrens <Thorsten.Behrens at CIB.de>
CommitDate: Wed Apr 10 15:44:12 2019 +0200

    tdf#124469 sw_redlinehide: fix PDF export of links to sequence fields
    
    Missed one call where the return value must be forwarded.
    
    (regression from 7d481f7ac1971be622520258a4b13ada29282844
     and 943d9be770e550d20ca72274fa5e914d1f61e605)
    
    Change-Id: Ic405b29a1dce982bfdd81eeb5d678ceb79690bfc
    Reviewed-on: https://gerrit.libreoffice.org/70469
    Tested-by: Jenkins
    Reviewed-by: Michael Stahl <Michael.Stahl at cib.de>
    (cherry picked from commit 0017c9b5720ddc4d6327ec06e05c681f08ea6f1d)
    Reviewed-on: https://gerrit.libreoffice.org/70501
    Reviewed-by: Thorsten Behrens <Thorsten.Behrens at CIB.de>

diff --git a/sw/source/uibase/inc/wrtsh.hxx b/sw/source/uibase/inc/wrtsh.hxx
index 1acefbd6814b..4beec06b13da 100644
--- a/sw/source/uibase/inc/wrtsh.hxx
+++ b/sw/source/uibase/inc/wrtsh.hxx
@@ -469,7 +469,7 @@ typedef bool (SwWrtShell:: *FNSimpleMove)();
     void GotoOutline( SwOutlineNodes::size_type nIdx );
     bool GotoOutline( const OUString& rName );
     bool GotoRegion( const OUString& rName );
-    void GotoRefMark( const OUString& rRefMark, sal_uInt16 nSubType = 0,
+    bool GotoRefMark( const OUString& rRefMark, sal_uInt16 nSubType = 0,
         sal_uInt16 nSeqNo = 0 );
     bool GotoNextTOXBase( const OUString* pName = nullptr);
     bool GotoTable( const OUString& rName );
diff --git a/sw/source/uibase/uiview/view2.cxx b/sw/source/uibase/uiview/view2.cxx
index a832d8fb246c..d4dcbe5473fb 100644
--- a/sw/source/uibase/uiview/view2.cxx
+++ b/sw/source/uibase/uiview/view2.cxx
@@ -1953,7 +1953,7 @@ bool SwView::JumpToSwMark( const OUString& rMark )
                 {
                     sal_uInt16 nSeqNo = sName.copy( nNoPos + 1 ).toInt32();
                     sName = sName.copy( 0, nNoPos );
-                    m_pWrtShell->GotoRefMark( sName, REF_SEQUENCEFLD, nSeqNo );
+                    bRet = m_pWrtShell->GotoRefMark(sName, REF_SEQUENCEFLD, nSeqNo);
                 }
             }
             else if( sCmp == "text" )
diff --git a/sw/source/uibase/wrtsh/move.cxx b/sw/source/uibase/wrtsh/move.cxx
index ef35f0922ec2..14f7bf53f70f 100644
--- a/sw/source/uibase/wrtsh/move.cxx
+++ b/sw/source/uibase/wrtsh/move.cxx
@@ -628,13 +628,14 @@ bool SwWrtShell::GotoRegion( const OUString& rName )
     return bRet;
  }
 
-void SwWrtShell::GotoRefMark( const OUString& rRefMark, sal_uInt16 nSubType,
+bool SwWrtShell::GotoRefMark( const OUString& rRefMark, sal_uInt16 nSubType,
                                     sal_uInt16 nSeqNo )
 {
     SwPosition aPos = *GetCursor()->GetPoint();
     bool bRet = SwCursorShell::GotoRefMark(rRefMark, nSubType, nSeqNo);
     if (bRet)
         m_aNavigationMgr.addEntry(aPos);
+    return bRet;
 }
 
 bool SwWrtShell::GotoNextTOXBase( const OUString* pName )
commit 4c8f8038459c503121adb895129101dd4b2923a9
Author:     Michael Stahl <Michael.Stahl at cib.de>
AuthorDate: Tue Apr 9 17:15:50 2019 +0200
Commit:     Thorsten Behrens <Thorsten.Behrens at CIB.de>
CommitDate: Wed Apr 10 15:43:56 2019 +0200

    tdf#124586 sw_redlinehide: fix crash in SwTextNode::NumRuleChgd()
    
    (regression from c180c9447256588fe5e7991e06642883574760ae)
    
    Change-Id: Ie3c935ee5dd42187ca8ad2b28406b80e63c0d1e3
    Reviewed-on: https://gerrit.libreoffice.org/70467
    Reviewed-by: Michael Stahl <Michael.Stahl at cib.de>
    Tested-by: Michael Stahl <Michael.Stahl at cib.de>
    (cherry picked from commit 7587e39014c1b6ed505e9c10d9f0f0803fc986ac)
    Reviewed-on: https://gerrit.libreoffice.org/70500
    Tested-by: Jenkins
    Reviewed-by: Thorsten Behrens <Thorsten.Behrens at CIB.de>

diff --git a/sw/source/core/txtnode/ndtxt.cxx b/sw/source/core/txtnode/ndtxt.cxx
index 0a98d0fd4539..c8719a4316d6 100644
--- a/sw/source/core/txtnode/ndtxt.cxx
+++ b/sw/source/core/txtnode/ndtxt.cxx
@@ -2864,7 +2864,10 @@ void SwTextNode::NumRuleChgd()
         if ( pNumRule && pNumRule != GetNum()->GetNumRule() )
         {
             mpNodeNum->ChangeNumRule( *pNumRule );
-            mpNodeNumRLHidden->ChangeNumRule( *pNumRule );
+            if (mpNodeNumRLHidden)
+            {
+                mpNodeNumRLHidden->ChangeNumRule(*pNumRule);
+            }
         }
     }