[Libreoffice-commits] core.git: vcl/source

Luboš Luňák (via logerrit) logerrit at kemper.freedesktop.org
Tue Apr 16 15:11:56 UTC 2019


 vcl/source/opengl/OpenGLHelper.cxx |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit daaef8cbe4d3a67996c6410c24eca19ecf0a810e
Author:     Luboš Luňák <l.lunak at collabora.com>
AuthorDate: Sun Apr 14 18:01:59 2019 +0200
Commit:     Luboš Luňák <l.lunak at collabora.com>
CommitDate: Tue Apr 16 17:09:02 2019 +0200

    abort() in dbgutil mode if OpenGL shader compilation fails
    
    Otherwise it's quite annoying to miss e.g. a typo in the shader code
    if the code falls back to another way of handling the operation.
    
    Change-Id: I585be85f739929f0f422dc031a36dc83077f6820
    Reviewed-on: https://gerrit.libreoffice.org/70771
    Tested-by: Jenkins
    Reviewed-by: Luboš Luňák <l.lunak at collabora.com>

diff --git a/vcl/source/opengl/OpenGLHelper.cxx b/vcl/source/opengl/OpenGLHelper.cxx
index 2b2e8ea4d783..0a5d58142978 100644
--- a/vcl/source/opengl/OpenGLHelper.cxx
+++ b/vcl/source/opengl/OpenGLHelper.cxx
@@ -135,6 +135,10 @@ namespace {
         }
         else
             SAL_WARN("vcl.opengl", rDetail << " shader: " << rName << " compile " << nId << " failed without error log");
+
+#ifdef DBG_UTIL
+        abort();
+#endif
         return 0;
     }
 }


More information about the Libreoffice-commits mailing list