[Libreoffice-commits] core.git: vcl/source

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Wed Apr 17 15:09:19 UTC 2019


 vcl/source/window/cursor.cxx |    2 ++
 1 file changed, 2 insertions(+)

New commits:
commit 73979f5a45d937bc686be7e936a006e63f07536f
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Wed Apr 17 14:21:11 2019 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Wed Apr 17 17:02:49 2019 +0200

    Initialize ImplCursorData members as required
    
    mbCurVisible is immediately read in ImplPrepForDraw, which inits some more
    members but not mnStyle which is then read in ImplCursorInvert.  Regression
    introduced with b9c10ee923308f336a694bbc0212396ed5317b6a "weld
    ClassificationDialog", found when valgrind'ing UITest_classification.
    
    Change-Id: I986af0531e250953b8e45c914997b31c53a9ba91
    Reviewed-on: https://gerrit.libreoffice.org/70876
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/vcl/source/window/cursor.cxx b/vcl/source/window/cursor.cxx
index 4839b7d56fc7..c5c64684f1b9 100644
--- a/vcl/source/window/cursor.cxx
+++ b/vcl/source/window/cursor.cxx
@@ -163,6 +163,8 @@ void vcl::Cursor::ImplDraw()
 void vcl::Cursor::DrawToDevice(OutputDevice& rRenderContext)
 {
     ImplCursorData aData;
+    aData.mnStyle = 0;
+    aData.mbCurVisible = false;
     // calculate output area
     if (ImplPrepForDraw(&rRenderContext, aData))
     {


More information about the Libreoffice-commits mailing list