[Libreoffice-commits] core.git: bin/get-bugzilla-attachments-by-mimetype

[Caolán McNamara (via logerrit)]

 bin/get-bugzilla-attachments-by-mimetype |    5 +++++
 1 file changed, 5 insertions(+)

New commits:
commit a91deee9ee7bb20b2a79efea51d3a7998283983e
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Apr 19 12:55:28 2019 +0100
Commit:     Caolán McNamara <caolanm at redhat.com>
CommitDate: Fri Apr 19 14:50:55 2019 +0200

    node.firstChild seen as None
    
    Change-Id: Ic4d2538f15d6246d81fabe8347a8be157b69deb3
    Reviewed-on: https://gerrit.libreoffice.org/70979
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>

diff --git a/bin/get-bugzilla-attachments-by-mimetype b/bin/get-bugzilla-attachments-by-mimetype
index 5d6227996cb8..a704b5461d67 100755
--- a/bin/get-bugzilla-attachments-by-mimetype
+++ b/bin/get-bugzilla-attachments-by-mimetype
@@ -71,6 +71,11 @@ def get_from_bug_url_via_xml(url, mimetype, prefix, suffix):
         print(" mimetype is", end=' ')
         for node in attachment.childNodes:
             if node.nodeName == 'type':
+                # check if attachment is deleted
+                if not node.firstChild:
+                    print('deleted attachment, skipping')
+                    continue
+
                 print(node.firstChild.nodeValue, end=' ')
                 if node.firstChild.nodeValue.lower() != mimetype.lower():
                     print('skipping')