[Libreoffice-commits] core.git: 2 commits - forms/source qadevOOo/objdsc sc/qa

[Andrea Gelmini (via logerrit)]

 forms/source/component/entrylisthelper.hxx                       |    2 
 qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableColumnObj.csv |    7 -
 sc/qa/extras/sctablecolumnobj.cxx                                |   48 +++++++++-
 3 files changed, 48 insertions(+), 9 deletions(-)

New commits:
commit 6a8aac9b3d1cbf5c27ccf179f1c603fee6713fc7
Author:     Andrea Gelmini <andrea.gelmini at gelma.net>
AuthorDate: Wed Apr 10 15:59:59 2019 +0000
Commit:     Julien Nabet <serval2412 at yahoo.fr>
CommitDate: Sun Apr 21 08:54:48 2019 +0200

    Fix typo
    
    Change-Id: I5bacb30918f72d8b6a992c88a209b30647303177
    Reviewed-on: https://gerrit.libreoffice.org/71031
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>
    Tested-by: Julien Nabet <serval2412 at yahoo.fr>

diff --git a/forms/source/component/entrylisthelper.hxx b/forms/source/component/entrylisthelper.hxx
index 929c4d5bd320..f358ba53273d 100644
--- a/forms/source/component/entrylisthelper.hxx
+++ b/forms/source/component/entrylisthelper.hxx
@@ -179,7 +179,7 @@ namespace frm
 
         /** refreshes our list entries
 
-            In case we have an external list source, its used to obtain the new entries, and then
+            In case we have an external list source, it's used to obtain the new entries, and then
             stringItemListChanged is called to give the derived class the possibility to
             react on this.
 
commit 7d51d3876f488dca577b1d889d390a90fbfb4134
Author:     Jens Carl <j.carl43 at gmx.de>
AuthorDate: Sun Apr 21 05:47:36 2019 +0000
Commit:     Jens Carl <j.carl43 at gmx.de>
CommitDate: Sun Apr 21 08:54:39 2019 +0200

    tdf#45904 Move XPropertySet Java tests to C++
    
    Move XPropertySet Java tests to C++ for ScTableColumnObj.
    
    Change-Id: Id77c4162acfe849993e7ffa392e9428b4f52bdd0
    Reviewed-on: https://gerrit.libreoffice.org/71034
    Tested-by: Jenkins
    Reviewed-by: Jens Carl <j.carl43 at gmx.de>

diff --git a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableColumnObj.csv b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableColumnObj.csv
index 70a50be2c57c..5a12a914c4c4 100644
--- a/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableColumnObj.csv
+++ b/qadevOOo/objdsc/sc/com.sun.star.comp.office.ScTableColumnObj.csv
@@ -1,10 +1,3 @@
-"ScTableColumnObj";"com::sun::star::beans::XPropertySet";"getPropertySetInfo()"
-"ScTableColumnObj";"com::sun::star::beans::XPropertySet";"setPropertyValue()"
-"ScTableColumnObj";"com::sun::star::beans::XPropertySet";"getPropertyValue()"
-"ScTableColumnObj";"com::sun::star::beans::XPropertySet";"addPropertyChangeListener()"
-"ScTableColumnObj";"com::sun::star::beans::XPropertySet";"removePropertyChangeListener()"
-"ScTableColumnObj";"com::sun::star::beans::XPropertySet";"addVetoableChangeListener()"
-"ScTableColumnObj";"com::sun::star::beans::XPropertySet";"removeVetoableChangeListener()"
 "ScTableColumnObj";"com::sun::star::table::TableColumn";"Width"
 "ScTableColumnObj";"com::sun::star::table::TableColumn";"OptimalWidth"
 "ScTableColumnObj";"com::sun::star::table::TableColumn";"IsVisible"
diff --git a/sc/qa/extras/sctablecolumnobj.cxx b/sc/qa/extras/sctablecolumnobj.cxx
index c65a8683b89c..75736d6d45fc 100644
--- a/sc/qa/extras/sctablecolumnobj.cxx
+++ b/sc/qa/extras/sctablecolumnobj.cxx
@@ -8,6 +8,7 @@
  */
 
 #include <test/calc_unoapi_test.hxx>
+#include <test/beans/xpropertyset.hxx>
 #include <test/container/xnamed.hxx>
 #include <test/table/xcellrange.hxx>
 
@@ -26,7 +27,10 @@ using namespace css;
 
 namespace sc_apitest
 {
-class ScTableColumnObj : public CalcUnoApiTest, public apitest::XCellRange, public apitest::XNamed
+class ScTableColumnObj : public CalcUnoApiTest,
+                         public apitest::XCellRange,
+                         public apitest::XNamed,
+                         public apitest::XPropertySet
 {
 public:
     ScTableColumnObj();
@@ -47,6 +51,13 @@ public:
     // because TableColumnNames are fixed, test for an exception
     CPPUNIT_TEST(testSetNameThrowsException);
 
+    // XPropertySet
+    CPPUNIT_TEST(testGetPropertySetInfo);
+    CPPUNIT_TEST(testGetPropertyValue);
+    CPPUNIT_TEST(testSetPropertyValue);
+    CPPUNIT_TEST(testPropertyChangeListener);
+    CPPUNIT_TEST(testVetoableChangeListener);
+
     CPPUNIT_TEST_SUITE_END();
 
 private:
@@ -57,6 +68,41 @@ ScTableColumnObj::ScTableColumnObj()
     : CalcUnoApiTest("/sc/qa/extras/testdocuments")
     , XCellRange("K1:K1")
     , XNamed("K")
+    , XPropertySet({
+          "BottomBorder",
+          "BottomBorder2",
+          "CellProtection",
+          "CharLocale",
+          "CharLocaleAsian",
+          "CharLocaleComplex",
+          "CharPosture",
+          "CharPostureAsian",
+          "CharPostureComplex",
+          "ConditionalFormat",
+          "ConditionalFormatLocal",
+          "ConditionalFormatXML",
+          "DiagonalBLTR",
+          "DiagonalBLTR2",
+          "DiagonalTLBR",
+          "DiagonalTLBR2",
+          "HoriJustify",
+          "LeftBorder",
+          "LeftBorder2",
+          "NumberingRules",
+          "Orientation",
+          "RightBorder",
+          "RightBorder2",
+          "ShadowFormat",
+          "TableBorder",
+          "TableBorder2",
+          "TopBorder",
+          "TopBorder2",
+          "UserDefinedAttributes",
+          "Validation",
+          "ValidationLocal",
+          "ValidationXML",
+          "WritingMode",
+      })
 {
 }