[Libreoffice-commits] core.git: Makefile.in

[Stephan Bergmann (via logerrit)]

 Makefile.in |    3 ---
 1 file changed, 3 deletions(-)

New commits:
commit 0b56eb2c10ab4ca027f1a37e04519366b3cd7433
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu Apr 25 13:36:58 2019 +0200
Commit:     Tor Lillqvist <tml at collabora.com>
CommitDate: Thu Apr 25 17:02:41 2019 +0200

    That bin directory should no longer be there
    
    ...at least since 7a08bfeabe21193e04b9747a831653efcfc63190 "tdf#122244 Put
    InfoPlist.strings files at correct places on macOS", though it wasn't under
    Contents/ at least as of lately, anyway.
    
    The code to remove it had been added with
    f345a2c52af0333b46b4b74e686883c8cb9ffab4 "We don't want those
    bin/InfoPlist_*.zip files in the app bundle".  I don't know how to do a
    --enable-macosx-code-signing build on macOS to verify that it can indeed be
    removed, though.
    
    Change-Id: I61d91bd47abf8f4b5d9e117d9943e0682ebef2cb
    Reviewed-on: https://gerrit.libreoffice.org/71298
    Reviewed-by: Tor Lillqvist <tml at collabora.com>
    Tested-by: Tor Lillqvist <tml at collabora.com>

diff --git a/Makefile.in b/Makefile.in
index 0066401b869a..5423596012e0 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -356,9 +356,6 @@ ifneq ($(MACOSX_CODESIGNING_IDENTITY),)
 		mkdir "$$lproj"; \
 	done
 #
-# And remove the "bin" folder which should not be there
-	rm -rf $(TESTINSTALLDIR)/$(PRODUCTNAME_WITHOUT_SPACES).app/Contents/bin
-#
 # Remove unnecessary executables in the LibreOfficePython framework
 	rm -rf $(TESTINSTALLDIR)/$(PRODUCTNAME_WITHOUT_SPACES).app/Contents/Frameworks/LibreOfficePython.framework/Versions/[1-9]*/bin
 #