[Libreoffice-commits] core.git: solenv/bin

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Thu Apr 25 18:11:37 UTC 2019


 solenv/bin/modules/installer/simplepackage.pm |    5 -----
 1 file changed, 5 deletions(-)

New commits:
commit c379ba47a786a6a7422c8fcdbfec32ddbcf88b90
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Thu Apr 25 14:22:21 2019 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu Apr 25 20:10:39 2019 +0200

    No need to explicitly create Conents/Resources/*.lproj/ directories
    
    At least since 7a08bfeabe21193e04b9747a831653efcfc63190 "tdf#122244 Put
    InfoPlist.strings files at correct places on macOS" those directories that have
    actual content are created on demand.  (That is, empty such directories are no
    longer created, but I assume that's a feature rather than a bug.)
    
    Change-Id: If753483c78fbf39e76c9565a407e7ff27ca32efb
    Reviewed-on: https://gerrit.libreoffice.org/71300
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/solenv/bin/modules/installer/simplepackage.pm b/solenv/bin/modules/installer/simplepackage.pm
index 46f9f477d1b1..489f2127688e 100644
--- a/solenv/bin/modules/installer/simplepackage.pm
+++ b/solenv/bin/modules/installer/simplepackage.pm
@@ -405,11 +405,6 @@ sub create_package
         {
             my $subdir = "$tempdir/$packagename/$volume_name_classic_app.app/Contents/Resources";
             if ( ! -d $subdir ) { installer::systemactions::create_directory($subdir); }
-            # iterate over macOS localizations
-            foreach $lang ("ca", "cs", "da", "de", "el", "en", "es", "fi", "fr", "hr", "hu", "id", "it", "ja", "ko", "ms", "nl", "no", "pl", "pt", "pt_PT", "ro", "ru", "sk", "sv", "th", "tr", "uk", "vi", "zh_CN", "zh_TW")
-            {
-                installer::systemactions::create_directory($subdir . "/" . $lang . ".lproj");
-            }
             if ( defined($ENV{'MACOSX_CODESIGNING_IDENTITY'}) && $ENV{'MACOSX_CODESIGNING_IDENTITY'} ne "" )
             {
                 $systemcall = "$ENV{'SRCDIR'}/solenv/bin/macosx-codesign-app-bundle $localtempdir/$folder/$volume_name_classic_app.app";


More information about the Libreoffice-commits mailing list