[Libreoffice-commits] core.git: Changes to 'private/mmeeks/cp-6.2-bits'

Sat Aug 3 17:22:50 UTC 2019

New branch 'private/mmeeks/cp-6.2-bits' available with the following commits:
commit c1860dc7ce113418f5248a232ea55f1f415ef22c
Author: Marco Cecchetti <mrcekets at gmail.com>
Date:   Fri Nov 30 17:20:37 2018 +0100

    lok: shape selection: perform the needed unit conversion in a clever way
    
    Change-Id: I505bd41801b5fd1898a9eddc81b102f2f7ae20b5
    Reviewed-on: https://gerrit.libreoffice.org/70563
    Tested-by: Jenkins
    Reviewed-by: Marco Cecchetti <mrcekets at gmail.com>

commit 6e1dd8c3624bd35bf6802270f75a13650ea9358c
Author: Tor Lillqvist <tml at collabora.com>
Date:   Tue May 14 10:20:50 2019 +0300

    We apparently need to drop the Solar Mutex when exiting lo_runLoop() on iOS
    
    It seems to be held after soffice_main() returns for the first
    document opened, but not subsequent ones, for some reason. So acquire
    it an extra time to be able to use Application::ReleaseSolarMutex()...
    
    Without this, when opening a subsequent document, the loleaflet
    loading progress bar just hangs.
    
    Change-Id: I4e4e7b814f0dba836b790b6f68470aab54f8bbb9

commit 9c2dceef6ae27d82424aa3160c7974245220ea73
Author: Andrea Gelmini <andrea.gelmini at gelma.net>
Date:   Wed May 8 10:13:07 2019 +0000

    Fix typo
    
    Change-Id: Ia8f5ca10c974a0ba2d1686b341ef2a1dd44b824d
    Reviewed-on: https://gerrit.libreoffice.org/72260
    Tested-by: Jenkins
    Reviewed-by: Julien Nabet <serval2412 at yahoo.fr>

commit 2690fe5ac576ddc0afc6672fa28b05af564fdcf0
Author: Tor Lillqvist <tml at collabora.com>
Date:   Mon May 13 18:06:13 2019 +0300

    Fix comment to match reality
    
    lo_runLoop() *is* used in the "Unipoll" case (i.e. current Online and
    mobile apps).
    
    Change-Id: I01ef3d8bc8140531f697952ef142150fc905a8d4

commit 54a79f80ca4d5cb4f88ef515d7b3a8462eea3cd6
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Thu May 9 18:24:18 2019 +0100

    unipoll: let InitVCL tolerate double init.
    
    We need to get VCL initialized early in UniPoll mode, since the main
    setup doesn't occur until runPoll is invoked, and we want to call lots
    of virtual methods that take the SolarMutex before then - which requires
    VCL to be initialized.
    
    Change-Id: Id9c1b74c126cf7bb71d6560b7585d37327a9f5ef
    Reviewed-on: https://gerrit.libreoffice.org/72071
    Tested-by: Jenkins
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>

commit d0ca35c9446296fa1bc747e64ae761ccd3bd46b2
Author: Miklos Vajna <vmiklos at collabora.com>
Date:   Thu May 9 18:13:20 2019 +0200

    CppunitTest_desktop_lib: close the document while LOK is still active
    
    Otherwise the LOK notifiers won't be released (since LOK is not active),
    and we leak vcl::Windows in GetLOKWindowsMap()::s_pLOKWindowsMap.
    
    In dbgutil builds, this leads to an assertion failure if the sidebar is
    active.
    
    Change-Id: Idedb9578478ff4a9f2e17c0cfd203da6f007bdbd
    Reviewed-on: https://gerrit.libreoffice.org/72065
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>
    Tested-by: Jenkins

commit d78fa76cee13be72824b2091a093332d0be9262d
Author: Miklos Vajna <vmiklos at collabora.com>
Date:   Tue May 7 21:10:19 2019 +0200

    desktop: can pass by value in LOKTransferable
    
    Change-Id: Iba7c216f28700e8899d76942a4a0a8b77ed3c549
    Reviewed-on: https://gerrit.libreoffice.org/71930
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>

commit 8f7a56d9410456ccd64928f66fa023f62f7ab6fc
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Sat Apr 27 13:37:52 2019 +0100

    unipoll: emit user input-events & uno commands directly when in unipoll mode.
    
    Rather than emitting asynchronously at idle.
    
    Change-Id: I6c72e9fad0b5587941e3a4a4d17d331a0d889942
    Reviewed-on: https://gerrit.libreoffice.org/71809
    Tested-by: Jenkins
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>

commit c2fa3f2d90a517661f29ae7054c6094b977a4197
Author: Miklos Vajna <vmiklos at collabora.com>
Date:   Mon May 6 14:27:04 2019 +0200

    desktop: turn on clang-format for lokclipboard
    
    This had manual consistent formatting. Recently it was broken, so bring
    back consisency by using clang-format.
    
    Change-Id: If4303e379ddc77e5190f8e8e42737b4f7d680a71
    Reviewed-on: https://gerrit.libreoffice.org/71857
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>
    Tested-by: Jenkins

commit 34524f0f013fe019628a1fd95a3c9ee9b94ecaaa
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Fri May 3 17:24:13 2019 +0100

    unipoll: cleanup runPoll.
    
    Setting a custom thread name is a terrible idea for online unit tests.
    
    Change-Id: I1f5843255ab59072f806587ffcf655958380fe8e
    Reviewed-on: https://gerrit.libreoffice.org/71762
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>
    Tested-by: Michael Meeks <michael.meeks at collabora.com>

commit 251d1e54a1ef8ede2a122f1a0cd84f7dd7a8bfa7
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Fri May 3 13:36:56 2019 +0100

    unipoll: get SolarMutex lock counting right.
    
    lo_startmain drops the SolarMutex without taking it, interestingly.
    
    Change-Id: I2280e2fa6acb8739f970983032db72a8241d1c4f
    Reviewed-on: https://gerrit.libreoffice.org/71741
    Tested-by: Michael Meeks <michael.meeks at collabora.com>
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>

commit f5fdae1faa9a80d863bc7bb26a6fa50650e2f0db
Author: Henry Castro <hcastro at collabora.com>
Date:   Thu Apr 18 18:10:13 2019 -0400

    lok: allow paste content to popup dialog
    
    Change-Id: I1893d52df505bc43428c37a624ca05c569ba1bc0
    Reviewed-on: https://gerrit.libreoffice.org/70958
    Tested-by: Jenkins
    Reviewed-by: Henry Castro <hcastro at collabora.com>

commit b017bdb13ed5469f1b0b65367fe0c2a0b5e73b70
Author: Tor Lillqvist <tml at collabora.com>
Date:   Wed Apr 24 13:19:44 2019 +0300

    tdf#124923: Need to call InitVCL() on iOS before using SolarMutexGuard
    
    Change-Id: If5781ae101e58c26368e57787cb301f84ffa82a5

commit 97ff10460618683e8e79022752cdd8e626690712
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Wed Apr 17 16:23:39 2019 +0100

    Unipoll: add LibreOfficeKit API for polling, and an option to use it.
    
    Change-Id: Iee7556ee52541ddbf1ef8f31e1ed4697f805a2ac
    Reviewed-on: https://gerrit.libreoffice.org/70898
    Tested-by: Jenkins
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit 438d54e7b79e2f71ebd49250f42353b6107df090
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Tue Apr 16 23:01:50 2019 +0100

    lok: add profile zones.
    
    NB. outside of the often contended SolarMutexGuard.
    
    Change-Id: Ieb651e2ed4349e692010a7588721f461af7d2b5b
    Reviewed-on: https://gerrit.libreoffice.org/70848
    Tested-by: Jenkins
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>

commit 32a3a56f85288477bbf0b272bd636b0a6c912c3e
Author: Michael Meeks <michael.meeks at collabora.com>
Date:   Mon Apr 15 13:16:53 2019 +0100

    lok: rename - emitted as events not on stdout now.
    
    Change-Id: Ie57c34eff1d917fada4e10e4b88b27adf8a34d1a
    Reviewed-on: https://gerrit.libreoffice.org/70788
    Tested-by: Jenkins
    Reviewed-by: Michael Meeks <michael.meeks at collabora.com>

commit df3e46be6024d330f6b21b1ab3ec1f1cadc17425
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date:   Sat Apr 13 08:20:48 2019 +0200

    loplugin:sequentialassign in dbaccess..desktop
    
    Change-Id: I3f3108daf208fa8c6be90b28da5503846c27732e
    Reviewed-on: https://gerrit.libreoffice.org/70698
    Tested-by: Jenkins
    Reviewed-by: Noel Grandin <noel.grandin at collabora.co.uk>

commit 5e68da7da22c2554454e95f2724b6ca7910ea9ab
Author: Henry Castro <hcastro at collabora.com>
Date:   Thu Apr 11 14:22:15 2019 -0400

    lok: add missing parameter to PostExtTextInputEvent function
    
    Change-Id: I91fbfd97da0c4ad1ad90710ab781c71ca99367e5
    Reviewed-on: https://gerrit.libreoffice.org/70609
    Tested-by: Jenkins
    Reviewed-by: Henry Castro <hcastro at collabora.com>

commit 69dc62b32a8b6c841fb03ae0798ab115f0f2e577
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Thu Mar 21 14:18:35 2019 +0100

    lok: Keep the temporary user profile set during the entire preload.
    
    Otherwise the core likes to crash due to the keyboard accellerators
    being read, but the configuration is missing.
    
    Change-Id: I94193f47462227b5975a49ce11709d7bf415a519
    Reviewed-on: https://gerrit.libreoffice.org/69508
    Tested-by: Jenkins
    Reviewed-by: Jan Holesovsky <kendy at collabora.com>

commit b8e1cd1298343bf0a72b6162ba79ce608469d1ee
Author: Henry Castro <hcastro at collabora.com>
Date:   Thu Mar 14 09:16:59 2019 -0400

    lok: intercept the UNO command ".uno:ThesaurusDialog"
    
    Change-Id: I085cb646037f260ada4d4d04c2419638dd235048
    Reviewed-on: https://gerrit.libreoffice.org/69264
    Tested-by: Jenkins
    Reviewed-by: Aron Budea <aron.budea at collabora.com>

commit 7149d3640307220b552bdcfe46eb90223c7a3458
Author: merttumer <mert.tumer at collabora.com>
Date:   Wed Feb 13 17:59:30 2019 +0300

    Added tiled watermark export option for pdf
    
    Change-Id: I3f28ad64c13dd4bc1b2862e86d2190e46a0ced46
    Signed-off-by: merttumer <mert.tumer at collabora.com>
    Reviewed-on: https://gerrit.libreoffice.org/67779
    Tested-by: Jenkins

commit 110df5edb1cf1be0a7844a8ec67ff31750f62c0e
Author: Tor Lillqvist <tml at collabora.com>
Date:   Fri Mar 15 16:56:45 2019 +0200

    tdf#124042: Add SAL_INFOs for iOS about the CGContext life cycle in LOKit
    
    Use the same logging tag as in vcl for uniformity. Helps in tracing
    the life cycle and usage of CGContexts.
    
    Change-Id: I89c33ac63fa26e10a8866c2aacecce89ef9b5f6b

commit 9af7ead229acab95c656f280d85719d92fe96121
Author: Noel Grandin <noel.grandin at collabora.co.uk>
Date:   Fri Mar 15 13:46:53 2019 +0200

    loplugin:stringconstant
    
    /home/noel/libo/desktop/source/lib/init.cxx:3571:22: error: rewrite call
    of 'rtl::operator==' with empty string constant argument as call of
    'rtl::OUString::isEmpty' [loplugin:stringconstant]
            if (aHeaders == "")
    
    Change-Id: If0d8c411c6dd563622a855e209c0a5692c222abe

commit ee5f717dd0d368e3cdeb2bd55d3cde6d3ae22fc2
Author: Tor Lillqvist <tml at collabora.com>
Date:   Fri Mar 15 12:13:41 2019 +0200

    Don't return an empty C string, the caller is not prepared for that
    
    If the caller receives a pointer to an empty C string, it will send
    the message "commandvalues: " to the JavaScript bits. That will cause
    an exception as it expects JSON after the commandvalues: keyword.
    
    Instead return a nullptr. The caller is prepared to handle that.
    
    Change-Id: Ia1efa967668ba518993edb7945f064758b660b96

commit 0afdf2066bc7b129cc26a7e37eb10316ee48e1a3
Author: Marco Cecchetti <marco.cecchetti at collabora.com>
Date:   Mon Feb 25 14:42:51 2019 +0100

    lok: sc: clicking on individual chart elements doesn't select object
    
    Exporting to svg a selected object of a chart does not work.
    In the chart case the selected object for the current document is
    always the chart itself, not an internal chart object.
    Moreover the exporting action cause the exported object to be selected
    again. So you try to selected the chart legend and you end up with the
    whole chart selected again.
    
    Change-Id: Ib4aa91afd592909ad354ca373dc03298547f9fb5
    Reviewed-on: https://gerrit.libreoffice.org/68347
    Tested-by: Jenkins
    Reviewed-by: Szymon Kłos <szymon.klos at collabora.com>

commit 7979f81c854e38cf0b7cad0fc659c7a47c0c20e8
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Fri Feb 15 09:39:57 2019 -0500

    LOK: reuse cached json object for ViewId where available
    
    Change-Id: I5e29ec2863e06d3dfcbad95c55e355805f12e259
    Reviewed-on: https://gerrit.libreoffice.org/67895
    Tested-by: Jenkins
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit 857b61a04e40662590c3d6584e67e4060e87cea5
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Fri Feb 15 09:23:58 2019 -0500

    LOK: always update the payload string via the cache
    
    Change-Id: I090ceb7d214d0809e86b023a8806b6655627918a
    Reviewed-on: https://gerrit.libreoffice.org/67894
    Tested-by: Jenkins
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit d3ac7c7963d6773f4257d29717094724e805a1da
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Wed Feb 13 18:18:35 2019 -0500

    LOK: Validate cached queued callback payloads
    
    And with DBG_UTIL validate and dump LOK queue state.
    
    Change-Id: I211ddf89dbcecf17c4f1401e5d96919c4bc966ea
    Reviewed-on: https://gerrit.libreoffice.org/67893
    Tested-by: Jenkins
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit 8194811cb3683eb0dde905878b5906a64ea86ede
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Thu Feb 14 10:52:33 2019 -0500

    LOK: Cache JSON payloads
    
    Change-Id: I81f74027363d4b2959c053057851cf01fc94af8b
    Reviewed-on: https://gerrit.libreoffice.org/67892
    Tested-by: Jenkins
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit c0c3459b0f272186ca915a59071d9728e9b54837
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Thu Feb 14 10:49:57 2019 -0500

    LOK: Cache RectangleAndPart payloads
    
    Change-Id: I3a2d98426729ad1b4e43a8f657b512679be82c26
    Reviewed-on: https://gerrit.libreoffice.org/67891
    Tested-by: Jenkins
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit 5163484c62743c37f4561f9785f8b4974cbd0dd1
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Wed Feb 13 08:27:09 2019 -0500

    LOK: Use a struct instead of std::pair to support caching
    
    Change-Id: I48e8de8709e017f2667c0bf2c850004128c840d1
    Reviewed-on: https://gerrit.libreoffice.org/67890
    Tested-by: Jenkins
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit a0b24b6885dbeace806530a8f4521251667d4392
Author: Ashod Nakashian <ashod.nakashian at collabora.co.uk>
Date:   Wed Feb 13 13:51:14 2019 -0500

    LOK: Move RectangleAndPart to the header
    
    This is in preparation to cache them.
    
    Change-Id: Ic511caf5a8798750288e9271f6898ab38fe2055f
    Reviewed-on: https://gerrit.libreoffice.org/67889
    Tested-by: Jenkins
    Reviewed-by: Ashod Nakashian <ashnakash at gmail.com>

commit 2695da2bf49592c81dee45ac66dd8ff19d544be8
Author: Tor Lillqvist <tml at collabora.com>
Date:   Fri Feb 15 17:47:47 2019 +0200

    Mention that temporaryHackToInvokeCallbackHandlers() is for LibreOfficeLight
    
    Change-Id: I0b53fea8df48bea17c56678d6d9b7d43c571d0a1

commit aaf6e761ec5a133a4a900321cc60cc80f490a92d
Author: Henry Castro <hcastro at collabora.com>
Date:   Wed Feb 6 17:38:35 2019 -0400

    lok: intercept the UNO command ".uno:EditRegion"
    
    Change-Id: I3a1072e6ededbd0322c4b1dcd0ef4b16ace219d1
    Reviewed-on: https://gerrit.libreoffice.org/67478
    Reviewed-by: Jan Holesovsky <kendy at collabora.com>
    Tested-by: Jan Holesovsky <kendy at collabora.com>
    (cherry picked from commit 32555d9b5c9ef37276984eaa9d9b84007fd02038)
    Reviewed-on: https://gerrit.libreoffice.org/67482
    Tested-by: Jenkins

commit 61b38fe0c2b14a5d7b5a1aa306a8d3ab6aa1d474
Author: Jan Holesovsky <kendy at collabora.com>
Date:   Fri Jan 11 11:39:29 2019 +0100

    lok: We cannot skip duplicates of SELECTION_START / _END.
    
    The scenario is like this (see the unit test):
    
    * double-click a word to select it (the handles appear)
    * click somewhere else (the selection and handles disappear)
    * double-click the same word again (the handles did not appear in this
      case)
    
    The reason was that the old state was remembered and the now thought
    duplicate state was discarded.
    
    Change-Id: Ia49200f12907c520067258b7570d4e21b365a8dd
    Reviewed-on: https://gerrit.libreoffice.org/66171
    Tested-by: Jenkins
    Reviewed-by: Jan Holesovsky <kendy at collabora.com>

commit b6e8db3b3d008d5ad2607e3d2f1787d482ab824a
Author: Tomaž Vajngerl <tomaz.vajngerl at collabora.co.uk>
Date:   Mon Dec 31 12:27:39 2018 +0100

    lok: add signDocument to "Office" iface - to sign not opened docs.
    
    LOKit function "signDocument" can sign document without the need
    to open them. This is useful to sign PDF documents after they are
    created from a currently opened (ODF, DOCX) document.
    
    This adds DocumentDigner to sfx2, which could also be used in
    desktop LibreOffice without opening them and in further tests.
    
    Change-Id: Id6f242e817f594aa672f94f9c6f9b34e4035d46a
    Reviewed-on: https://gerrit.libreoffice.org/65767
    Tested-by: Jenkins
    Reviewed-by: Tomaž Vajngerl <quikee at gmail.com>

commit eb1c94526e1fe0fe6dfca7ca2cf5e5596dd20b11
Author: Tomaž Vajngerl <tomaz.vajngerl at collabora.co.uk>
Date:   Thu Nov 29 21:53:48 2018 +0100

    Add SolarMutexGuard where needed
    
    When triggering rechecking of signature status, an assert fails and
    brings down the program because we don't hold a SolarMutex. The
    rechecking of signature status needs to broadcasts.
    
    Change-Id: Ib500b06d2e191465df1e0da2097ddb1b6b06725a
    Reviewed-on: https://gerrit.libreoffice.org/64292
    Tested-by: Jenkins
    Reviewed-by: Tomaž Vajngerl <quikee at gmail.com>

commit 5caca2a062b18f4c5603c92a60875e3234fd5156
Author: Tomaž Vajngerl <tomaz.vajngerl at collabora.co.uk>
Date:   Thu Nov 29 21:52:26 2018 +0100

    lokit: convert PEM certificate to DER if it is detected as such
    
    Change-Id: I1ae105067c109a32f4acc34749b425d9e4e26514
    Reviewed-on: https://gerrit.libreoffice.org/64291
    Tested-by: Jenkins
    Reviewed-by: Tomaž Vajngerl <quikee at gmail.com>