[Libreoffice-commits] core.git: vcl/source

[Stephan Bergmann (via logerrit)]

 vcl/source/window/layout.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit dcf5d33229a630c9bd648665a88602cda7204c43
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Wed Aug 7 14:15:25 2019 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Thu Aug 8 08:45:00 2019 +0200

    nSize shall presumably be of type long, not double
    
    It was introduced with 6f660293885733e64602aa6144c36ed7e7b43faf "implement
    VclVPaned and decripple formula panel", but using double was presumably a typo,
    as it is initialized with a long value (Splitter::GetSplitPosPixel()), is
    combined with other long values (Size::Height()), and passed to long
    nSecondHeight parameter of VclVPaned::arrange.
    
    Change-Id: Ida41eac092d8242561ce35195fd9fd3c8da7f373
    Reviewed-on: https://gerrit.libreoffice.org/77107
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/vcl/source/window/layout.cxx b/vcl/source/window/layout.cxx
index 58ac1c5cd482..f5beadaf0a9f 100644
--- a/vcl/source/window/layout.cxx
+++ b/vcl/source/window/layout.cxx
@@ -2501,7 +2501,7 @@ void VclVPaned::dispose()
 
 IMPL_LINK(VclVPaned, SplitHdl, Splitter*, pSplitter, void)
 {
-    double nSize = pSplitter->GetSplitPosPixel();
+    long nSize = pSplitter->GetSplitPosPixel();
     Size aSplitterSize(m_pSplitter->GetSizePixel());
     Size aAllocation(GetSizePixel());
     arrange(aAllocation, nSize, aAllocation.Height() - nSize - aSplitterSize.Height());