[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - sc/source

Xisco Fauli (via logerrit) logerrit at kemper.freedesktop.org
Wed Aug 14 07:05:18 UTC 2019


 sc/source/ui/view/gridwin2.cxx |    6 ++++++
 1 file changed, 6 insertions(+)

New commits:
commit f6c78ee996e87c8f7f0d162e06bc2ce6c7633481
Author:     Xisco Fauli <xiscofauli at libreoffice.org>
AuthorDate: Tue Aug 13 13:38:04 2019 +0200
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Wed Aug 14 09:04:37 2019 +0200

    tdf#126848: sc pivot table popup: avoid flicker
    
    Follow-up of 4dadbff74eff5f8ad00df99c659f8a2b914e09a1
    
    Regression from commit a4cb27f61376d8f2d8faed0022c291af68d437bd
    
    Change-Id: I4d0cd2ad2d7d239307c48c9bc8c1f1ced6597f47
    Reviewed-on: https://gerrit.libreoffice.org/77408
    Tested-by: Jenkins
    Reviewed-by: Xisco FaulĂ­ <xiscofauli at libreoffice.org>
    (cherry picked from commit 1352b1fcfa1668081c3197a12d5362286f8f9710)
    Reviewed-on: https://gerrit.libreoffice.org/77427
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>

diff --git a/sc/source/ui/view/gridwin2.cxx b/sc/source/ui/view/gridwin2.cxx
index aef8160eedc7..18477202d8af 100644
--- a/sc/source/ui/view/gridwin2.cxx
+++ b/sc/source/ui/view/gridwin2.cxx
@@ -469,6 +469,12 @@ void ScGridWindow::DPLaunchFieldPopupMenu(const Point& rScrPos, const Size& rScr
 
     mpDPFieldPopup.disposeAndClear();
     mpDPFieldPopup.reset(VclPtr<ScCheckListMenuWindow>::Create(this, pViewData->GetDocument()));
+
+    // Avoid flicker when hovering over the menu items.
+    if (!IsNativeControlSupported(ControlType::Pushbutton, ControlPart::Focus))
+        // If NWF renders the focus rects itself, that breaks double-buffering.
+        mpDPFieldPopup->RequestDoubleBuffering(true);
+
     mpDPFieldPopup->setName("DataPilot field member popup");
     mpDPFieldPopup->setExtendedData(std::move(pDPData));
     mpDPFieldPopup->setOKAction(new DPFieldPopupOKAction(this));


More information about the Libreoffice-commits mailing list