[Libreoffice-commits] core.git: vcl/qa

[Stephan Bergmann (via logerrit)]

 vcl/qa/cppunit/timer.cxx |    1 -
 1 file changed, 1 deletion(-)

New commits:
commit 92e42a0fde32e3f2dbe2c786a0e41547e4912b4b
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Fri Aug 16 09:56:29 2019 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Fri Aug 16 10:49:40 2019 +0200

    Drop bogus check from TimerTest::testStopwatch
    
    (that had been added with 6e13585508ca3c9b66c6571ad1eb42bfcb66ef0b "Add a
    TaskStopwatch to interrupt idle loops").  For each StopwatchIdle, m_nIters
    counts the calls to Invoke before it calls Stop (which it calls based on
    tools::Time::GetSystemTicks calculations).  But the number of such
    GetSystemTicks() spent in each Invoke is nondeterministic (it can e.g. be
    affected by the overall system load), so a2Idle may Stop prior to a1Idle and
    thus have a lower nIter2 than nIter1.
    
    Change-Id: I416eee9774c3605be25e9832b24dec7d9dcb00c2
    Reviewed-on: https://gerrit.libreoffice.org/77561
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/vcl/qa/cppunit/timer.cxx b/vcl/qa/cppunit/timer.cxx
index 39734ae18b85..1c5913d287de 100644
--- a/vcl/qa/cppunit/timer.cxx
+++ b/vcl/qa/cppunit/timer.cxx
@@ -595,7 +595,6 @@ void TimerTest::testStopwatch()
 
         bool b1Done = a1Idle.isDone(n1Iter);
         bool b2Done = a2Idle.isDone(n2Iter);
-        CPPUNIT_ASSERT(n1Iter >= n2Iter);
 
         if (b1Done && b2Done)
             break;