[Libreoffice-commits] core.git: vcl/unx

Jan-Marek Glogowski (via logerrit) logerrit at kemper.freedesktop.org
Fri Aug 16 12:37:13 UTC 2019


 vcl/unx/gtk3/gtk3gtkframe.cxx |    4 ++++
 1 file changed, 4 insertions(+)

New commits:
commit c70b86588fe56f3e1077f3f904c379afda70c6be
Author:     Jan-Marek Glogowski <jan-marek.glogowski at extern.cib.de>
AuthorDate: Fri Aug 16 11:43:23 2019 +0200
Commit:     Jan-Marek Glogowski <glogow at fbihome.de>
CommitDate: Fri Aug 16 14:36:35 2019 +0200

    Gtk3 inform LO of drag leave
    
    Actually the correct code was added in commit 0b354d18ccfc
    ("Related: tdf#93054 gtk3: implement enough dnd to be dragged
    into.."), but never enabled and then removed in commit c3074cb57843
    ("vcl: remove dead code). It's at least needed, so D'n'D between
    two LO Calc windows correctly removes the pre-drop cell rectangle,
    when the mouse leaves the 2nd window without doing the drop.
    
    Commit references:
    * 0b354d18ccfc05e7c2582f851d9201e2aa353d7d
    * c3074cb5784329eaf558c2f58d96a64085b42d48
    
    Change-Id: I55461f0c87cdef7a03fc261b363dc82642a3933d
    Reviewed-on: https://gerrit.libreoffice.org/77568
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Jenkins
    Reviewed-by: Jan-Marek Glogowski <glogow at fbihome.de>

diff --git a/vcl/unx/gtk3/gtk3gtkframe.cxx b/vcl/unx/gtk3/gtk3gtkframe.cxx
index c4ed383798ef..53d492f4b8aa 100644
--- a/vcl/unx/gtk3/gtk3gtkframe.cxx
+++ b/vcl/unx/gtk3/gtk3gtkframe.cxx
@@ -3610,6 +3610,10 @@ void GtkDropTarget::signalDragLeave(GtkWidget* pWidget, GdkDragContext* /*contex
 {
     m_bInDrag = false;
     gtk_drag_unhighlight(pWidget);
+
+    css::datatransfer::dnd::DropTargetEvent aEvent;
+    aEvent.Source = static_cast<css::datatransfer::dnd::XDropTarget*>(this);
+    fire_dragExit(aEvent);
 }
 
 void GtkSalFrame::signalDestroy( GtkWidget* pObj, gpointer frame )


More information about the Libreoffice-commits mailing list