[Libreoffice-commits] core.git: stoc/test

Stephan Bergmann (via logerrit) logerrit at kemper.freedesktop.org
Fri Aug 16 19:23:24 UTC 2019


 stoc/test/uriproc/test_uriproc.cxx |    6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

New commits:
commit db7701a3072117e9808e73bc3a071b236daacfc5
Author:     Stephan Bergmann <sbergman at redhat.com>
AuthorDate: Fri Aug 16 16:44:38 2019 +0200
Commit:     Stephan Bergmann <sbergman at redhat.com>
CommitDate: Fri Aug 16 21:22:35 2019 +0200

    Fix tests taken from RFC 2396
    
    "/g" was missing, and "http:g" had an extra "." (consistently applied to all
    three occurrences of "http", but for unclear reasons).
    
    (<https://www.rfc-editor.org/errata/eid452> claims that "?y" is an invalid
    example that should be removed, but our algorithm does resolve it to the value
    <http://a/b/c/?y> originally given in RFC 2396, so lets keep it for now.)
    
    Change-Id: I3187abd36135723bd13293367a6cb6c06ca70b90
    Reviewed-on: https://gerrit.libreoffice.org/77602
    Tested-by: Jenkins
    Reviewed-by: Stephan Bergmann <sbergman at redhat.com>

diff --git a/stoc/test/uriproc/test_uriproc.cxx b/stoc/test/uriproc/test_uriproc.cxx
index 7b30dd84375f..dbf095a3bd04 100644
--- a/stoc/test/uriproc/test_uriproc.cxx
+++ b/stoc/test/uriproc/test_uriproc.cxx
@@ -300,6 +300,8 @@ void Test::testMakeAbsolute() {
           css::uri::RelativeUriExcessParentSegments_ERROR, "http://a/b/c/g" },
         { "http://a/b/c/d;p?q", "g/", true,
           css::uri::RelativeUriExcessParentSegments_ERROR, "http://a/b/c/g/" },
+        { "http://a/b/c/d;p?q", "/g", true,
+          css::uri::RelativeUriExcessParentSegments_ERROR, "http://a/g" },
         { "http://a/b/c/d;p?q", "//g", true,
           css::uri::RelativeUriExcessParentSegments_ERROR, "http://g" },
         { "http://a/b/c/d;p?q", "?y", true,
@@ -396,8 +398,8 @@ void Test::testMakeAbsolute() {
         { "http://a/b/c/d;p?q", "g#s/../x", true,
           css::uri::RelativeUriExcessParentSegments_ERROR,
           "http://a/b/c/g#s/../x" },
-        { "http.://a/b/c/d;p?q", "http.:g", true,
-          css::uri::RelativeUriExcessParentSegments_ERROR, "http.:g" },
+        { "http://a/b/c/d;p?q", "http:g", true,
+          css::uri::RelativeUriExcessParentSegments_ERROR, "http:g" },
 
         { "scheme://a", "", true,
           css::uri::RelativeUriExcessParentSegments_ERROR, "scheme://a" },


More information about the Libreoffice-commits mailing list