[Libreoffice-commits] core.git: sw/qa

Miklos Vajna (via logerrit) logerrit at kemper.freedesktop.org
Fri Aug 16 21:36:15 UTC 2019


 sw/qa/extras/uiwriter/uiwriter2.cxx |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit d658e1f5e88b82dbd9c0ba48e5b742a3872b0453
Author:     Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Fri Aug 16 16:56:15 2019 +0200
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Fri Aug 16 23:35:30 2019 +0200

    CppunitTest_sw_uiwriter: fix top/left confusion in testImageComment
    
    This worked before as usually both are 1418, but in the case of
    <https://ci.libreoffice.org/job/gerrit_windows/43226/console> the left
    is a larger value (4194), while the top stays the same.
    
    Change-Id: Ie31cb29720f6426ad9e2a28405f326e6e82febaa
    Reviewed-on: https://gerrit.libreoffice.org/77597
    Tested-by: Jenkins
    Reviewed-by: Miklos Vajna <vmiklos at collabora.com>

diff --git a/sw/qa/extras/uiwriter/uiwriter2.cxx b/sw/qa/extras/uiwriter/uiwriter2.cxx
index d2035512c393..e59f84a68c68 100644
--- a/sw/qa/extras/uiwriter/uiwriter2.cxx
+++ b/sw/qa/extras/uiwriter/uiwriter2.cxx
@@ -1626,6 +1626,7 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testImageComment)
     CPPUNIT_ASSERT_GREATER(static_cast<size_t>(0), rAnchored.size());
     SwAnchoredObject* pObject = rAnchored[0];
     long nFrameLeft = pObject->GetObjRect().Left();
+    long nFrameTop = pObject->GetObjRect().Top();
 
     // Make sure that the anchor points to the bottom left corner of the image.
     // Without the accompanying fix in place, this test would have failed with:
@@ -1659,7 +1660,7 @@ CPPUNIT_TEST_FIXTURE(SwUiWriterTest2, testImageComment)
         OString aExpected;
         aExpected += OString::number(nFrameLeft);
         aExpected += ", ";
-        aExpected += OString::number(nFrameLeft);
+        aExpected += OString::number(nFrameTop);
         aExpected += ", 0, 0";
         CPPUNIT_ASSERT_EQUAL(aExpected, aAnchorPos);
     }


More information about the Libreoffice-commits mailing list