[Libreoffice-commits] core.git: Branch 'libreoffice-6-3' - vcl/source

Caolán McNamara (via logerrit) logerrit at kemper.freedesktop.org
Mon Aug 19 06:56:40 UTC 2019


 vcl/source/app/salvtables.cxx |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

New commits:
commit 7eefb0ffb8d7bde110a76f000022c61f933663c4
Author:     Caolán McNamara <caolanm at redhat.com>
AuthorDate: Fri Aug 16 08:54:45 2019 +0100
Commit:     Xisco Faulí <xiscofauli at libreoffice.org>
CommitDate: Mon Aug 19 08:56:06 2019 +0200

    Resolves: tdf#126951 crash in custom slide show
    
    on selecting entry 0 which doesn't exist
    
    Change-Id: I67656bed63f9055bc6c5dd5781e79f967996500d
    Reviewed-on: https://gerrit.libreoffice.org/77560
    Tested-by: Jenkins
    Reviewed-by: Caolán McNamara <caolanm at redhat.com>
    Tested-by: Caolán McNamara <caolanm at redhat.com>
    (cherry picked from commit 5d3e9ababc0b3e049a7556b210bb6349e3e3322c)
    Reviewed-on: https://gerrit.libreoffice.org/77695
    Reviewed-by: Xisco Faulí <xiscofauli at libreoffice.org>

diff --git a/vcl/source/app/salvtables.cxx b/vcl/source/app/salvtables.cxx
index ceff007c408b..ee08923d8088 100644
--- a/vcl/source/app/salvtables.cxx
+++ b/vcl/source/app/salvtables.cxx
@@ -3004,7 +3004,7 @@ public:
     {
         assert(m_xTreeView->IsUpdateMode() && "don't select when frozen");
         disable_notify_events();
-        if (pos == -1)
+        if (pos == -1 || (pos == 0 && n_children() == 0))
             m_xTreeView->SelectAll(false);
         else
         {


More information about the Libreoffice-commits mailing list