[Libreoffice-commits] online.git: wsd/Storage.hpp

[Miklos Vajna (via logerrit)]

 wsd/Storage.hpp |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

New commits:
commit 532ae61caf92e8b6b477fd5d09c2da90621a7593
Author:     Miklos Vajna <vmiklos at collabora.com>
AuthorDate: Wed Aug 21 09:06:44 2019 +0200
Commit:     Miklos Vajna <vmiklos at collabora.com>
CommitDate: Wed Aug 21 09:06:50 2019 +0200

    Fix UB in StorageBase::isExitSave()
    
    StorageBase::_isExitSave was uninitialized:
    
    wsd/Storage.hpp:181:38: runtime error: load of value 190, which is not a valid value for type 'bool'
        #0 0xd02260 in StorageBase::isExitSave() const /home/vmiklos/git/libreoffice/online-san/./wsd/Storage.hpp:181:38
    
    SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior wsd/Storage.hpp:181:38 in
    
    Seen during unit-wopi-temp.
    
    Change-Id: I3284637d411450a35680f6499e9d29c6f94aa723

diff --git a/wsd/Storage.hpp b/wsd/Storage.hpp
index 491341e9a..db37087ca 100644
--- a/wsd/Storage.hpp
+++ b/wsd/Storage.hpp
@@ -128,7 +128,8 @@ public:
         _isLoaded(false),
         _forceSave(false),
         _isUserModified(false),
-        _isAutosave(false)
+        _isAutosave(false),
+        _isExitSave(false)
     {
         LOG_DBG("Storage ctor: " << LOOLWSD::anonymizeUrl(uri.toString()));
     }